[1.16.5] How do i store simple NBT data on an item?

[Alexmaster75]

The idea is simple; under this phrase there's what should i do in minecraft but for context, this item it's a nuclear fuel and i want to create a reactor to put the fuel in; so, the fuel has 2 NBT tags: (1) it's for the damage, so in time the reactor subtracts 1 unit of damage; (2) it's the enrichment percentage, so you put uranium ingots into a machine, the player selects from 1 to 100 the percentage, then the machine, with a proportion, deletes the required uranium and creates this fuel, with the value selected by the player in it. So what is the purpose of this? It's in base of the value of the fuel, that the reactor decides how would the reactivity be, the burn rate, the heat generated, ecc.

 

-> A machine sets the variable in the item created at the moment to what the player has set (because it's a percentage it must be from 1 to 100 but that's secondary)

-> The item now has this value and nothing more (other that the maxDamage() value that has been set in the registry item class)

-> The item can be putted in another machine where the value gets read for processing (this damn item should be a kind of fuel, so the maxDamage it's used to be removed 1 unit every time it's been used in time)

 

That's it, the item it's just a container of 2 NBT values and nothing more, and i can't find anything, not even on these forums, mostly because it's all from 2011 to 2017, at least where i researched; so or i am a dumbass that should not even try modding, or i can't find anything

 

 

For now this is the code i come up with:

 

package net.alexmaster75.etg.item.custom;

import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.CompoundNBT;
import javax.annotation.Nullable;

public class EnrichedUraniumFuel extends Item {
    public EnrichedUraniumFuel(Properties properties) {
        super(properties);
    }

    @Nullable
    @Override
    public CompoundNBT getShareTag(ItemStack stack) {
        final int EnrichmentPercent = 0;
        CompoundNBT nbt;
        nbt = super.getShareTag(stack);
        return nbt;
    }
}

 

Edited March 30, 2022 by Alexmaster75

[OutCraft]

Hi!

CompoundNBT works like this:

1. you get the Compound from super

2. you add things to it (there are methods for this)

3. you store it by returning it to the function

But I think you are in the wrong function. I'm not sure, however, I think you need to do this in a special method called only once

[Alexmaster75]

well, i'm literally new to minecraft modding, so even if i search as many resources as possible, i'm new to all

[Alexmaster75]

Wait, how can i do that?

[Alexmaster75]

yeah, i mean i couldn't find any method like that you said or at least, it doesn't work

Side note: I tried using something similar to the maxDamage() method but didn't succeeded

Edited March 30, 2022 by Alexmaster75

[Alexmaster75]

well it doesn't work, and i'm referring to 

5 hours ago, diesieben07 said:

Call ItemStack#getOrCreateTagElement(YourModId). You can store whatever data you want in the resulting CompoundNBT.

 

[Luis_ST]

define does not work, show what you have tried

[Alexmaster75]

 

19 minutes ago, Luis_ST said:

define does not work, show what you have tried

11 hours ago, Alexmaster75 said:

 

 

package net.alexmaster75.etg.item.custom;

import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.CompoundNBT;
import javax.annotation.Nullable;

public class EnrichedUraniumFuel extends Item {
    public EnrichedUraniumFuel(Properties properties) {
        super(properties);
    }

    @Nullable
    @Override
    public CompoundNBT getShareTag(ItemStack stack) {
        final int EnrichmentPercent = 0;
        CompoundNBT nbt;
        nbt = super.getShareTag(stack);
        return nbt;
    }
}

 

I tried this, the registration of the item it's just a registry of all the items, here's what:

package net.alexmaster75.etg.item;

import net.alexmaster75.etg.ETG;
import net.alexmaster75.etg.item.custom.EnrichedUraniumFuel;
import net.minecraft.item.Item;
import net.minecraftforge.eventbus.api.IEventBus;
import net.minecraftforge.fml.RegistryObject;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;

public class ModItemsMain {

    public static final DeferredRegister<Item> ITEMS =
            DeferredRegister.create(ForgeRegistries.ITEMS, ETG.MOD_ID);
  
  
  
  	public static final RegistryObject<Item> ENRICHED_URANIUM_FUEL = ITEMS.register("enriched_uranium_fuel",
            () -> new EnrichedUraniumFuel(new Item.Properties().group(ModItemMainGroup.MAIN_GROUP).maxDamage(2000)));
  
  
  	public static void register(IEventBus eventBus) {
        ITEMS.register(eventBus);
    }

}

I excluded all the other items just for the sake of the context

Edited March 30, 2022 by Alexmaster75

[Luis_ST]

7 hours ago, diesieben07 said:

Don't use getShareTag here.

Call ItemStack#getOrCreateTagElement(YourModId). You can store whatever data you want in the resulting CompoundNBT.

you have not tried/used this

Edited March 30, 2022 by Luis_ST

[Alexmaster75]

2 hours ago, Luis_ST said:

you have not tried/used this

i tried and it doesn't work, primarily i'm not getting where exactly i should code that piece in

[OutCraft]

Replace the getShareTag function with the getOrCreateTagElement function

[Alexmaster75]

20 minutes ago, OutCraft said:

Replace the getShareTag function with the getOrCreateTagElement function

that's it?

[Luis_ST]

8 hours ago, Alexmaster75 said:

i tried and it doesn't work, primarily i'm not getting where exactly i should code that piece in

post the code which use the code mentioned by D7 (ItemStack#getOrCreateTagElement), it is also possible that the method is called ItemStack#getOrCreateTag depends on the mappings you use

[Alexmaster75]

3 hours ago, Luis_ST said:

post the code which use the code mentioned by D7 (ItemStack#getOrCreateTagElement), it is also possible that the method is called ItemStack#getOrCreateTag depends on the mappings you use

package net.alexmaster75.etg.item.custom;

import net.alexmaster75.etg.ETG;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.CompoundNBT;

import javax.annotation.Nullable;

public class EnrichedUraniumFuel extends Item {
    public EnrichedUraniumFuel(Properties properties) {
        super(properties);
    }

    @Nullable
    @Override
    public CompoundNBT ItemStack#getOrCreateTagElement(ETG.MOD_ID) {
        super(EnrichedUraniumFuel);
        return super.getShareTag(stack);
    }
}

Am i dumb?

[Alexmaster75]

package net.alexmaster75.etg.item.custom;

import net.minecraft.item.Item;

public class EnrichedUraniumFuel extends Item {
    public EnrichedUraniumFuel(Properties properties) {
        super(properties);
    }

    public String getOrCreateTagElement(String enrichedPercentage) {
        return enrichedPercentage;
    }

}

Should resemble this?

[Alexmaster75]

yeah, calling a method it's using it in another context, while override it's taking a piece of another method

anyway i want to be clear: i may not know well java, but i'm trying to understand at the moment, even if some definitions must be understood well to comprehend

[Alexmaster75]

i'm trying to access that method from, i don't even remember, i found this "https://nekoyue.github.io/ForgeJavaDocs-NG/javadoc/1.16.5/net/minecraft/item/ItemStack.html" but i don't know if it is correct or anything; i didn't take any java class irl but i don't think calling this method should be this complicated, or the more logical thing would be that i'm just stupid and i'm not getting such a simple idea

[Alexmaster75]

29 minutes ago, diesieben07 said:

I would advise you to just look at the code in your IDE

where is it, it's obviously more logical looking in the IDE and i swear that was the first thing i did, but didn't find it

It would be way more easy understand from the file that from examples online