[1.18.2] Crash when adding custom Tree to Biome

[Skyriis]

Hey Guys,

i've created a custom Tree and would love to spawn it in my Biome. But crashes when clicking on the single player button after adding the Tree to the Biome.

My Code:

public class TensuraTreeFeatures {
  public static final Holder<ConfiguredFeature<TreeConfiguration, ?>> SAKURA = FeatureUtils.register("sakura", Feature.TREE,
        basicTree(TensuraBlocks.SAKURA_LOG, TensuraBlocks.SAKURA_LEAVES));

  public static final Holder<PlacedFeature> SAKURA_CHECKED = PlacementUtils.register("sakura_tree", TensuraTreeFeatures.SAKURA,
        PlacementUtils.filteredByBlockSurvival(TensuraBlocks.SAKURA_SAPLING));



  private static TreeConfiguration basicTree(Block logBlock, Block leavesBlock) {
        return createStraightBlobTree(logBlock, leavesBlock, 4, 2, 0, 2).ignoreVines().build();
  }
  
  private static TreeConfiguration.TreeConfigurationBuilder createStraightBlobTree(Block logBlock, Block leavesBlock, int baseHeight, int p_195150_, int p_195151_, int leavesRadius) {
        return new TreeConfiguration.TreeConfigurationBuilder(BlockStateProvider.simple(logBlock),
            new StraightTrunkPlacer(baseHeight, p_195150_, p_195151_), BlockStateProvider.simple(leavesBlock),
            new BlobFoliagePlacer(ConstantInt.of(leavesRadius), ConstantInt.of(0), 3),
            new TwoLayersFeatureSize(1, 0, 1));
  }
}

 

 

[Luis_ST]

this kind of crash normally happens if you have a issue in the Registration, make sure you use DeferredRegister for all vanilla Registries this include ConfiguredFeatures and PlacedFeatures

[diesieben07]

In addition to what Luis said: Do not create the Holder yourself, ask the RegistryObject for it only when you need it.

[Skyriis]

Oh well. I guess i did the whole thing wrong.

I basically just want to add a Tree with 2 different structures (normal and big) and a small change that a bee hive spawns on the naturally generated trees.

What do i need to do for that?

[diesieben07]

Use DeferredRegister to register your ConfiguredFeature and PlacedFeature.

[Skyriis]

How do i register those?

i've tried to register them like that:

class FeatureRegistry {
    static void register(final DeferredRegister<Feature<?>> registry) { 
        registry.register("sakura_tree", () -> new ConfiguredFeature<>(Feature.TREE, basicTree(TensuraBlocks.SAKURA_LOG, TensuraBlocks.SAKURA_LEAVES)));
    }
  
    private static TreeConfiguration basicTree(Block logBlock, Block leavesBlock) {
        return createStraightBlobTree(logBlock, leavesBlock, 4, 2, 0, 2).ignoreVines().build();
    }

    private static TreeConfiguration.TreeConfigurationBuilder createStraightBlobTree(Block logBlock, Block leavesBlock, int baseHeight, int p_195150_, int p_195151_, int leavesRadius) {
        return new TreeConfiguration.TreeConfigurationBuilder(BlockStateProvider.simple(logBlock),
            new StraightTrunkPlacer(baseHeight, p_195150_, p_195151_), BlockStateProvider.simple(leavesBlock),
            new BlobFoliagePlacer(ConstantInt.of(leavesRadius), ConstantInt.of(0), 3),
            new TwoLayersFeatureSize(1, 0, 1));
    }
}

but ConfiguredFeature isn't a Featue. Do i need to use an other registy instead of ForgeRegistries.FEATURES?

[diesieben07]

Registry.CONFIGURED_FEATURE_REGISTRY

[Skyriis]

i'm still running into a small problem with my object holder.

java.lang.IllegalStateException: The ObjectHolder annotation cannot apply to a field that does not map to a registry. Ensure the registry was created during the RegistryEvent.NewRegistry event. (found : net.minecraft.world.level.levelgen.feature.ConfiguredFeature at com.borniuus.tensura.world.gen.TensuraFeatures.SAKURA_FOREST_TREES)

@ObjectHolder(Tensura.MOD_ID)
public class TensuraFeatures {
    @ObjectHolder("sakura_forest_trees")
    public static final ConfiguredFeature<RandomFeatureConfiguration, Feature<RandomFeatureConfiguration>> SAKURA_FOREST_TREES = null;
}

//registered using
registry.register("sakura_forest_trees", () -> new ConfiguredFeature<>(Feature.RANDOM_SELECTOR, new RandomFeatureConfiguration(List.of(
            new WeightedPlacedFeature(Holder.direct(TensuraPlacements.SAKURA_TREE_LARGE_CHECKED), 0.15F)
        ), Holder.direct(TensuraPlacements.SAKURA_TREE_CHECKED))));

 

[diesieben07]

Correct, you need to use DeferredRegister. @ObjectHolder only works for Forge registries.

[Skyriis]

the registry object is a DeferredRegister of Registry.CONFIGURED_FEATURE_REGISTRY

[diesieben07]

That is just the DeferredRegister. Please read its documentation for how to use it. When you register something to a DeferredRegister you receive a RegistryObject, which you need to store if you want access to the object later.

[Skyriis]

Okay instead of a NPE, i get a "Registry Object not present: tensura:sakura_forest_trees_checked" message when registering my biome. I'm registering my biome using a DeferredRegister<Biome>

 

What did i wrong now?

[diesieben07]

Post your code and the actual stacktrace.

[Skyriis]

ConfiguredFeature:

Spoiler

public class FeatureRegistry {
    private static final BeehiveDecorator BEEHIVE = new BeehiveDecorator(0.05F);
    public static RegistryObject<ConfiguredFeature<?, ?>> SAKURA_TREE, SAKURA_TREE_HIVE, SAKURA_TREE_LARGE, SAKURA_TREE_LARGE_HIVE, SAKURA_FOREST;

    static void register(final DeferredRegister<ConfiguredFeature<?, ?>> registry) {
        SAKURA_TREE = registry.register("sakura_tree", () -> new ConfiguredFeature<>(Feature.TREE, basicTree(TensuraBlocks.SAKURA_LOG, TensuraBlocks.SAKURA_LEAVES)));
        SAKURA_TREE_HIVE = registry.register("sakura_tree_hive", () -> new ConfiguredFeature<>(Feature.TREE, basicTreeWithHive(TensuraBlocks.SAKURA_LOG, TensuraBlocks.SAKURA_LEAVES)));
        SAKURA_TREE_LARGE = registry.register("sakura_tree_large", () -> new ConfiguredFeature<>(Feature.TREE, largeTree(TensuraBlocks.SAKURA_LOG, TensuraBlocks.SAKURA_LEAVES)));
        SAKURA_TREE_LARGE_HIVE = registry.register("sakura_tree_large_hive", () -> new ConfiguredFeature<>(Feature.TREE, largeTreeWithHive(TensuraBlocks.SAKURA_LOG, TensuraBlocks.SAKURA_LEAVES)));

        SAKURA_FOREST = registry.register("sakura_forest_trees", () -> new ConfiguredFeature<>(Feature.RANDOM_SELECTOR, new RandomFeatureConfiguration(List.of(
            new WeightedPlacedFeature(Holder.direct(PlacementRegistry.SAKURA_TREE_LARGE_CHECKED.get()), 0.15F)
        ), Holder.direct(PlacementRegistry.SAKURA_TREE_CHECKED.get()))));
    }

    private static TreeConfiguration largeTree(Block logBlock, Block leavesBlock) {
        return largeTree(logBlock, leavesBlock, 3, 11, 0, 4).build();
    }

    private static TreeConfiguration largeTreeWithHive(Block logBlock, Block leavesBlock) {
        return largeTree(logBlock, leavesBlock, 3, 11, 0, 4).decorators(List.of(BEEHIVE)).build();
    }

    private static TreeConfiguration basicTree(Block logBlock, Block leavesBlock) {
        return createStraightBlobTree(logBlock, leavesBlock, 4, 2, 0, 2).ignoreVines().build();
    }

    private static TreeConfiguration basicTreeWithHive(Block logBlock, Block leavesBlock) {
        return createStraightBlobTree(logBlock, leavesBlock, 4, 2, 0, 2).ignoreVines().decorators(List.of(BEEHIVE)).build();
    }

    private static TreeConfiguration.TreeConfigurationBuilder createStraightBlobTree(Block logBlock, Block leavesBlock, int baseHeight, int p_195150_, int p_195151_, int leavesRadius) {
        return new TreeConfiguration.TreeConfigurationBuilder(BlockStateProvider.simple(logBlock),
            new StraightTrunkPlacer(baseHeight, p_195150_, p_195151_), BlockStateProvider.simple(leavesBlock),
            new BlobFoliagePlacer(ConstantInt.of(leavesRadius), ConstantInt.of(0), 3),
            new TwoLayersFeatureSize(1, 0, 1));
    }

    private static TreeConfiguration.TreeConfigurationBuilder largeTree(Block logBlock, Block leavesBlock, int baseHeight, int p_195150_, int p_195151_, int leavesRadius) {
        return new TreeConfiguration.TreeConfigurationBuilder(BlockStateProvider.simple(logBlock),
            new FancyTrunkPlacer(baseHeight, p_195150_, p_195151_), BlockStateProvider.simple(leavesBlock),
            new FancyFoliagePlacer(ConstantInt.of(leavesRadius), ConstantInt.of(4), 4),
            new TwoLayersFeatureSize(0, 0, 0, OptionalInt.of(4))).ignoreVines();
    }
}

 

PlacedFeatures:

Spoiler

public class PlacementRegistry {
    public static RegistryObject<PlacedFeature> SAKURA_TREE_CHECKED, SAKURA_TREE_LARGE_CHECKED, SAKURA_FOREST_CHECKED;

    static void register(DeferredRegister<PlacedFeature> registry) {
        SAKURA_TREE_CHECKED = registry.register("sakura_tree_checked", () -> new PlacedFeature(Holder.direct(FeatureRegistry.SAKURA_TREE.get()),
            List.of(PlacementUtils.filteredByBlockSurvival(TensuraBlocks.SAKURA_SAPLING))));
        SAKURA_TREE_LARGE_CHECKED = registry.register("sakura_tree_large_checked", () -> new PlacedFeature(Holder.direct(FeatureRegistry.SAKURA_TREE_LARGE.get()),
            List.of(PlacementUtils.filteredByBlockSurvival(TensuraBlocks.SAKURA_SAPLING))));
        SAKURA_FOREST_CHECKED = registry.register("sakura_forest_trees_checked", () -> new PlacedFeature(Holder.direct(FeatureRegistry.SAKURA_TREE_LARGE.get()),
            List.of(CountPlacement.of(16), InSquarePlacement.spread(), TREE_THRESHOLD, PlacementUtils.HEIGHTMAP_OCEAN_FLOOR)));
    }
}

Biome Registry:

Spoiler

class BiomeRegistry {
    static void register(DeferredRegister<Biome> registry) {
        registry.register("sakura_forest", SakuraForestBiome::create).getKey();
    }
}

public class SakuraForestBiome {
    public static Biome create() {
        BiomeGenerationSettingsHelper generationSettingsHelper = new BiomeGenerationSettingsHelper()
            //Add Caves and Canyons
            .addCarver(GenerationStep.Carving.AIR, Carvers.CAVE)
            .addCarver(GenerationStep.Carving.AIR, Carvers.CAVE_EXTRA_UNDERGROUND)
            .addCarver(GenerationStep.Carving.AIR, Carvers.CANYON)
            //Add underground lava lakes
            .addFeature(GenerationStep.Decoration.LAKES, MiscOverworldPlacements.LAKE_LAVA_UNDERGROUND)
            //Add underground crystal formations
            .apply(BiomeDefaultFeatures::addDefaultCrystalFormations)
            //Add Monster Room Structure
            .apply(BiomeDefaultFeatures::addDefaultMonsterRoom)
            //Apply default underground variety
            .apply(BiomeDefaultFeatures::addDefaultUndergroundVariety)
            //Apply default surface freezing
            .apply(BiomeDefaultFeatures::addSurfaceFreezing)
            //Add Trees
            .addFeature(GenerationStep.Decoration.VEGETAL_DECORATION, Holder.direct(PlacementRegistry.SAKURA_FOREST_CHECKED.get()))
            //Apply mossy stones to surface
            .apply(BiomeDefaultFeatures::addMossyStoneBlock)
            //Add flowers to surface
            .apply(BiomeDefaultFeatures::addForestFlowers)
            //Add grass to surface
            .apply(BiomeDefaultFeatures::addForestGrass)
            //Add Mushrooms to surface
            .apply(BiomeDefaultFeatures::addDefaultMushrooms)
            //Add decoration plants to surface
            .apply(BiomeDefaultFeatures::addDefaultExtraVegetation)
            //Add default ores
            .apply(BiomeDefaultFeatures::addDefaultOres, BiomeDefaultFeatures::addDefaultSoftDisks);

        MobSpawnHelper mobSpawnHelper = new MobSpawnHelper()
            //Add default animals
            .apply(BiomeDefaultFeatures::farmAnimals)
            //Add default cave entities and mobs
            .apply(BiomeDefaultFeatures::commonSpawns)
            //Allow wolves to spawn
            .addSpawn(MobCategory.CREATURE, EntityType.WOLF, 5, 4, 4);

        return BiomeBuilder.forest(generationSettingsHelper, mobSpawnHelper).build();
    }
}

 

 

Full crash report: https://pastebin.com/EJaHMYFR

[Luis_ST]

store the DeferredRegister in a static final field in the class you use it

[Skyriis]

My DeferredRegister fields are in a seperate class. 

public class TensuraRegistry {
    private static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, Tensura.MOD_ID);
    private static final DeferredRegister<Block> BLOCKS = DeferredRegister.create(ForgeRegistries.BLOCKS, Tensura.MOD_ID);
    private static final DeferredRegister<SoundEvent> SOUND_EVENTS = DeferredRegister.create(ForgeRegistries.SOUND_EVENTS, Tensura.MOD_ID);
    private static final DeferredRegister<BlockEntityType<?>> BLOCK_ENTITY_TYPES = DeferredRegister.create(ForgeRegistries.BLOCK_ENTITIES, Tensura.MOD_ID);
    private static final DeferredRegister<Motive> MOTIVE = DeferredRegister.create(ForgeRegistries.PAINTING_TYPES, Tensura.MOD_ID);
    private static final DeferredRegister<Biome> BIOMES = DeferredRegister.create(ForgeRegistries.BIOMES, Tensura.MOD_ID);
    private static final DeferredRegister<ConfiguredFeature<?, ?>> CONFIGURED_FEATURES = DeferredRegister.create(Registry.CONFIGURED_FEATURE_REGISTRY, Tensura.MOD_ID);
    private static final DeferredRegister<PlacedFeature> PLACED_FEATURE = DeferredRegister.create(Registry.PLACED_FEATURE_REGISTRY, Tensura.MOD_ID);

    public static void register(IEventBus modEventBus) {
        BlockRegistry.register(ITEMS, BLOCKS); //Register Blocks with their BlockItems
        ItemRegistry.register(ITEMS); //Register Items to our Registry
        BlockEntityTypeRegistry.register(ITEMS, BLOCKS, BLOCK_ENTITY_TYPES); //Registers Block Entities including their Blocks and Items
        SoundEventRegistry.register(SOUND_EVENTS); //Register Sound Events
        MotiveRegistry.register(MOTIVE); //Register Motives for custom paintings
        ConfiguredFeatureRegistry.register(CONFIGURED_FEATURES);
        PlacedFeatureRegistry.register(PLACED_FEATURE);
        BiomeRegistry.register(BIOMES); //Register Biomes

        // Add our Registries to Forge
        BLOCKS.register(modEventBus);
        ITEMS.register(modEventBus);
        BLOCK_ENTITY_TYPES.register(modEventBus);
        SOUND_EVENTS.register(modEventBus);
        MOTIVE.register(modEventBus);
        BIOMES.register(modEventBus);
        CONFIGURED_FEATURES.register(modEventBus);
        PLACED_FEATURE.register(modEventBus);
    }
}

 

Edited May 1 by Skyriis

[Luis_ST]

do not put DeferredRegister and RegistryObject in separate classes

[Skyriis]

4 minutes ago, Luis_ST said:

do not put DeferredRegister and RegistryObject in separate classes

why not? 

Edited May 1 by Skyriis

[Luis_ST]

It could lead problems (as you have already noticed)

[Skyriis]

I've moved the DeferredRegister fields into the same classes as their registry objects but i still crash with the same message

[diesieben07]

Post updated code.

[Skyriis]

 ConfiguredFeature:

Spoiler

public class FeatureRegistry {
    private static final DeferredRegister<ConfiguredFeature<?, ?>> registry = DeferredRegister.create(Registry.CONFIGURED_FEATURE_REGISTRY, Tensura.MOD_ID);
    private static final BeehiveDecorator BEEHIVE = new BeehiveDecorator(0.05F);
    public static RegistryObject<ConfiguredFeature<?, ?>> SAKURA_TREE, SAKURA_TREE_HIVE, SAKURA_TREE_LARGE, SAKURA_TREE_LARGE_HIVE, SAKURA_FOREST;

    static void register(final IEventBus modBus) {
        SAKURA_TREE = registry.register("sakura_tree", () -> new ConfiguredFeature<>(Feature.TREE, basicTree(TensuraBlocks.SAKURA_LOG, TensuraBlocks.SAKURA_LEAVES)));
        SAKURA_TREE_HIVE = registry.register("sakura_tree_hive", () -> new ConfiguredFeature<>(Feature.TREE, basicTreeWithHive(TensuraBlocks.SAKURA_LOG, TensuraBlocks.SAKURA_LEAVES)));
        SAKURA_TREE_LARGE = registry.register("sakura_tree_large", () -> new ConfiguredFeature<>(Feature.TREE, largeTree(TensuraBlocks.SAKURA_LOG, TensuraBlocks.SAKURA_LEAVES)));
        SAKURA_TREE_LARGE_HIVE = registry.register("sakura_tree_large_hive", () -> new ConfiguredFeature<>(Feature.TREE, largeTreeWithHive(TensuraBlocks.SAKURA_LOG, TensuraBlocks.SAKURA_LEAVES)));

        SAKURA_FOREST = registry.register("sakura_forest_trees", () -> new ConfiguredFeature<>(Feature.RANDOM_SELECTOR, new RandomFeatureConfiguration(List.of(
            new WeightedPlacedFeature(Holder.direct(PlacementRegistry.SAKURA_TREE_LARGE_CHECKED.get()), 0.15F)
        ), Holder.direct(PlacementRegistry.SAKURA_TREE_CHECKED.get()))));
      
        registry.register(modBus);
    }

    private static TreeConfiguration largeTree(Block logBlock, Block leavesBlock) {
        return largeTree(logBlock, leavesBlock, 3, 11, 0, 4).build();
    }

    private static TreeConfiguration largeTreeWithHive(Block logBlock, Block leavesBlock) {
        return largeTree(logBlock, leavesBlock, 3, 11, 0, 4).decorators(List.of(BEEHIVE)).build();
    }

    private static TreeConfiguration basicTree(Block logBlock, Block leavesBlock) {
        return createStraightBlobTree(logBlock, leavesBlock, 4, 2, 0, 2).ignoreVines().build();
    }

    private static TreeConfiguration basicTreeWithHive(Block logBlock, Block leavesBlock) {
        return createStraightBlobTree(logBlock, leavesBlock, 4, 2, 0, 2).ignoreVines().decorators(List.of(BEEHIVE)).build();
    }

    private static TreeConfiguration.TreeConfigurationBuilder createStraightBlobTree(Block logBlock, Block leavesBlock, int baseHeight, int p_195150_, int p_195151_, int leavesRadius) {
        return new TreeConfiguration.TreeConfigurationBuilder(BlockStateProvider.simple(logBlock),
            new StraightTrunkPlacer(baseHeight, p_195150_, p_195151_), BlockStateProvider.simple(leavesBlock),
            new BlobFoliagePlacer(ConstantInt.of(leavesRadius), ConstantInt.of(0), 3),
            new TwoLayersFeatureSize(1, 0, 1));
    }

    private static TreeConfiguration.TreeConfigurationBuilder largeTree(Block logBlock, Block leavesBlock, int baseHeight, int p_195150_, int p_195151_, int leavesRadius) {
        return new TreeConfiguration.TreeConfigurationBuilder(BlockStateProvider.simple(logBlock),
            new FancyTrunkPlacer(baseHeight, p_195150_, p_195151_), BlockStateProvider.simple(leavesBlock),
            new FancyFoliagePlacer(ConstantInt.of(leavesRadius), ConstantInt.of(4), 4),
            new TwoLayersFeatureSize(0, 0, 0, OptionalInt.of(4))).ignoreVines();
    }
}

 

PlacedFeatures:

Spoiler

public class PlacementRegistry {
    private static final DeferredRegister<PlacedFeature> registry = DeferredRegister.create(Registry.PLACED_FEATURE_REGISTRY, Tensura.MOD_ID);
    public static RegistryObject<PlacedFeature> SAKURA_TREE_CHECKED, SAKURA_TREE_LARGE_CHECKED, SAKURA_FOREST_CHECKED;

    static void register(final IEventBus modBus) {
        SAKURA_TREE_CHECKED = registry.register("sakura_tree_checked", () -> new PlacedFeature(Holder.direct(FeatureRegistry.SAKURA_TREE.get()),
            List.of(PlacementUtils.filteredByBlockSurvival(TensuraBlocks.SAKURA_SAPLING))));
        SAKURA_TREE_LARGE_CHECKED = registry.register("sakura_tree_large_checked", () -> new PlacedFeature(Holder.direct(FeatureRegistry.SAKURA_TREE_LARGE.get()),
            List.of(PlacementUtils.filteredByBlockSurvival(TensuraBlocks.SAKURA_SAPLING))));
        SAKURA_FOREST_CHECKED = registry.register("sakura_forest_trees_checked", () -> new PlacedFeature(Holder.direct(FeatureRegistry.SAKURA_TREE_LARGE.get()),
            List.of(CountPlacement.of(16), InSquarePlacement.spread(), TREE_THRESHOLD, PlacementUtils.HEIGHTMAP_OCEAN_FLOOR)));
      
        registry.register(modBus);
    }
}

 

Biome Registry:

Spoiler

class BiomeRegistry {
    private static final DeferredRegister<Biome> registry = DeferredRegister.create(ForgeRegistries.BIOMES, Tensura.MOD_ID);
  
    static void register(final IEventBus modBus) {
        registry.register("sakura_forest", SakuraForestBiome::create);
        registry.register(modBus);
    }
}

 

[diesieben07]

On 4/26/2022 at 2:12 PM, diesieben07 said:

Do not create the Holder yourself, ask the RegistryObject for it only when you need it.

 

[Skyriis]

Okay that was the issue. Thank you a lot!

[Skyriis]

I ran into another Problem. My Trees now generate on top of each other:

 

 

 

 

 

 

 

How do i fix that?

Edited May 2 by Skyriis