Mixins broken after adding Parchment to project

[Mad Alchemist]

My project has only one mixin at this moment, and it is:
 

@Mixin(ZombieEntity.class)
public abstract class MixinZombieEntity {
    @Overwrite(remap = true)
    public boolean isSunSensitive() {
        if(ConfigHandler.GENERAL.burnAtDay.get()) {
            return(true);
        } else {
            return(false);
        }
    }
}

Problem is, after I have added Parchment, i am getting an error:

Zombienation\src\main\java\com\madalchemist\zombienation\mixin\MixinZombieEntity.java:14: error: No obfuscation mapping for @Overwrite method
    public boolean isSunSensitive() {
                   ^

If I set remap to false, evereything compiles ok, but vanilla zombies burn in sun even if should not.

 

[Mad Alchemist]

On 5/16/2022 at 3:36 PM, diesieben07 said:

Firstly do not use @Overwrite. Simply use a cancellable @Inject.

You are also not following the mixin documentation. If you are making a mixin for ZombieEntity, you should extend its superclass (MonsterEntity).

Souldn't this also make skeletons not burn in sun?

[Mad Alchemist]

2 minutes ago, diesieben07 said:

No? Please learn the absolute basics.

Of course, I understand that creating a new ZombieEntity by extending MonsterEntity will not make skeletons not burn in sun. But I already have lot of my own zombies, I need to modify behavior of vanilla one!

And changing ZombieEntity to MonsterEntity in mixin code made code compile again, but it just don't works now. Nothing crashes, but vanilla zombies burn to crisp every morning...

 

package com.madalchemist.zombienation.mixin;

import com.madalchemist.zombienation.ConfigHandler;
import net.minecraft.entity.monster.MonsterEntity;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;

@Mixin(MonsterEntity.class)
public abstract class MixinZombieEntity {
    @Inject(method="isSunSensitive", at=@At("HEAD"), cancellable = true)
    public void isSunSensitive(CallbackInfoReturnable<Boolean> cir) {
        cir.setReturnValue(ConfigHandler.GENERAL.burnAtDay.get());
    }
}

 

[Mad Alchemist]

29 minutes ago, diesieben07 said:

you should extend its superclass (MonsterEntity).

Where should I extend it?
Because public abstract class MixinZombieEntity extends MonsterEntity definitely is a wrong code and will not compile.

[Luis_ST]

you also need to cancel the CallbackInfoReturnable

[Mad Alchemist]

On 5/18/2022 at 11:58 AM, diesieben07 said:

That is precisely what you do and this is explained in the Mixin documentation:

• https://github.com/SpongePowered/Mixin/wiki/Introduction-to-Mixins---Understanding-Mixin-Architecture#4-only-you-mixins-can-save-mankind
• https://github.com/SpongePowered/Mixin/wiki/Introduction-to-Mixins---Understanding-Mixin-Architecture#6-is-it-a-bird-is-it-a-plane-no-its-superclass

If you do not understand these things, you should not be using Mixins. They are a very powerful (and thereby also very dangerous) tool that requires great care when used.

You speak of it as if crashing minecraft mod could disable cooling in nuclear power plant or change orbits of GPS satellites in real world... 
With such attitude, when nobody must go creative until fully mastered java, forge, mixins, etc., all we would have today is vanilla MC, maybe with very few mods written by grandmeisters and puny datapacks with sooo limited functionality.

The worst thing that really could happen, I believe, is my mod breaking someone other's mod, and modpack author is forced to remove either my mod or second one.

By the way, I found a solution somewhere in internet, but have lost a link there. Crashes and non-working mixins was not my fault! But I had to put this into build.gradle:
 

// Generate a fixed tsrg file after generating the default tsrg file
createMcpToSrg {
    outputs.upToDateWhen {false}
    doLast {
        fixFG5TsrgForMixinAP(output.get().asFile, file("${buildDir}/fixMcpToSrg/output.tsrg"))
    }
}

// Tell mixin to use the fixed TSRG file
mixin {
    reobfSrgFile = file("${buildDir}/fixMcpToSrg/output.tsrg")
}

// Function that actually fixes the TSRG file
static def fixFG5TsrgForMixinAP(File inFile, File outFile) {
    // Make directory if needed
    outFile.parentFile.mkdirs()

    try (Scanner scanner = new Scanner(inFile); PrintWriter out = new PrintWriter(outFile)) {
        boolean firstLine = true
        while (scanner.hasNextLine()) {
            String next = scanner.nextLine()

            // Skip first 'tsrg left right' header line
            if (firstLine) {
                firstLine = false
                continue
            }

            // Skip 'static' indicators
            if (next.trim() == "static") {
                continue
            }

            // Export line otherwise
            out.println(next)
        }
    }
}

And now mixins are working, and I have replaced that scary @Overwrite with @Inject
I believe it would work with initial version that used @Overwrite too...