Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

How do I get what's there in a slot in a tile entity

PadFoot2008

By PadFoot2008
in Modder Support

 Share

Recommended Posts

PadFoot2008 Tree Puncher

PadFoot2008

Posted
  • Author
Posted (edited)

I don't get what do I have to do exactly.

I'm following Kaupenjoe's tutorial: https://github.com/Tutorials-By-Kaupenjoe/Minecraft-1.16.5

Here's the TileEntity class: 

public class EnchantingPedestralTile extends TileEntity implements ITickableTileEntity {

    private final ItemStackHandler itemHandler = createHandler();
    private final LazyOptional<IItemHandler> handler = LazyOptional.of(() -> itemHandler);

    public EnchantingPedestralTile(TileEntityType<?> tileEntityTypeIn) {

        super(tileEntityTypeIn);
    }

    public EnchantingPedestralTile() {

        this(ModTileEntities.ENCHANTING_PEDESTRAL_TILE.get());
    }

    @Override
    public void read(BlockState state, CompoundNBT nbt) {
        itemHandler.deserializeNBT(nbt.getCompound("inv"));
        super.read(state, nbt);
    }

    @Override
    public CompoundNBT write(CompoundNBT compound) {
        compound.put("inv", itemHandler.serializeNBT());
        return super.write(compound);
    }

    private ItemStackHandler createHandler() {
        return new ItemStackHandler(2) {
            @Override
            protected void onContentsChanged(int slot) {
                markDirty();
            }

            @Override
            public boolean isItemValid(int slot, @Nonnull ItemStack stack) {
                return true;
            }

            @Override
            public int getSlotLimit(int slot) {
                return 1;
            }

            @Nonnull
            @Override
            public ItemStack insertItem(int slot, @Nonnull ItemStack stack, boolean simulate) {
                if(!isItemValid(slot, stack)) {
                    return stack;
                }

                return super.insertItem(slot, stack, simulate);
            }
        };
    }

    @Nonnull
    @Override
    public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {
        if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) {
            return handler.cast();
        }


        return super.getCapability(cap, side);
    }

    private void strikeLightning() {
        if(!this.world.isRemote()) {
            EntityType.LIGHTNING_BOLT.spawn((ServerWorld)world, null, null,
                    pos, SpawnReason.TRIGGERED, true, true);
        }
    }

    public void craft() {
        Inventory inv = new Inventory(itemHandler.getSlots());
        for (int i = 0; i < itemHandler.getSlots(); i++) {
            inv.setInventorySlotContents(i, itemHandler.getStackInSlot(i));
        }

        Optional<EnchantingPedestralRecipe> recipe = world.getRecipeManager()
                .getRecipe(ModRecipeTypes.ENCHANTING_RECIPE, inv, world);

        recipe.ifPresent(iRecipe -> {
            ItemStack tool = iRecipe.getRecipeOutput();

            if(iRecipe.getWeather().equals(EnchantingPedestralRecipe.Weather.CLEAR) &&
                    !world.isRaining()) {
                craftTheItem(tool);
            }

            if(iRecipe.getWeather().equals(EnchantingPedestralRecipe.Weather.RAIN) &&
                    world.isRaining()) {
                craftTheItem(tool);
            }

            if(iRecipe.getWeather().equals(EnchantingPedestralRecipe.Weather.THUNDERING) &&
                    world.isThundering()) {
                strikeLightning();
                craftTheItem(tool);
            }

            markDirty();
        });
    }

    private void craftTheItem(ItemStack tool) {
        itemHandler.extractItem(0, 1, false);
        itemHandler.extractItem(1, 1, false);
        itemHandler.insertItem(0, tool, false);
    }

    @Override
    public void tick() {
        if(world.isRemote)
            return;

        craft();
    }
}

And the custom Recipe class: 

public class EnchantingPedestralRecipe implements IEnchantingPedestralRecipe {
    public enum Weather {
        CLEAR,
        RAIN,
        THUNDERING;

        public static Weather getWeatherByString(String s) {
            return Objects.equals(s, "thundering") ? THUNDERING : Objects.equals(s, "rain") ? RAIN : CLEAR;
        }
    }

    private final ResourceLocation id;
    private final ItemStack output;
    private final NonNullList<Ingredient> recipeItems;
    private final Weather weather;

    public EnchantingPedestralRecipe(ResourceLocation id, ItemStack output,
                                    NonNullList<Ingredient> recipeItems, Weather weather) {
        this.id = id;
        this.output = output;
        this.recipeItems = recipeItems;
        this.weather = weather;
    }

    @Override
    public boolean matches(IInventory inv, World worldIn) {
        // Checks for correct focus (Glass Pane)
        if(recipeItems.get(0).test(inv.getStackInSlot(0))) {
            return recipeItems.get(1).test(inv.getStackInSlot(1));
        }

        return false;
    }

    @Override
    public NonNullList<Ingredient> getIngredients() {
        return recipeItems;
    }

    @Override
    public ItemStack getCraftingResult(IInventory inv) {
        return output;
    }

    @Override
    public ItemStack getRecipeOutput() {
        return output.copy();
    }

    public Weather getWeather() {
        return this.weather;
    }

    public ItemStack getIcon() {
        return new ItemStack(ModBlocks.ENCHANTING_PEDESTRAL.get());
    }

    @Override
    public ResourceLocation getId() {
        return id;
    }

    @Override
    public IRecipeSerializer<?> getSerializer() {
        return ModRecipeTypes.ENCHANTING_SERIALIZER.get();
    }

    public static class EnchantingRecipeType implements IRecipeType<EnchantingPedestralRecipe> {
        @Override
        public String toString() {
            return EnchantingPedestralRecipe.TYPE_ID.toString();
        }
    }

    public static class Serializer extends ForgeRegistryEntry<IRecipeSerializer<?>>
            implements IRecipeSerializer<EnchantingPedestralRecipe> {


        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, JsonObject json) {
            String enchantraw = JSONUtils.getString(json, "enchantment");
            Enchantment enchant = ForgeRegistries.ENCHANTMENTS.getValue(new ResourceLocation(enchantraw));
      		
      		//Here's where I want to get what's in the first slot of my TileEntity

            ItemStack output = ShapedRecipe.deserializeItem(JSONUtils.getJsonObject(json, "output"));
            output.addEnchantment(enchant,1);

            String weather = JSONUtils.getString(json, "weather");

            JsonArray ingredients = JSONUtils.getJsonArray(json, "ingredients");
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.deserialize(ingredients.get(i)));
            }

            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, Weather.getWeatherByString(weather));
        }

        @Nullable
        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, PacketBuffer buffer) {
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.read(buffer));
            }

            ItemStack output = buffer.readItemStack();
            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, null);
        }

        @Override
        public void write(PacketBuffer buffer, EnchantingPedestralRecipe recipe) {
            buffer.writeInt(recipe.getIngredients().size());
            for (Ingredient ing : recipe.getIngredients()) {
                ing.write(buffer);
            }
            buffer.writeItemStack(recipe.getRecipeOutput(), false);
        }
    }
}

 

What do I add to the Recipe class?

Edited by PadFoot2008
Link to comment
Share on other sites
PadFoot2008 Tree Puncher

PadFoot2008

Posted
  • Author
Posted

I'm making a Tile Entity. It has 2 slots: one for a tool and the second for a crystal. The tool will be enchanted based on the crystal provided. Which enchantment will be applied in respect to the crystal is kept in a Json file. I've been able to get enchantment from the Json file and it also checks whether the correct crystal is present.

But I am unable to get the tool present in the first slot and then enchant it.

Link to comment
Share on other sites
PadFoot2008 Tree Puncher

PadFoot2008

Posted
  • Author
Posted (edited)

Wait, let me explain –

Currently, in recipe Json, there's 5 objects –

1. Weather – Returns the weather required for the recipe to work

2. Enchantment – Returns the enchantment that will be applied to the output

3. Ingredients (slot 0) – Returns the tool required in slot 0.

4. Ingredients (slot 1) – Returns the crystal required in slot 1.

5. Output – Returns the output tool.

So, I get the Output and the Enchantment and then apply the enchantment on the output and then return it in 

public EnchantingPedestralRecipe read(ResourceLocation recipeId, PacketBuffer buffer)

. And in 

public boolean matches(IInventory inv, World worldIn)

I check if Ingredient (slot 0) and Ingredient (slot 1) are placed in their respective slots.

This will be really tedious as I have to add recipes for all tools and armour and their respective Enchantments.

 

Instead, I thought it would be better if 

public boolean matches(IInventory inv, World worldIn)

would check for only the Ingredients (slot 1) in slot 1 and any tool that will be placed slot 0 shall be enchanted based it. For that I would need to get what is there in slot 0 in 

public EnchantingPedestralRecipe read(ResourceLocation recipeId, PacketBuffer buffer)

get the enchantment and then enchant it; and return it as the output. 

 

So how do I get what's kept in slot 0?

Edited by PadFoot2008
Link to comment
Share on other sites
PadFoot2008 Tree Puncher

PadFoot2008

Posted
  • Author
Posted

Thanks it worked!

But I just wanted to know how can I get the max enchantment level of an enchantment like for Power it's 5, for Fortune it's 3, etc. Is there a method I can use like: 

int enchantmentlevel = SomeClass.getEnchantmentLevel(Enchantments.SILK_TOUCH);

 

Link to comment
Share on other sites
PadFoot2008 Tree Puncher

PadFoot2008

Posted
  • Author
Posted (edited)

Hye I want a bit of help.

I modified the code to this : 

public class EnchantingPedestralRecipe implements IEnchantingPedestralRecipe {
    public enum Weather {
        CLEAR,
        RAIN,
        THUNDERING;

        public static Weather getWeatherByString(String s) {
            return Objects.equals(s, "thundering") ? THUNDERING : Objects.equals(s, "rain") ? RAIN : CLEAR;
        }
    }

    private final ResourceLocation id;
    private final ItemStack output;
    private final NonNullList<Ingredient> recipeItems;
    private final Weather weather;

    public static ItemStack outputin;

    public EnchantingPedestralRecipe(ResourceLocation id, ItemStack output,
                                    NonNullList<Ingredient> recipeItems, Weather weather) {
        this.id = id;
        this.output = output;
        this.recipeItems = recipeItems;
        this.weather = weather;
    }

    @Override
    public boolean matches(IInventory inv, World worldIn) {
        ItemStack item = inv.getStackInSlot(0);
        if(item != null) {
            if (recipeItems.get(1).test(inv.getStackInSlot(1))) {
                outputin = item;
                return recipeItems.get(1).test(inv.getStackInSlot(1));
            }
        }
        return false;
    }

    @Override
    public NonNullList<Ingredient> getIngredients() {
        return recipeItems;
    }

    @Override
    public ItemStack getCraftingResult(IInventory inv) {
        return output;
    }

    @Override
    public ItemStack getRecipeOutput() {
        return output.copy();
    }

    public Weather getWeather() {
        return this.weather;
    }

    public ItemStack getIcon() {
        return new ItemStack(ModBlocks.ENCHANTING_PEDESTRAL.get());
    }

    @Override
    public ResourceLocation getId() {
        return id;
    }

    @Override
    public IRecipeSerializer<?> getSerializer() {
        return ModRecipeTypes.ENCHANTING_SERIALIZER.get();
    }

    public static class EnchantingRecipeType implements IRecipeType<EnchantingPedestralRecipe> {
        @Override
        public String toString() {
            return EnchantingPedestralRecipe.TYPE_ID.toString();
        }
    }

    public static class Serializer extends ForgeRegistryEntry<IRecipeSerializer<?>>
            implements IRecipeSerializer<EnchantingPedestralRecipe> {


        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, JsonObject json) {
            String enchantraw = JSONUtils.getString(json, "enchantment");
            Enchantment enchant = ForgeRegistries.ENCHANTMENTS.getValue(new ResourceLocation(enchantraw));

            ItemStack output;

            if (outputin != null) {
                output = outputin;
                int i = EnchantmentHelper.getEnchantmentLevel(enchant, output);
                int j = enchant.getMaxLevel();
                int k = i++;
                if (output.isEnchantable() == true) {
                    if (i<j) {
                        output.addEnchantment(enchant, k);
                    }
                }
            } else {
                output = new ItemStack(Items.BELL);
            }

            String weather = JSONUtils.getString(json, "weather");

            JsonArray ingredients = JSONUtils.getJsonArray(json, "ingredients");
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.deserialize(ingredients.get(i)));
            }

            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, Weather.getWeatherByString(weather));
        }

        @Nullable
        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, PacketBuffer buffer) {
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.read(buffer));
            }

            ItemStack output = buffer.readItemStack();
            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, null);
        }

        @Override
        public void write(PacketBuffer buffer, EnchantingPedestralRecipe recipe) {
            buffer.writeInt(recipe.getIngredients().size());
            for (Ingredient ing : recipe.getIngredients()) {
                ing.write(buffer);
            }
            buffer.writeItemStack(recipe.getRecipeOutput(), false);
        }
    }
}

And when I run Minecraft, it always outputs a bell, instead of enchanting the item? What's the mistake I've done? How do I solve it?

Edited by PadFoot2008
Link to comment
Share on other sites
PadFoot2008 Tree Puncher

PadFoot2008

Posted
  • Author
Posted
34 minutes ago, PadFoot2008 said: 
output.addEnchantment(enchant, k);

It does enchant.

8 minutes ago, diesieben07 said:

Why is this static? Do you know what static means? Why is this assigned in matches? The values inside a recipe instance should really be immutable, i.e. the recipe should be stateless.

So what do I do? You know what I want to do. I have told that earlier in this post itself. Please help.

Link to comment
Share on other sites
PadFoot2008 Tree Puncher

PadFoot2008

Posted
  • Author
Posted

Okay, but what do I add here? 

@Nullable
        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, PacketBuffer buffer) {
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.read(buffer));
            }

            ItemStack output = buffer.readItemStack();
            //What do I add here
            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, null, enchant);
        }

The whole code (as of now): 

package com.padfoot.immersivesurvival.data.recipes;

import com.google.gson.Gson;
import com.google.gson.JsonArray;
import com.google.gson.JsonDeserializer;
import com.google.gson.JsonObject;
import com.padfoot.immersivesurvival.block.ModBlocks;
import com.padfoot.immersivesurvival.container.EnchantingPedestralContainer;
import com.padfoot.immersivesurvival.screen.EnchantingPedestralScreen;
import com.padfoot.immersivesurvival.tileentity.EnchantingPedestralTile;
import net.minecraft.enchantment.*;
import net.minecraft.entity.item.minecart.MinecartEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.entity.player.PlayerInventory;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.Inventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import net.minecraft.item.crafting.IRecipeSerializer;
import net.minecraft.item.crafting.IRecipeType;
import net.minecraft.item.crafting.Ingredient;
import net.minecraft.item.crafting.ShapedRecipe;
import net.minecraft.nbt.ListNBT;
import net.minecraft.network.PacketBuffer;
import net.minecraft.util.JSONUtils;
import net.minecraft.util.NonNullList;
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.World;
import net.minecraftforge.client.MinecraftForgeClient;
import net.minecraftforge.items.IItemHandler;
import net.minecraftforge.registries.ForgeRegistries;
import net.minecraftforge.registries.ForgeRegistryEntry;

import javax.annotation.Nullable;
import java.util.Arrays;
import java.util.Objects;

public class EnchantingPedestralRecipe implements IEnchantingPedestralRecipe {
    public enum Weather {
        CLEAR,
        RAIN,
        THUNDERING;

        public static Weather getWeatherByString(String s) {
            return Objects.equals(s, "thundering") ? THUNDERING : Objects.equals(s, "rain") ? RAIN : CLEAR;
        }
    }

    private final ResourceLocation id;
    private final ItemStack output;
    private final NonNullList<Ingredient> recipeItems;
    private final Weather weather;
    private final Enchantment enchant;

    public EnchantingPedestralRecipe(ResourceLocation id, ItemStack output,
                                    NonNullList<Ingredient> recipeItems, Weather weather, Enchantment enchant) {
        this.id = id;
        this.output = output;
        this.recipeItems = recipeItems;
        this.weather = weather;
        this.enchant = enchant;
    }

    @Override
    public boolean matches(IInventory inv, World worldIn) {
            if (recipeItems.get(1).test(inv.getStackInSlot(1))) {
                return recipeItems.get(1).test(inv.getStackInSlot(1));
        }
        return false;
    }

    @Override
    public NonNullList<Ingredient> getIngredients() {
        return recipeItems;
    }

    @Override
    public ItemStack getCraftingResult(IInventory inv) {
        ItemStack output = inv.getStackInSlot(0);
        int i = EnchantmentHelper.getEnchantmentLevel(enchant, output);
        int j = enchant.getMaxLevel();
        int k = i++;
        if (output.isEnchantable() == true) {
            if (i<j) {
                    output.addEnchantment(enchant, k);
            }
        }
        return output;
    }

    @Override
    public ItemStack getRecipeOutput() {
        return output.copy();
    }

    public Weather getWeather() {
        return this.weather;
    }

    public ItemStack getIcon() {
        return new ItemStack(ModBlocks.ENCHANTING_PEDESTRAL.get());
    }

    @Override
    public ResourceLocation getId() {
        return id;
    }

    @Override
    public IRecipeSerializer<?> getSerializer() {
        return ModRecipeTypes.ENCHANTING_SERIALIZER.get();
    }

    public static class EnchantingRecipeType implements IRecipeType<EnchantingPedestralRecipe> {
        @Override
        public String toString() {
            return EnchantingPedestralRecipe.TYPE_ID.toString();
        }
    }

    public static class Serializer extends ForgeRegistryEntry<IRecipeSerializer<?>>
            implements IRecipeSerializer<EnchantingPedestralRecipe> {


        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, JsonObject json) {
            String enchantraw = JSONUtils.getString(json, "enchantment");
            Enchantment enchant = ForgeRegistries.ENCHANTMENTS.getValue(new ResourceLocation(enchantraw));

            ItemStack output = new ItemStack(Items.BELL);


            String weather = JSONUtils.getString(json, "weather");

            JsonArray ingredients = JSONUtils.getJsonArray(json, "ingredients");
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.deserialize(ingredients.get(i)));
            }

            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, Weather.getWeatherByString(weather), enchant);
        }

        @Nullable
        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, PacketBuffer buffer) {
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.read(buffer));
            }

            ItemStack output = buffer.readItemStack();
			//What do I add here
            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, null, enchant);
        }

        @Override
        public void write(PacketBuffer buffer, EnchantingPedestralRecipe recipe) {
            buffer.writeInt(recipe.getIngredients().size());
            for (Ingredient ing : recipe.getIngredients()) {
                ing.write(buffer);
            }
            buffer.writeItemStack(recipe.getRecipeOutput(), false);
          	//Do I add anything here?
        }
    }
}

Also do I need to anything in write method?

Link to comment
Share on other sites
PadFoot2008 Tree Puncher

PadFoot2008

Posted
  • Author
Posted (edited)

It isn't working (see code): 

public class EnchantingPedestralRecipe implements IEnchantingPedestralRecipe {
    public enum Weather {
        CLEAR,
        RAIN,
        THUNDERING;

        public static Weather getWeatherByString(String s) {
            return Objects.equals(s, "thundering") ? THUNDERING : Objects.equals(s, "rain") ? RAIN : CLEAR;
        }
    }

    private final ResourceLocation id;
    private final ItemStack output;
    private final NonNullList<Ingredient> recipeItems;
    private final Weather weather;
    private final Enchantment enchant;

    public EnchantingPedestralRecipe(ResourceLocation id, ItemStack output,
                                    NonNullList<Ingredient> recipeItems, Weather weather, Enchantment enchant) {
        this.id = id;
        this.output = output;
        this.recipeItems = recipeItems;
        this.weather = weather;
        this.enchant = enchant;
    }

    @Override
    public boolean matches(IInventory inv, World worldIn) {
            if (recipeItems.get(1).test(inv.getStackInSlot(1))) {
                return recipeItems.get(1).test(inv.getStackInSlot(1));
        }
        return false;
    }

    @Override
    public NonNullList<Ingredient> getIngredients() {
        return recipeItems;
    }

    @Override
    public ItemStack getCraftingResult(IInventory inv) {
        ItemStack output = inv.getStackInSlot(0);
        int i = EnchantmentHelper.getEnchantmentLevel(enchant, output);
        int j = enchant.getMaxLevel();
        int k = i++;
        if (output.isEnchantable() == true) {
            if (i<j) {
                    output.addEnchantment(enchant, k);
            }
        }
        return output;
    }

    @Override
    public ItemStack getRecipeOutput() {
        return output.copy();
    }

    public Enchantment getEnchant() {
        return enchant;
    }

    public Weather getWeather() {
        return this.weather;
    }

    public ItemStack getIcon() {
        return new ItemStack(ModBlocks.ENCHANTING_PEDESTRAL.get());
    }

    @Override
    public ResourceLocation getId() {
        return id;
    }

    @Override
    public IRecipeSerializer<?> getSerializer() {
        return ModRecipeTypes.ENCHANTING_SERIALIZER.get();
    }

    public static class EnchantingRecipeType implements IRecipeType<EnchantingPedestralRecipe> {
        @Override
        public String toString() {
            return EnchantingPedestralRecipe.TYPE_ID.toString();
        }
    }

    public static class Serializer extends ForgeRegistryEntry<IRecipeSerializer<?>>
            implements IRecipeSerializer<EnchantingPedestralRecipe> {


        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, JsonObject json) {
            String enchantraw = JSONUtils.getString(json, "enchantment");
            Enchantment enchant = ForgeRegistries.ENCHANTMENTS.getValue(new ResourceLocation(enchantraw));

            ItemStack output = null; //I know this is incorrect; what do I do?


            String weather = JSONUtils.getString(json, "weather");

            JsonArray ingredients = JSONUtils.getJsonArray(json, "ingredients");
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.deserialize(ingredients.get(i)));
            }

            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, Weather.getWeatherByString(weather), enchant);
        }

        @Nullable
        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, PacketBuffer buffer) {
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.read(buffer));
            }

            ItemStack output = buffer.readItemStack();
            Enchantment enchant = buffer.readRegistryIdUnsafe(ForgeRegistries.ENCHANTMENTS);
            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, null, enchant);
        }

        @Override
        public void write(PacketBuffer buffer, EnchantingPedestralRecipe recipe) {
            buffer.writeInt(recipe.getIngredients().size());
            for (Ingredient ing : recipe.getIngredients()) {
                ing.write(buffer);
            }
            buffer.writeItemStack(recipe.getRecipeOutput(), false);
            buffer.writeRegistryIdUnsafe(ForgeRegistries.ENCHANTMENTS, recipe.getEnchant());
        }
    }
}

 

Edited by PadFoot2008
Link to comment
Share on other sites
PadFoot2008 Tree Puncher

PadFoot2008

Posted
  • Author
Posted

But this is a syntax error? In read method output's coming as red. 

public class EnchantingPedestralRecipe implements IEnchantingPedestralRecipe {
    public enum Weather {
        CLEAR,
        RAIN,
        THUNDERING;

        public static Weather getWeatherByString(String s) {
            return Objects.equals(s, "thundering") ? THUNDERING : Objects.equals(s, "rain") ? RAIN : CLEAR;
        }
    }

    private final ResourceLocation id;
    private final ItemStack output;
    private final NonNullList<Ingredient> recipeItems;
    private final Weather weather;
    private final Enchantment enchant;

    public EnchantingPedestralRecipe(ResourceLocation id, ItemStack output,
                                    NonNullList<Ingredient> recipeItems, Weather weather, Enchantment enchant) {
        this.id = id;
        this.output = output;
        this.recipeItems = recipeItems;
        this.weather = weather;
        this.enchant = enchant;
    }

    @Override
    public boolean matches(IInventory inv, World worldIn) {
            if (recipeItems.get(1).test(inv.getStackInSlot(1))) {
                return recipeItems.get(1).test(inv.getStackInSlot(1));
        }
        return false;
    }

    @Override
    public NonNullList<Ingredient> getIngredients() {
        return recipeItems;
    }

    @Override
    public ItemStack getCraftingResult(IInventory inv) {
        ItemStack output = inv.getStackInSlot(0);
        int i = EnchantmentHelper.getEnchantmentLevel(enchant, output);
        int j = enchant.getMaxLevel();
        int k = i++;
        if (output.isEnchantable() == true) {
            if (i<j) {
                    output.addEnchantment(enchant, k);
            }
        }
        return output;
    }

    @Override
    public ItemStack getRecipeOutput() {
        return output.copy();
    }

    public Enchantment getEnchant() {
        return enchant;
    }

    public Weather getWeather() {
        return this.weather;
    }

    public ItemStack getIcon() {
        return new ItemStack(ModBlocks.ENCHANTING_PEDESTRAL.get());
    }

    @Override
    public ResourceLocation getId() {
        return id;
    }

    @Override
    public IRecipeSerializer<?> getSerializer() {
        return ModRecipeTypes.ENCHANTING_SERIALIZER.get();
    }

    public static class EnchantingRecipeType implements IRecipeType<EnchantingPedestralRecipe> {
        @Override
        public String toString() {
            return EnchantingPedestralRecipe.TYPE_ID.toString();
        }
    }

    public static class Serializer extends ForgeRegistryEntry<IRecipeSerializer<?>>
            implements IRecipeSerializer<EnchantingPedestralRecipe> {


        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, JsonObject json) {
            String enchantraw = JSONUtils.getString(json, "enchantment");
            Enchantment enchant = ForgeRegistries.ENCHANTMENTS.getValue(new ResourceLocation(enchantraw));



            String weather = JSONUtils.getString(json, "weather");

            JsonArray ingredients = JSONUtils.getJsonArray(json, "ingredients");
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.deserialize(ingredients.get(i)));
            }

            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, Weather.getWeatherByString(weather), enchant);
        }

        @Nullable
        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, PacketBuffer buffer) {
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.read(buffer));
            }

            ItemStack output = buffer.readItemStack();
            Enchantment enchant = buffer.readRegistryIdUnsafe(ForgeRegistries.ENCHANTMENTS);
            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, null, enchant);
        }

        @Override
        public void write(PacketBuffer buffer, EnchantingPedestralRecipe recipe) {
            buffer.writeInt(recipe.getIngredients().size());
            for (Ingredient ing : recipe.getIngredients()) {
                ing.write(buffer);
            }
            buffer.writeItemStack(recipe.getRecipeOutput(), false);
            buffer.writeRegistryIdUnsafe(ForgeRegistries.ENCHANTMENTS, recipe.getEnchant());
        }
    }
}

 

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Eg, ItemStack.EMPTY ...

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
PadFoot2008 Tree Puncher

PadFoot2008

Posted
  • Author
Posted

Current code: 

public class EnchantingPedestralRecipe implements IEnchantingPedestralRecipe {
    public enum Weather {
        CLEAR,
        RAIN,
        THUNDERING;

        public static Weather getWeatherByString(String s) {
            return Objects.equals(s, "thundering") ? THUNDERING : Objects.equals(s, "rain") ? RAIN : CLEAR;
        }
    }

    private final ResourceLocation id;
    private final NonNullList<Ingredient> recipeItems;
    private final Weather weather;
    private final Enchantment enchant;

    public EnchantingPedestralRecipe(ResourceLocation id,
                                    NonNullList<Ingredient> recipeItems, Weather weather, Enchantment enchant) {
        this.id = id;
        this.recipeItems = recipeItems;
        this.weather = weather;
        this.enchant = enchant;
    }

    @Override
    public boolean matches(IInventory inv, World worldIn) {
            if (recipeItems.get(1).test(inv.getStackInSlot(1))) {
                return recipeItems.get(1).test(inv.getStackInSlot(1));
        }
        return false;
    }

    @Override
    public NonNullList<Ingredient> getIngredients() {
        return recipeItems;
    }

    @Override
    public ItemStack getCraftingResult(IInventory inv) {
        ItemStack output = inv.getStackInSlot(0);
        int i = EnchantmentHelper.getEnchantmentLevel(enchant, output);
        int j = enchant.getMaxLevel();
        int k = i++;
        if (output.isEnchantable() == true) {
            if (i<j) {
                    output.addEnchantment(enchant, k);
            }
        }
        return output;
    }

    @Override
    public ItemStack getRecipeOutput() {
        ItemStack output = ItemStack.EMPTY;
        return output.copy();
    }

    public Enchantment getEnchant() {
        return enchant;
    }

    public Weather getWeather() {
        return this.weather;
    }

    public ItemStack getIcon() {
        return new ItemStack(ModBlocks.ENCHANTING_PEDESTRAL.get());
    }

    @Override
    public ResourceLocation getId() {
        return id;
    }

    @Override
    public IRecipeSerializer<?> getSerializer() {
        return ModRecipeTypes.ENCHANTING_SERIALIZER.get();
    }

    public static class EnchantingRecipeType implements IRecipeType<EnchantingPedestralRecipe> {
        @Override
        public String toString() {
            return EnchantingPedestralRecipe.TYPE_ID.toString();
        }
    }

    public static class Serializer extends ForgeRegistryEntry<IRecipeSerializer<?>>
            implements IRecipeSerializer<EnchantingPedestralRecipe> {


        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, JsonObject json) {
            String enchantraw = JSONUtils.getString(json, "enchantment");
            Enchantment enchant = ForgeRegistries.ENCHANTMENTS.getValue(new ResourceLocation(enchantraw));



            String weather = JSONUtils.getString(json, "weather");

            JsonArray ingredients = JSONUtils.getJsonArray(json, "ingredients");
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.deserialize(ingredients.get(i)));
            }

            return new EnchantingPedestralRecipe(recipeId,
                    inputs, Weather.getWeatherByString(weather), enchant);
        }

        @Nullable
        @Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, PacketBuffer buffer) {
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.read(buffer));
            }

            Enchantment enchant = buffer.readRegistryIdUnsafe(ForgeRegistries.ENCHANTMENTS);
            return new EnchantingPedestralRecipe(recipeId,
                    inputs, null, enchant);
        }

        @Override
        public void write(PacketBuffer buffer, EnchantingPedestralRecipe recipe) {
            buffer.writeInt(recipe.getIngredients().size());
            for (Ingredient ing : recipe.getIngredients()) {
                ing.write(buffer);
            }
            buffer.writeRegistryIdUnsafe(ForgeRegistries.ENCHANTMENTS, recipe.getEnchant());
        }
    }
}

Please help.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing


  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Dwolfwood
      Forge Server crashing

      By Dwolfwood · Posted

      I set the value you mentioned to me and after a few hours of testing the server has worked correctly. Thank you very much for your help
    • Slacker201
      Problem with forge : > Failed to apply plugin 'net.minecraftforge.gradle.forge'.

      By Slacker201 · Posted

      6:26:58 PM: Executing 'wrapper'... Download http://files.minecraftforge.net/maven/net/minecraftforge/gradle/ForgeGradle/2.1-SNAPSHOT/maven-metadata.xml, took 3 s 928 ms Download http://files.minecraftforge.net/maven/net/minecraftforge/fernflower/2.0-SNAPSHOT/maven-metadata.xml, took 2 s 332 ms FAILURE: Build failed with an exception. * Where: Build file 'C:\Users\Slacker201\Desktop\MinecraftMacro\build.gradle' line: 16 * What went wrong: A problem occurred evaluating root project 'MinecraftMacro'. > Failed to apply plugin 'net.minecraftforge.gradle.forge'.    > Configuration with name 'compile' not found. * Try: > Run with --stacktrace option to get the stack trace. > Run with --info or --debug option to get more log output. > Run with --scan to get full insights. > Get more help at https://help.gradle.org. BUILD FAILED in 56s Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0. You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins. For more on this, please refer to https://docs.gradle.org/8.8/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation. 6:27:54 PM: Execution finished 'wrapper'.
    • floresepifanio170
      RECOVER LOST BTC, USDT AND OTHER CRYPTO ASSET WITH THE HELP OF RAPID DIGITAL RECOVERY

      By floresepifanio170 · Posted

      Against the Odds: How I Recovered $86,000 from a Binary Options Fraud unmasking the scam. I never thought I’d see my money again. After months of frustration, I had lost hope of recovering the $86,000 I invested in a binary options trading platform. But today, I want to share my journey and prove that recovery is possible. Living in Colombia, I first encountered the platform through a flashy online advertisement. It promised quick returns through binary options trading, a concept I didn’t fully grasp but found alluring. Initially, I invested $2,000, encouraged by what appeared to be substantial gains. As my balance grew, I became more confident and ended up investing an additional $84,000. For a while, everything seemed to be going well. The platform displayed impressive profits, claiming I had made $175,000. However, when I tried to withdraw a significant portion of my earnings, I faced an onslaught of obstacles. My requests were met with delays and vague excuses. Each time I was prompted to pay withdrawal fees, I complied, only to find more fees waiting for me: taxes, processing charges, and even unexpected compliance fees. I realized too late that I was trapped in a scam, having lost another $26,000 in fees alone. The experience was not only financially devastating but also emotionally draining. I felt embarrassed for trusting a platform I barely understood. Yet, despite the discouragement, I was determined to fight for my money. After extensive research, I discovered Rapid Digital Recovery and their promising testimonials. Skeptical but desperate, I decided to reach out, WHAT SAPP: + 1 41 4 80 7 14 85.... To my surprise, Rapid Digital Recovery managed to recover 100% of my investment. The relief I felt was indescribable. Although I still grapple with regret over my initial decisions, I’m incredibly thankful for the support I received. They restored not just my funds but also my confidence in the recovery process. If you’re into scam, don’t lose hope. Reach out to Rapid Digital Recovery You don’t have to go through this alone, and there is a way to reclaim what you’ve lost. Web site: https: // ra pi ddigit alrecove ry .o rg
    • TileEntity
      MC crashing without knowing what mods

      By TileEntity · Posted

      Replace it with other/older builds: https://www.curseforge.com/minecraft/mc-mods/farmers-delight/files/all?page=1&pageSize=20&version=1.20.1
    • bfefhe
      the forge file wont show the logo and says its only openable with notepad, opera gx, wordpad, and media player

      By bfefhe · Posted

      idk how to show a screenshot with a url, but i have the forge file on desktop, and its just a paper folded in the corner and not the forge logo and i cant open it and go to the installer

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept