Jump to content

Custom Enchantment adding effect when attacking an Entity


OwnAgePau

Recommended Posts

Hi there,

 

I have been looking into the adding of enchantments and i have gotten my own enchantment "Frost Enchantment" to show up as an enchantment book, to work in an anvil and i have gotten it to be able to get the enchantment from an enchantment table.

 

Now i was looking for the place where minecraft handles the effects of the enchantments. I looked at swords, EntityPlayer, Enchantments and more. But i haven't found much of something that looks like an enchantment effect. All i found was the stuff in EntityPlayer that refers to the EnchantmentHelper. I tired looking at tutorials, although i did find some. Most of them were Modloader tutorials and they were changing base files (which i am not going to do).

 

Where would i add the enchantment effect? would i do that in sword onEntityHit() or whatever that method is called? (i don't have the source in front of my right now)

 

Any help is appreciated, thanks.

Link to comment
Share on other sites

You don't call an event, unless you want someone else to catch it.

You register to the event, to receive the calls.

Oh well, i am sorry that my Englisch isn't my first language and that i happened to have sayd something that wasn't completely what i meant. I meant it more in a way like where would i place the code that would make the effect occur, like i want my enchantment to do an effect whenever it hits an entity, but i couldn't figure out where i would do that.

 

I have seen that page indeed, but i still haven't quite gotten straightened out where i would place the effect of my sword. As far as i understand on this thread the guy describes to make a certain class which will use the LivingAttackEvent. So when would this method that is being used in this class be triggered?(called entityAttacked in the example). I understand that i would have to make such a class to hook my "effects" to an event, but i don't yet understand the mechanics behind it. Maybe i am just overthinking this right now (it is quite late for me right now).

Link to comment
Share on other sites

You can search for

MinecraftForge.EventBus.post(new LivingAttackEvent(args))

or similar.

this is where the event is triggered.

 

If you use PreInit, Init methods and such in your main mod class, you already know how to make a method that can receive an event. The only difference is the event argument, and the @ForgeSubscribe annotation instead of @EventHandler.

Just place this method in a class (you can put in your main class at first) then register with

MinecraftForge.EventBus.register(class);

(you register the entire class, so you can put multiple events in one)

 

You should already have methods ready to read and write an ItemStack NBTTag to get/set your enchantment by the way.

Link to comment
Share on other sites

You should already have methods ready to read and write an ItemStack NBTTag to get/set your enchantment by the way.

Uhm i am not sure if it has anything to do with it, but uhm in EnchantmentHelper there are methods that read and write NBTTag. And my enchantment can already be obtained with crafting books and using an enchantment table. I also discovered that whenever i attack a mob the "magic damage effect" is being shown.

 

Also i haven't done much with forge events and such (still) and i do understand what an event is and all, i just don't yet understand all about the forge related registrations around it. So just to see if i understood you correctly: I will make this method in a custom ForgeHookEvent class (or whatver i will call it) that will take care of the way i handle the effect that will occur whenever i hit a mob. So whenever

MinecraftForge.EventBus.post(new LivingAttackEvent(args))

something that code (or similar code) is being run it will execute the entityAttacked(args) method in my ForgeHookEvent.class. Am i right?

 

And yes i do use Init and PreInit :)

Link to comment
Share on other sites

Well with the magic effet i mean the particles that come off a mob whenever you hit them with an enchantment. But as far as i'm concerned it doesn't give any extra damage. I also wanted to have my frost enchantment do give the entity a slow debuff. (i will post my enchantment code in here as an edit after i have started up my pc)

 

Edit:

package Mod_Ores.Enchantments;

import Mod_Ores.EnumCreatureHelper;
import Mod_Ores.EnumSoulCreatureAttribute;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnumEnchantmentType;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.EnumCreatureAttribute;

public class EnchantmentFrost extends Enchantment
{
/**EnchantmentFrost constructor
 * 
 * @param par1id the effectId
 * @param par2weight the weight (rarity something)
 * @param par3enumenchantmenttype the enchantment type
 */
public EnchantmentFrost(int par1id, int par2weight, EnumEnchantmentType par3enumenchantmenttype)
{
	super(par1id, par2weight, par3enumenchantmenttype);
	this.setName("Frost");
}

public String getName()
{
	return name;
}

    /**
     * Calculates de (magic) damage done by the enchantment on a living entity based on level and entity passed.
     */
    public float calcModifierLiving(int par1, EntityLivingBase par2EntityLivingBase)
    {
        return EnumCreatureHelper.getSoulCreatureAttribute() == EnumSoulCreatureAttribute.FROST ? (float)par1 * 2.5F : (float)par1 * 0.0F;
    }
    // I have made a custom Enum in order to give my mobs a certain attribute and if that attribute is a FROST more damage will be done, that was 1 of the 2 ideas. But i am not sure whether its working completely yet as i haven't tested it yet.
    
    /**
     * Returns the minimal value of enchantability needed on the enchantment level passed.
     */
@Override
    public int getMinEnchantability(int par1)
    {
        return 10 + 20 * (par1 - 1);
    }

    /**
     * Returns the maximum value of enchantability nedded on the enchantment level passed.
     */
@Override
    public int getMaxEnchantability(int par1)
    {
        return super.getMinEnchantability(par1) + 50;
    }

    /**
     * Returns the maximum level that the enchantment can have.
     */
@Override
    public int getMaxLevel()
    {
        return 4;
    }
}

Link to comment
Share on other sites

Okay i have done some testing and registered the custom ForgeHookEvent.class. Whenever i now attack an entity it doesn't do anything, i wonder do i have to super.***method do anything in order to continue the usual stuff and just start coding an if() construction in order to find out whether or not the player is attacking with an enchanted sword with Frost on it. Also before i added the event class i tested out my little bit of code to see if the calcModifier stuff was working and it is. So on certain mobs my weapon now does more damage whenver it has my enchantment so i guess i got 1 part working.

 

So what was that you were saying about NBTTag, i have not worked with it as in, created my own function that uses it. Although i have seen some of those methods and have a general idea of how they work.

Link to comment
Share on other sites

public float calcModifierLiving(int par1, EntityLivingBase par2EntityLivingBase)
    {
        return EnumCreatureHelper.getSoulCreatureAttribute() == EnumSoulCreatureAttribute.FROST ? (float)par1 * 2.5F : (float)par1 * 0.0F;
    }

How does getter work without any argument ?

Do you setSoulCreatureAttribute() somewhere ?

Whenever i now attack an entity it doesn't do anything

Be sure not to cancel the event.You don't need a super.x().

start coding an if() construction in order to find out whether or not the player is attacking with an enchanted sword with Frost on it.

This is it. The enchantment you will check by reading the NBTTag from the ItemStack of player.getHeldItem().

Link to comment
Share on other sites

public float calcModifierLiving(int par1, EntityLivingBase par2EntityLivingBase)
    {
        return EnumCreatureHelper.getSoulCreatureAttribute() == EnumSoulCreatureAttribute.FROST ? (float)par1 * 2.5F : (float)par1 * 0.0F;
    }

How does getter work without any argument ?

Do you setSoulCreatureAttribute() somewhere ?

Whenever i now attack an entity it doesn't do anything

Be sure not to cancel the event.You don't need a super.x().

start coding an if() construction in order to find out whether or not the player is attacking with an enchanted sword with Frost on it.

This is it. The enchantment you will check by reading the NBTTag from the ItemStack of player.getHeldItem().

Jeah i changed my custom getCreatureAttribute it now works the way i wanted it to. All that now matters is what to do in the attackEntityEvent, you say that i have to read from NBTTag. Are there some examples that i could start looking at to get an idea of how to do this properly? As i know that enchantment stuff is already stored in NBTTags so i wouldn't have to do that.

 

And btw how can it be that its being canceld then? all i've got in that event is the if(event.isCancable) statement. Would i get rid of that?

Link to comment
Share on other sites

Don't do setCanceled(true) :)

 

ItemStack item =  player.getHeldItem();
if(item!=null && item.getItem() instanceof 'CustomSwordClass' && item.hasTagCompound())
{
NBTTagList enchTag = item.getEnchantmentTagList();//use this if you stored your enchantment at "ench" tag in the item
//then do things
}

Link to comment
Share on other sites

Oh is that what the event.source is, because i have got it set as

DamageSource attackSource = event.source;

And i thought it was the ammount of damage done to the entity, it seems i was mistaken. Well thanks again :)

Link to comment
Share on other sites

specific answer: no idea

general answer: you could always look at how vanilla code does it :)

 

highlight "enchantmentTagList", right-click and click "show call hierarchy". this will show you everywhere in code where this method is called, you can just follor til you find what vanilla code does with it :)

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.