Search the Forums BEFORE making a new post.

Problem with VoxelShapes

Posted July 7, 20223 yr

I've made a block with custom shapes and hitbox using VoxelShapes and when texting it in-game two problems became apparent.

First of the lightning didn't work correctly as shown below:

Light glitch

And some wierd problem with the hitbox. The hitbox works fine except when you try to destroy or interact with the upper half of the block:

Hitbox problem

Below is the blocks class:

package com.hivemind.superheated.block;

import net.minecraft.core.BlockPos;
import net.minecraft.core.Direction;
import net.minecraft.world.item.context.BlockPlaceContext;
import net.minecraft.world.level.BlockGetter;
import net.minecraft.world.level.LevelAccessor;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.HorizontalDirectionalBlock;
import net.minecraft.world.level.block.Mirror;
import net.minecraft.world.level.block.Rotation;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.level.block.state.StateDefinition.Builder;
import net.minecraft.world.level.block.state.properties.DirectionProperty;
import net.minecraft.world.phys.shapes.BooleanOp;
import net.minecraft.world.phys.shapes.CollisionContext;
import net.minecraft.world.phys.shapes.Shapes;
import net.minecraft.world.phys.shapes.VoxelShape;

public class Forge extends Block{
	
	public static final DirectionProperty FACING = HorizontalDirectionalBlock.FACING;
	
	@Override
	public VoxelShape getShape(
			BlockState state,
			BlockGetter getter,
			BlockPos pos,
			CollisionContext context) {
		switch (state.getValue(FACING)) {
		case EAST:
			VoxelShape EAST = Shapes.empty();
			EAST = Shapes.join(EAST, Shapes.box(0, 0, 0, 1, 0.0625, 1), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0.25, 0.3125, 0.75, 0.875, 0.875, 0.9375), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0.25, 0.3125, 0.0625, 0.875, 0.875, 0.25), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0.25, 0.875, 0.0625, 0.875, 1, 0.9375), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0.25, 0.0625, 0.0625, 0.875, 0.3125, 0.9375), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0.0625, 0.0625, 0.0625, 0.25, 1, 0.9375), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0, 1, 0, 0.9375, 1.125, 1), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0.0625, 1.125, 0.0625, 0.875, 1.375, 0.9375), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0.0625, 1.375, 0.1875, 0.75, 1.625, 0.8125), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0.0625, 1.625, 0.3125, 0.625, 1.875, 0.6875), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0, 0.0625, 0.375, 0.0625, 1, 0.625), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0, 1.125, 0.375, 0.0625, 1.875, 0.625), BooleanOp.OR);
			EAST = Shapes.join(EAST, Shapes.box(0, 1.875, 0.375, 0.5, 2, 0.625), BooleanOp.OR);
			return EAST;
		case SOUTH:
			VoxelShape SOUTH =Shapes.empty();
			SOUTH =Shapes.join(SOUTH,Shapes.box(0, 0, 0, 1, 0.0625, 1), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.0625, 0.3125, 0.25, 0.25, 0.875, 0.875), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.75, 0.3125, 0.25, 0.9375, 0.875, 0.875), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.0625, 0.875, 0.25, 0.9375, 1, 0.875), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.0625, 0.0625, 0.25, 0.9375, 0.3125, 0.875), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.0625, 0.0625, 0.0625, 0.9375, 1, 0.25), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0, 1, 0, 1, 1.125, 0.9375), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.0625, 1.125, 0.0625, 0.9375, 1.375, 0.875), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.1875, 1.375, 0.0625, 0.8125, 1.625, 0.75), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.3125, 1.625, 0.0625, 0.6875, 1.875, 0.625), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.375, 0.0625, 0, 0.625, 1, 0.0625), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.375, 1.125, 0, 0.625, 1.875, 0.0625), BooleanOp.OR);
			SOUTH =Shapes.join(SOUTH,Shapes.box(0.375, 1.875, 0, 0.625, 2, 0.5), BooleanOp.OR);
			return SOUTH;
		case WEST:
			VoxelShape WEST = Shapes.empty();
			WEST = Shapes.join(WEST, Shapes.box(0, 0, 0, 1, 0.0625, 1), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.125, 0.3125, 0.0625, 0.75, 0.875, 0.25), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.125, 0.3125, 0.75, 0.75, 0.875, 0.9375), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.125, 0.875, 0.0625, 0.75, 1, 0.9375), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.125, 0.0625, 0.0625, 0.75, 0.3125, 0.9375), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.75, 0.0625, 0.0625, 0.9375, 1, 0.9375), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.0625, 1, 0, 1, 1.125, 1), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.125, 1.125, 0.0625, 0.9375, 1.375, 0.9375), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.25, 1.375, 0.1875, 0.9375, 1.625, 0.8125), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.375, 1.625, 0.3125, 0.9375, 1.875, 0.6875), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.9375, 0.0625, 0.375, 1, 1, 0.625), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.9375, 1.125, 0.375, 1, 1.875, 0.625), BooleanOp.OR);
			WEST = Shapes.join(WEST, Shapes.box(0.5, 1.875, 0.375, 1, 2, 0.625), BooleanOp.OR);
			return WEST;
		default:
			VoxelShape NORTH =Shapes.empty();
			NORTH =Shapes.join(NORTH,Shapes.box(0, 0, 0, 1, 0.0625, 1), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.75, 0.3125, 0.125, 0.9375, 0.875, 0.75), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.0625, 0.3125, 0.125, 0.25, 0.875, 0.75), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.0625, 0.875, 0.125, 0.9375, 1, 0.75), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.0625, 0.0625, 0.125, 0.9375, 0.3125, 0.75), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.0625, 0.0625, 0.75, 0.9375, 1, 0.9375), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0, 1, 0.0625, 1, 1.125, 1), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.0625, 1.125, 0.125, 0.9375, 1.375, 0.9375), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.1875, 1.375, 0.25, 0.8125, 1.625, 0.9375), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.3125, 1.625, 0.375, 0.6875, 1.875, 0.9375), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.375, 0.0625, 0.9375, 0.625, 1, 1), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.375, 1.125, 0.9375, 0.625, 1.875, 1), BooleanOp.OR);
			NORTH =Shapes.join(NORTH,Shapes.box(0.375, 1.875, 0.5, 0.625, 2, 1), BooleanOp.OR);
			return NORTH;
		}
	}
	
	public Forge(
			Properties properties) {
		super(properties);
		
		this.registerDefaultState(this.defaultBlockState().setValue(FACING, Direction.NORTH));
	}
	
	
	@Override
	protected void createBlockStateDefinition(
			Builder<Block, BlockState> builder) {
		builder.add(FACING);
		super.createBlockStateDefinition(
				builder);
	}
	
	@Override
	public BlockState getStateForPlacement(BlockPlaceContext context) {
		return this.defaultBlockState().setValue(FACING, context.getHorizontalDirection().getOpposite());
	}
	
	@SuppressWarnings("deprecation")
	@Override
	public BlockState mirror(BlockState state, Mirror mirror) {
		return state.rotate(mirror.getRotation(state.getValue(FACING)));
	}
	
	@Override
	public BlockState rotate(BlockState state, LevelAccessor world,
			BlockPos pos, Rotation direction) {
		return state.setValue(FACING, direction.rotate(state.getValue(FACING)));
	}
}

If you need anything else to find the problem just ask.

Quote

July 8, 20223 yr

Well.

Yes.

Blocks aren't meant to take up visual space outside their 1x1x1 cube. Two vanilla blocks have this issue as well.

https://bugs.mojang.com/browse/MC-158827?filter=-2

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

July 8, 20223 yr

why did you not use two Blocks, this would fix the light issue?

15 hours ago, Hive Mind said:

And some wierd problem with the hitbox. The hitbox works fine except when you try to destroy or interact with the upper half of the block

as far as i know this is not a issue/bug
But I'm not sure what exactly is the reason that you can't sneak along the edge of the block,
I suspect that the hitbox area is not large enough for the player to stand on it

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/113442-problem-with-voxelshapes/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Help with file conversion

This is really helpful

By Brialeblanc · 5 hours ago5 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 11 hours ago11 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 18 hours ago18 hr
New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 22 hours ago22 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · Yesterday at 03:38 AM1 day

Sign In

Problem with VoxelShapes

Featured Replies

Join the conversation

Posts

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)