Jump to content

Recommended Posts

Posted

So I've been having this issue with my Furnace. When I try to open it, it says "A gui can not be opened because it is not a NetworkMod." or something close to that. (:

 

GuiHandler

 

  Reveal hidden contents

 

 

mod_Nether

 

  Reveal hidden contents

 

Posted

also your code is huge, use paste.minecraftforge.net

reading that black on grey will take FOREVER :P

 

Reading it on a paste site however is WAY easier ;)

  Quote

If you guys dont get it.. then well ya.. try harder...

Posted
  On 8/13/2013 at 11:13 PM, hydroflame said:

im not suuuure but

serversiderequired = true ???

 

This will at least make any users of the mod D/C when attempting to connect to a server without this mod installed.

  Quote

If you guys dont get it.. then well ya.. try harder...

Posted

not that it's likely to be anything to do with your problem Water' , but taking all the registrations for everything into separate classes would make the code a lot more easy to read/debug also...

 

e.g. pulling all the block registrations and fields into their own class from those preinit/inits, and calling a static method on a class to initialise them all... i do this for blocks, items, entities... each with their own "init this lot" class... that way my FMLInit/PreInitializationEvent methods just say the equivalent of: "BlockHelper.init()" in the preinit  and "BlockHelper.register()" in my init [ plus similar for items and entities n stuff ]

 

as a rule, i consider any method longer than about a standard screen page to need refactoring... [ unless there's a really good reason i can't break the method down, or if it makes no sense to do so ]

 

doing it this way will make your life a helluva lot easier if you ever need to change anything, since it'll be all nice an encapsulated in its own class... plus it makes abstracting the main mod from the blocks/items etc a lot simpler...

 

... and it'll save the eyes of those trying to read the code from bleeding as much ;)

 

 

back to your issue... i don't think you've pasted the code where the error happens, surely that's on an openGui line, no?

 

 

[ as an aside also, is there a specific reason why you have two separate blocks for the furnace when it's lit or not lit? - rather than just use metadata to switch the texture/mode? sorry - i'm not trying to pick holes in the code, i'm just curious :) ]

 

Posted

Should be better this way:

@Mod(modid = mod_id, name = "The Nether Overhaul", version="ALPHA 1.0")
@NetworkMod(clientSideRequired = true, serverSideRequired = false)

public class mod_Nether {
   
   public static final String mod_id = "teamoverhaul_netheroverhaul";
   
   @Instance(mod_id)
   public static mod_Nether instance;

 

Posted
  On 8/14/2013 at 3:57 AM, ingiethingie said:

not that it's likely to be anything to do with your problem Water' , but taking all the registrations for everything into separate classes would make the code a lot more easy to read/debug also...

 

e.g. pulling all the block registrations and fields into their own class from those preinit/inits, and calling a static method on a class to initialise them all... i do this for blocks, items, entities... each with their own "init this lot" class... that way my FMLInit/PreInitializationEvent methods just say the equivalent of: "BlockHelper.init()" in the preinit  and "BlockHelper.register()" in my init [ plus similar for items and entities n stuff ]

 

as a rule, i consider any method longer than about a standard screen page to need refactoring... [ unless there's a really good reason i can't break the method down, or if it makes no sense to do so ]

 

doing it this way will make your life a helluva lot easier if you ever need to change anything, since it'll be all nice an encapsulated in its own class... plus it makes abstracting the main mod from the blocks/items etc a lot simpler...

 

... and it'll save the eyes of those trying to read the code from bleeding as much ;)

 

 

back to your issue... i don't think you've pasted the code where the error happens, surely that's on an openGui line, no?

 

 

[ as an aside also, is there a specific reason why you have two separate blocks for the furnace when it's lit or not lit? - rather than just use metadata to switch the texture/mode? sorry - i'm not trying to pick holes in the code, i'm just curious :) ]

 

 

Haha That's a good point! (: I'm actually working with a team and the other head modder did that... I like your idea better though! (: haha The reason why I did the furnaces that way is because I learned them that way and haven't gotten to meta-data yet in my coding! (: I'll be sure to check it out though! I just took from the MC code and changed what I needed and stuff.

 

 

  Reveal hidden contents

 

 

That's from my Nether Furnace class. I believe that's what you're talking about. (:

 

Also, I just did what you mentioned and it took out a lot of space! (: Thanks

Posted
  On 8/15/2013 at 2:12 AM, ingiethingie said:

  Quote

bump

 

did you do what gotolink suggested?  i.e. fix the instance name?

 

you were using @Instance("The Nether Overhaul")  rather than the modid...

 

That would do it... :P

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Posted
  On 8/15/2013 at 2:12 AM, ingiethingie said:

  Quote

bump

 

did you do what gotolink suggested?  i.e. fix the instance name?

 

you were using @Instance("The Nether Overhaul")  rather than the modid...

 

I totally missed that post! (: I thought something looked fishy with that! Thank you all so much! (:

 

EDIT: I had to change the instance name to just modid without the "". (: I'm not sure if that will be a problem in the future... But it's fixed! Woo!

Posted

Tip: read this www.minecraftforge.net/wiki/Basic_Modding

;)

 

Tip2: Keep your mod ID in some separate class file, so you can do Reference.modID whenever you need the modID, if it ever changes you only need to change one line ;)

 

tip3: The modid should NEVER NEVER include uppercase letters!

      Keep it all lowerCase or else you will get problems at a later stage ;)

  Quote

If you guys dont get it.. then well ya.. try harder...

Posted
  Quote
so you can do Reference.modID whenever you need the modID, if it ever changes you only need to change one line

 

well .. i mean you should just keep it static, not necessarelly in a separate file

 

public class Reference{
    public static String modid = "theforgerevolution";
}

 

i mean this class is kindof useless

 

 

 

@op: keep in mind that your mod id and your mod NAME are 2 different things, players rarelly get to see the modid

 

ex:

my mod name: "The Forge Revolution"

my mod id: "forgerev" (i think, or something similar)

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

  Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

  Your link has been automatically embedded.   Display as a link instead

  Your previous content has been restored.   Clear editor

  You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi! I'm trying to add my custom models/textures renderer like this: public class PonyPlayerWrapperRenderer extends EntityRenderer<Player> { // wrapper class under my LivingEntityRenderer class implementation private final PonyPlayerRenderer innerRenderer; private final PonyPlayerRenderer innerSlimRenderer; public PonyPlayerWrapperRenderer(final EntityRendererProvider.Context context) { super(context); System.out.println("creating new PonyPlayerWrapperRenderer"); this.innerRenderer = new PonyPlayerRenderer(context, false); this.innerSlimRenderer = new PonyPlayerRenderer(context, true); } @Override public void render(final Player entity, final float yaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource bufferSource, final int packedLight) { System.out.println("PonyPlayerWrapperRenderer render: " + entity.toString()); if (entity instanceof AbstractClientPlayer clientPlayer) { if (clientPlayer.getModelName().contains("slim")) { innerSlimRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } else { innerRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } } } @Override public ResourceLocation getTextureLocation(final Player player) { System.out.println("PonyPlayerWrapperRenderer getTextureLocation"); if (player instanceof AbstractClientPlayer clientPlayer) { return clientPlayer.getSkinTextureLocation(); } System.out.println("player instanceof AbstractClientPlayer is false"); return getDefaultSkin(player.getUUID()); } } public class PonyPlayerRenderer extends LivingEntityRenderer<AbstractClientPlayer, PlayerModel<AbstractClientPlayer>> { private final PlayerModel<AbstractClientPlayer> earthModel; private final PlayerModel<AbstractClientPlayer> pegasusModel; private final PlayerModel<AbstractClientPlayer> unicornModel; public PonyPlayerRenderer(final EntityRendererProvider.Context context, final boolean slim) { super( context, slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)), 0.5f ); System.out.println("creating new PonyPlayerRenderer"); this.earthModel = slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); this.pegasusModel = new PegasusModel(context.bakeLayer(PegasusModel.LAYER_LOCATION)); this.unicornModel = new UnicornModel(context.bakeLayer(UnicornModel.LAYER_LOCATION)); } @Override public void render(final AbstractClientPlayer player, final float entityYaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource buffer, final int packedLight) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); this.model = switch (race) { case PEGASUS -> pegasusModel; case UNICORN -> unicornModel; case EARTH -> earthModel; }; super.render(player, entityYaw, partialTicks, poseStack, buffer, packedLight); } @Override public ResourceLocation getTextureLocation(final AbstractClientPlayer player) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); return switch (race) { case EARTH -> fromNamespaceAndPath(MODID, "textures/entity/earth_pony.png"); case PEGASUS -> fromNamespaceAndPath(MODID, "textures/entity/pegasus.png"); case UNICORN -> fromNamespaceAndPath(MODID, "textures/entity/unicorn.png"); }; } } @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { // mod bus render registration config @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onRegisterRenderers(final EntityRenderersEvent.RegisterRenderers event) { event.registerEntityRenderer(EntityType.PLAYER, PonyPlayerWrapperRenderer::new); System.out.println("onRegisterRenderers end"); } } Method onRegisterRenderers() is called and I can see it being logged. But when I enter the world, my PonyWrapperRenderer render() method doesn't ever seem to be called. I also tried to put my renderer to EntityRenderDispatcher's playerRenderers via reflection: @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onClientSetup(final FMLClientSetupEvent event) { event.enqueueWork(() -> { try { final EntityRenderDispatcher dispatcher = Minecraft.getInstance().getEntityRenderDispatcher(); final Field renderersField = getEntityRenderDispatcherField("playerRenderers"); final Field itemInHandRenderer = getEntityRenderDispatcherField("itemInHandRenderer"); @SuppressWarnings("unchecked") final Map<String, EntityRenderer<? extends Player>> playerRenderers = (Map<String, EntityRenderer<? extends Player>>)renderersField.get(dispatcher); final PonyPlayerWrapperRenderer renderer = new PonyPlayerWrapperRenderer( new EntityRendererProvider.Context( dispatcher, Minecraft.getInstance().getItemRenderer(), Minecraft.getInstance().getBlockRenderer(), (ItemInHandRenderer)itemInHandRenderer.get(dispatcher), Minecraft.getInstance().getResourceManager(), Minecraft.getInstance().getEntityModels(), Minecraft.getInstance().font ) ); playerRenderers.put("default", renderer); playerRenderers.put("slim", renderer); System.out.println("Player renderers replaced"); } catch (final Exception e) { throw new RuntimeException("Failed to replace player renderers", e); } }); } private static Field getEntityRenderDispatcherField(final String fieldName) throws NoSuchFieldException { final Field field = EntityRenderDispatcher.class.getDeclaredField(fieldName); field.setAccessible(true); return field; } } But I receive the error before Minecraft Client appears (RuntimeException: Failed to replace player renderers - from ClientRenderers onClientSetup() method - and its cause below): java.lang.IllegalArgumentException: No model for layer anotherlittlepony:earth_pony#main at net.minecraft.client.model.geom.EntityModelSet.bakeLayer(EntityModelSet.java:18) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.EntityRendererProvider$Context.bakeLayer(EntityRendererProvider.java:69) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerRenderer.<init>(PonyPlayerRenderer.java:32) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerWrapperRenderer.<init>(PonyPlayerWrapperRenderer.java:24) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.ClientRenderers.lambda$onClientSetup$0(ClientRenderers.java:79) ~[main/:?] {re:classloading} ... 33 more Problem appears when EntityRendererProvider context tries to bakeLayer with my model layer location: new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); // PonyPlayerRenderer.java:32 public class PonyModel extends PlayerModel<AbstractClientPlayer> { // the model class itself public static final ModelLayerLocation LAYER_LOCATION = new ModelLayerLocation( ResourceLocation.fromNamespaceAndPath(MODID, "earth_pony"), "main" ); public PonyModel(final ModelPart root) { super(root, false); } public static LayerDefinition createBodyLayer() { // some CubeListBuilder stuff for model appearance } } Textures PNGs are placed at: resources/assets/[my mod id]/textures/entity. My forge version is 1.20.1. Would appreciate any help.
    • Well, a bit more information about what you're trying to do would be helpful. e.g. why you're trying to use "INVOKE_ASSIGN" instead of "INVOKE". "INVOKE_ASSIGN" calls your code after the "target" is called and its value is stored, if applicable. "INVOKE" calls your code before the target is called. "target" expects a fully qualified name, as per the SpongePowered docs, if that name is going to be remapped (which it will be if your injecting into Minecraft itself and not another mod). For more information on fully qualified names versus canonical names, see the Java specifications. Here's an example of a working "@At" from my own code that targets the "getClosestsVulnerablePlayerToEntity" call inside a mob's logic: @At(value = "INVOKE_ASSIGN", target = "net.minecraft.world.World.getClosestVulnerablePlayerToEntity(Lnet/minecraft/entity/Entity;D)Lnet/minecraft/entity/player/EntityPlayer;") Hope this helps!
    • Ran it one more time just to check, and there's no errors this time on the log??? Log : https://mclo.gs/LnuaAiu I tried allocating more memory to the modpack, around 8000MB and it's still the same; stopping at "LOAD_REGISTRIES". Are some of the mods clashing, maybe? I have no clue what to do LOL
    • Tried removing some biome generation mods and test ran it again, but it's still the same; still not responding as soon as it gets to "LOAD_REGISTRIES". This time with more errors though. Log : https://mclo.gs/uygZzD8 Is there too little memory allocated to the modpack maybe? Can someone help please.    (T.T)馃挃
    • This is sad. Over 3300 people have checked the thread and no one is able to help or give any ideas :(.
  • Topics

  • Create New...

Important Information

By using this site, you agree to our Terms of Use.