[1.18.2] Force clientsided Chunk Update

[SlimingHD]

Hello again,

it is me, SlimingHD, and I am once again asking for your support! I am currently successfully changing biomes in a chunk. However I need a way to update these chunks so that people won't have to rejoin their world to see the effect (Or worse, the chunks stop rendering all together). I have now tried all different kinds of Packets (mainly ClientboundLevelChunkWithLightPacket) but none seem to work. Am I doing something very simple very wrong or is there an obvious solution I am once again missing?

Thank you in advance!

[SlimingHD]

if(player instanceof ServerPlayer sPlayer) {
	sPlayer.connection.send(new ClientboundLevelChunkWithLightPacket(level.getChunkAt(new BlockPos(x, y, z)), level.getLightEngine(),
	new BitSet(), new BitSet(), false));
}

x, y and z are also the values I use to change the biome in the first place and when rejoining the world every chunk does have the correct biome.

[warjort]

Are you sure the player is correct? You should really be sending to all players that have that chunk loaded.

Maybe get the list using something like (I am not sure this is correct)?

        List<ServerPlayer> list = serverLevel.getChunkSource().chunkMap.getPlayers(chunkPos, false);

 

You should also be able to see if your chunk packet is actually received on the client if you listen for forge's ChunkEvent.Load

[SlimingHD]

Yes, there is a for each loop.

Edited July 11, 2022 by SlimingHD

[warjort]

Can you confirm the packet is received by the client.

If it is, I would guess there is something about the way you are updating the data that means the code that creates the packet cannot see your change?

You should try deserialising the packet after you create it to see if the data it contains is correct.

[SlimingHD]

I could. I get an IllegalArgumentException with the following message:

"No value with id -1"

But the stacktrace doesn't give me any useful information. It has to do something with an ID-map I guess

[Luis_ST]

try null instead of a new BitSet inside the ClientboundLevelChunkWithLightPacket constructor

if this does not help post debug.log

[SlimingHD]

You don't know how many combinations of variables I alredy tried, but nonetheless, here is the error:

[13:01:58] [Render thread/ERROR] [minecraft/BlockableEventLoop]: Error executing task on Client
java.lang.IllegalArgumentException: No value with id -1
	at net.minecraft.core.IdMap.byIdOrThrow(IdMap.java:16) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at net.minecraft.world.level.chunk.LinearPalette.read(LinearPalette.java:81) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at net.minecraft.world.level.chunk.PalettedContainer.read(PalettedContainer.java:150) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at net.minecraft.world.level.chunk.LevelChunkSection.read(LevelChunkSection.java:164) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at net.minecraft.world.level.chunk.LevelChunk.replaceWithPacketData(LevelChunk.java:431) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at net.minecraft.client.multiplayer.ClientChunkCache.replaceWithPacketData(ClientChunkCache.java:100) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.client.multiplayer.ClientPacketListener.updateLevelChunk(ClientPacketListener.java:605) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.multiplayer.ClientPacketListener.handleLevelChunkWithLight(ClientPacketListener.java:600) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.network.protocol.game.ClientboundLevelChunkWithLightPacket.handle(ClientboundLevelChunkWithLightPacket.java:40) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at net.minecraft.network.protocol.game.ClientboundLevelChunkWithLightPacket.handle(ClientboundLevelChunkWithLightPacket.java:11) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:22) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:143) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:22) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading}
	at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:116) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:104) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1013) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.run(Minecraft.java:663) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.main.Main.main(Main.java:205) ~[forge-1.18.2-40.1.51_mapped_official_1.18.2-recomp.jar%2376!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}
	at net.minecraftforge.fml.loading.targets.ForgeClientUserdevLaunchHandler.lambda$launchService$0(ForgeClientUserdevLaunchHandler.java:24) ~[fmlloader-1.18.2-40.1.51.jar%230!/:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.1.3.jar%2310!/:?] {}
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:149) [bootstraplauncher-1.0.0.jar:?] {}

 

Edited July 12, 2022 by SlimingHD

[SlimingHD]

I already know it has something to do with the way I set the new Biome. So if you wonder what exactly I am doing, here you go:

for(double offX = -32; offX <= 32; offX += 16) {
								for(double offZ = -32; offZ <= 32; offZ += 16) {
									double distance = Math.sqrt(offX * offX + offZ * offZ);
									if(distance <= 32) {
										for(LevelChunkSection section : level.getChunk(new BlockPos(x + offX, 0, z + offZ)).getSections()) {
											for(int i = 0; i < 4; ++i) {
												for(int j = 0; j < 4; ++j) {
													for(int k = 0; k < 4; ++k) {
														Holder<Biome> biome =
                                                        	BuiltinRegistries.BIOME.getHolderOrThrow(net.minecraft.world.level.biome.Biomes.SNOWY_TAIGA);
														if(Math.sqrt(offX * offX + 4 * i + offZ * offZ + 4 * k) < 32 
                                                            && section.getBiomes().get(i, j, k) != net.minecraft.world.level.biome.Biomes.SNOWY_TAIGA) {
																section.getBiomes().getAndSetUnchecked(i, j, k, biome);
														}
													}
												}
											}
										}
									}
								}
							}

Maybe something right here is wrong?

[warjort]

You won't be able to use the builtin registries for biomes at runtime. They are just templates.

The ones actually used are found using MinecraftServer.registryAccess().registryOrThrow()

These are copies of the builtin ones augmented with the stuff from datapacks.

[warjort]

For the same reason, you can't use 

net.minecraft.world.level.biome.Biomes.SNOWY_TAIGA

You have to look it up in the registry.

 

Sorry, its a ResourceKey not the actual biome. 🙂

Edited July 12, 2022 by warjort

[SlimingHD]

So like this?

Holder<Biome> biome = level.registryAccess().registryOrThrow(Registry.BIOME_REGISTRY).getOrCreateHolder(Biomes.SNOWY_TAIGA);

 

[SlimingHD]

It works! Thank you very much!

[warjort]

By the way, the method you are using to change the biomes won't work in 1.19

The biomes are now stored in a PalettedContainerRO (RO = read only)