1.19 Ore Generation Configuration via ForgeConfig

[Zetal911]

I've just updated my Ore Generation mod to 1.19 using BiomeModifiers and RegistryObject<ConfiguredFeature>, etc., and the ores are generated as expected.

However, it seems that if I try and use ForgeConfig to configure the parameters of the OreConfiguration being passed into the ConfiguredFeature for the RegistryObject, I get an error saying how the Config cannot be used before it is instantiated.
Is there a different lifecycle step that I should be initializing my config or my Feature registry? Is it still possible to have ForgeConfig that affects OreGeneration?

Thanks!

[Luis_ST]

Did you use a server config?

[Zetal911]

I'm using a Common config. Would a Server config avoid throwing this error?

Edit: Error still seems to be thrown regardless of type of config, whether it be Server, Client, or Common.

Edited July 28, 2022 by Zetal911

[Luis_ST]

40 minutes ago, Zetal911 said:

I'm using a Common config. Would a Server config avoid throwing this error?

In this case you should always use a server config, since the config will be synced to the client.
If you use a common config it could be that server and client values do not match.

Another aspect of the server config it is not loaded until server start.

Please show your code and post the debug.log.

[Zetal911]

https://pastebin.com/LnRcubaZ

Log ^

Constructor

    public HardModeOresMod() {
        IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
    	ModLoadingContext.get().registerConfig(ModConfig.Type.SERVER, HardModeOresConfig.COMMON_SPEC); 
        HardModeOresFeatureRegistry.register(modEventBus);
        HardModeOresRegistry.BLOCK_REGISTRY.register(modEventBus);
	HardModeOresRegistry.ITEM_REGISTRY.register(modEventBus);
    }

 

Example where I'm trying to use the config values

    public static final RegistryObject<ConfiguredFeature<?, ?>> ORE_IRON_CFG = CONFIGURED_FEATURES.register("ore_rich_iron", () -> new ConfiguredFeature<>(Feature.ORE, new OreConfiguration(ORE_IRON_TARGET_LIST.get(), HardModeOresConfig.COMMON.IronMaxVeinSize.get())));

 

Config Constructor

	

	public static final Common COMMON;
	public static final ForgeConfigSpec COMMON_SPEC;

	static //constructor
	{
		Pair<Common, ForgeConfigSpec> commonSpecPair = new ForgeConfigSpec.Builder().configure(Common::new);
		COMMON = commonSpecPair.getLeft();
		COMMON_SPEC = commonSpecPair.getRight();
	}

 

Common Constructor

public Common(ForgeConfigSpec.Builder builder)
{
  builder.push("Ores");
  this.IronMaxVeinSize = builder.worldRestart().define("Rich Iron Max Vein Size", defaultIronMaxVeinSize);
  this.GoldMaxVeinSize = builder.worldRestart().define("Rich Gold Max Vein Size", defaultGoldMaxVeinSize);
  this.DiamondMaxVeinSize = builder.worldRestart().define("Rich Diamond Max Vein Size", defaultDiamondMaxVeinSize);
  builder.pop();
}

 

 

Should be everything relevant. Note that despite the Config being named 'Common', it is using the Server config type, and is still failing in the same way.

It seems that Configs are not loaded until server/world start, but OreGeneration Registration is registered when opening the world creation screen. Does this mean that it is now impossible to use ForgeConfig to configure OreGeneration?

Edited July 28, 2022 by Zetal911

[warjort]

The normal way for a user to override world gen configuration is to use a datapack, e.g. they can provide their own definition of your configured feature.

 

Since you are registering the configured features at mod loading time, a server config is wrong here, server configs belong to the game save which doesn't exist at that point.

It is also unnecessary, because world gen is also part of the game save. The values in your configuration will only be checked during the create new world screen, after that it will use the saved values.

 

 

[warjort]

2 minutes ago, diesieben07 said:

You cannot do this. Configs are loaded after registration. Registration values cannot depend on config values.

The docs says you should load manually if you want to do this:

https://forge.gemwire.uk/wiki/Stages_of_Modloading

I don't know how to do this, Maybe ConfigTracker.INSTANCE.loadConfigs()?

Or maybe the docs are out-of-date?

[Zetal911]

Okay. I was trying to update my 1.16 mod, which supported this, to 1.19. It's a shame to lose that kind of configuration control for users, but at least it's good to know there's nothing to be done about it.

Thanks, all.

[Zetal911]

Switched over to Datapack style of creating Configured/Placed features, so it's technically all configurable again now. Hurray!

[Zetal911]

Config loading hasn't, true, but the removal of BiomeLoadingEvent (in 1.18.2 I think?) means that configs cannot be used in that later step, which was after they'd been loaded.

It doesn't really matter either way though now that I've figured out how to use Feature datapacks, it's just for the sake of discussion I guess.

[warjort]

BiomeLoadingEvent is replaced with BiomeModifiers.

https://forge.gemwire.uk/wiki/Biome_Modifiers

 

If you really wanted to implement it the way you used to do it,

you could make your own OreConfiguration/Feature implementation that gets its value from your config instead of being passed a number.

 

Edited July 30, 2022 by warjort

[Zetal911]

6 minutes ago, warjort said:

BiomeLoadingEvent is replaced with BiomeModifiers.

https://forge.gemwire.uk/wiki/Biome_Modifiers

 

If you really wanted to implement it the way you used to do it,

you could make your own OreConfiguration/Feature implementation that gets its value from your config instead of being passed a number.

 

This is exactly what I attempted to do, but as described earlier in the thread, it is now impossible because the new way of doing OreConfig/Feature is using a Registry, and Registration is called before Config is loaded.

[warjort]

No you wouldn't reference the config at registration time, you would do it at runtime inside the Feature.place()

The only reason I can see to do such a thing is if you want to change the values after the world is created.