Jump to content

My crafting manager "addRecipe" returns a Null Pointer Exception


SteampunkRBot

Recommended Posts

I am working on a crafting manager for my mod, but when I try to use my addRecipe I get a null pointer exception.

 

My IBrewingManager

package RV97.Drinks.Utils.Crafting;

import java.util.List;
import net.minecraft.item.ItemStack;
import net.minecraftforge.liquids.LiquidStack;

public abstract interface IBrewingManager
{
public abstract void addRecipe(ItemStack inputItemStack1, LiquidStack outputLiquidStack, int brewingTime);
public abstract void addRecipe(ItemStack inputItemStack1, ItemStack inputItemStack2, LiquidStack outputLiquidStack, int brewingTime);
public abstract void addRecipe(ItemStack inputItemStack1, LiquidStack inputLiquidStack, LiquidStack outputLiquidStack, int brewingTime);
public abstract void addRecipe(ItemStack inputItemStack1, ItemStack inputItemStack2, LiquidStack inputLiquidStack, LiquidStack outputLiquidStack, int brewingTime);

public abstract IBrewingRecipe getRecipe(ItemStack inputStack, ItemStack inputStack2, LiquidStack inputLiquid);

public abstract List getRecipes();
}

 

My CraftingManager

package RV97.Drinks.Utils.Crafting;

public class CraftingManager {
public static IBrewingManager brewery;
}

 

My IBrewingRecipe

package RV97.Drinks.Utils.Crafting;

import net.minecraft.item.ItemStack;
import net.minecraftforge.liquids.LiquidStack;

public abstract interface IBrewingRecipe {

public abstract int getBrewTime();

public abstract ItemStack getInput1();
  
public abstract ItemStack getInput2();
  
public abstract LiquidStack getLiquidInput();

public abstract LiquidStack getLiquidOutput();

}

 

My attempt at addRecipe

CraftingManager.brewery.addRecipe(new ItemStack(Item.sugar), new ItemStack(Item.appleRed), new LiquidStack(Block.waterStill.blockID, 1000), new LiquidStack(applejackDaniels, 1000), 300);

 

And the error I get is as follows:

 

2013-08-18 18:56:08 [sEVERE] [ForgeModLoader] Caught exception from RV97Drinks

java.lang.NullPointerException

at RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33)

at RV97.Drinks.DrinksCore.preInit(DrinksCore.java:44)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:494)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

at com.google.common.eventbus.EventBus.post(EventBus.java:267)

at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:192)

at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:172)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

at com.google.common.eventbus.EventBus.post(EventBus.java:267)

at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:103)

at cpw.mods.fml.common.Loader.loadMods(Loader.java:515)

at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:163)

at net.minecraft.client.Minecraft.startGame(Minecraft.java:411)

at net.minecraft.client.MinecraftAppletImpl.startGame(MinecraftAppletImpl.java:44)

at net.minecraft.client.Minecraft.run(Minecraft.java:733)

at java.lang.Thread.run(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] java.lang.NullPointerException

2013-08-18 18:56:08 [iNFO] [sTDERR] at RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33)

2013-08-18 18:56:08 [iNFO] [sTDERR] at RV97.Drinks.DrinksCore.preInit(DrinksCore.java:44)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:494)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.post(EventBus.java:267)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:192)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:172)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.post(EventBus.java:267)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:103)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.common.Loader.loadMods(Loader.java:515)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:163)

2013-08-18 18:56:08 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.startGame(Minecraft.java:411)

2013-08-18 18:56:08 [iNFO] [sTDERR] at net.minecraft.client.MinecraftAppletImpl.startGame(MinecraftAppletImpl.java:44)

2013-08-18 18:56:08 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.run(Minecraft.java:733)

2013-08-18 18:56:08 [iNFO] [sTDERR] at java.lang.Thread.run(Unknown Source)

 

 

RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33) Refers to where I have the addRecipe I show above, and RV97.Drinks.DrinksCore.preInit(DrinksCore.java:44) refers to when I register that piece of code (I have addRecipe under a function I run during the mod initialisation)

 

Any and all help is appreciated. :)

Link to comment
Share on other sites

Man, the abstract code is useless to us. Your implementation is what is important.

public class CraftingManager {
public static IBrewingManager brewery;
}

This looks a bit...empty, don't you think ?

 

By the way...interfaces are always abstract.

Link to comment
Share on other sites

@Mazetar

Ok, im now getting this:

 

2013-08-18 20:05:52 [iNFO] [sTDOUT] CONFLICT @ 0 item slot already occupied by net.minecraft.item.ItemSpade@7deb98f6 while adding net.minecraft.item.Item@76877f0f

2013-08-18 20:05:52 [iNFO] [fml.ItemTracker] The mod RV97Drinks is overwriting existing item at 256 (net.minecraft.item.ItemSpade from Minecraft) with net.minecraft.item.Item

2013-08-18 20:05:52 [iNFO] [sTDOUT] CONFLICT @ 0 item slot already occupied by net.minecraft.item.Item@76877f0f while adding net.minecraft.item.Item@4aea4e2e

2013-08-18 20:05:52 [iNFO] [fml.ItemTracker] The mod RV97Drinks is overwriting existing item at 256 (net.minecraft.item.Item from RV97Drinks) with net.minecraft.item.Item

 

 

I have no idea why its mentioning the Spade item... Unless I accidentally conflicted with it with one of my items.

 

@GotoLink

I plan to add more types of crafting, so that will be the central crafting class where I, and possibly other mods, may access these crafting managers.

Link to comment
Share on other sites

Here are my BrewingManager and BrewingRecipe classes (Not to be mistaken for IBrewingManager and IBrewingRecipe), which handle adding the recipes etc.

 

BrewingManager:

package RV97.Drinks.Utils.Crafting;

import java.util.ArrayList;
import java.util.List;

import net.minecraft.item.ItemStack;
import net.minecraftforge.liquids.LiquidStack;

public class BrewingManager implements IBrewingManager{

private final List recipes;

public BrewingManager()
{
	this.recipes = new ArrayList();
}

public static IBrewingManager getInstance(){
	return CraftingManager.brewery;
}

public void addRecipe(ItemStack inputItemStack1, LiquidStack outputLiquidStack, int brewingTime) {
	if(inputItemStack1 == null){
		return;
	}
	this.recipes.add(new BrewingRecipe(inputItemStack1, outputLiquidStack, brewingTime));
}


public void addRecipe(ItemStack inputItemStack1, ItemStack inputItemStack2, LiquidStack outputLiquidStack, int brewingTime) {
	if((inputItemStack1 == null) || (inputItemStack2 == null)){
		return;
	}
	this.recipes.add(new BrewingRecipe(inputItemStack1, inputItemStack2, outputLiquidStack, brewingTime));
}


public void addRecipe(ItemStack inputItemStack1, LiquidStack inputLiquidStack, LiquidStack outputLiquidStack, int brewingTime) {
	if((inputItemStack1 == null) || (inputLiquidStack == null)){
		return;
	}
	this.recipes.add(new BrewingRecipe(inputItemStack1, inputLiquidStack, outputLiquidStack, brewingTime));
}


public void addRecipe(ItemStack inputItemStack1, ItemStack inputItemStack2, LiquidStack inputLiquidStack, LiquidStack outputLiquidStack, int brewingTime) {
	if((inputItemStack1 == null) || (inputItemStack2 == null) || (inputLiquidStack == null)){
		return;
	}
	this.recipes.add(new BrewingRecipe(inputItemStack1, inputItemStack2, inputLiquidStack, outputLiquidStack, brewingTime));
}


public IBrewingRecipe getRecipe(ItemStack inputStack) {
	if (inputStack == null){
		return null;
	}
	for (BrewingRecipe r : this.recipes){
		if(inputStack.isItemEqual(r.getInput1())){
			return r;
		}
	}
	return null;
}

public IBrewingRecipe getRecipe(ItemStack inputStack, ItemStack inputStack2) {
	if ((inputStack == null)||(inputStack2 == null)){
		return null;
	}
	for (BrewingRecipe r : this.recipes){
		if((inputStack.isItemEqual(r.getInput1())) && (inputStack2.isItemEqual(r.getInput2()))){
			return r;
		}
	}
	return null;
}

public IBrewingRecipe getRecipe(ItemStack inputStack, LiquidStack inputLiquid) {
	if ((inputStack == null)||(inputLiquid == null)){
		return null;
	}
	for (BrewingRecipe r : this.recipes){
		if((inputStack.isItemEqual(r.getInput1())) && (inputLiquid.isLiquidEqual(r.getLiquidInput()))){
			return r;
		}
	}
	return null;
}

public IBrewingRecipe getRecipe(ItemStack inputStack, ItemStack inputStack2, LiquidStack inputLiquid) {
	if ((inputStack == null)|| (inputStack2 == null) ||(inputLiquid == null)){
		return null;
	}
	for (BrewingRecipe r : this.recipes){
		if((inputStack.isItemEqual(r.getInput1())) && (inputStack2.isItemEqual(r.getInput2())) && (inputLiquid.isLiquidEqual(r.getLiquidInput()))){
			return r;
		}
	}
	return null;
}

public List getRecipes() {
	return this.recipes;
}


}

 

BrewingRecipe:

package RV97.Drinks.Utils.Crafting;

import net.minecraft.item.ItemStack;
import net.minecraftforge.liquids.LiquidStack;

public class BrewingRecipe implements IBrewingRecipe{
private final ItemStack inputStack;
private final ItemStack inputStack2;
private final LiquidStack inputLiquid;
private final LiquidStack resultLiquid;
private final int brewTime;

public BrewingRecipe(ItemStack inputStack, LiquidStack resultLiquid, int brewTime){
	this.inputStack = inputStack;
	this.resultLiquid = resultLiquid;
	this.brewTime = brewTime;
}

public BrewingRecipe(ItemStack inputStack, ItemStack inputStack2, LiquidStack resultLiquid, int brewTime){
	this.inputStack = inputStack;
	this.inputStack2 = inputStack2;
	this.resultLiquid = resultLiquid;
	this.brewTime = brewTime;
}

public BrewingRecipe(ItemStack inputStack, LiquidStack inputLiquid, LiquidStack resultLiquid, int brewTime){
	this.inputStack = inputStack;
	this.inputLiquid = inputLiquid;
	this.resultLiquid = resultLiquid;
	this.brewTime = brewTime;
}

public BrewingRecipe(ItemStack inputStack, ItemStack inputStack2, LiquidStack inputLiquid, LiquidStack resultLiquid, int brewTime){
	this.inputStack = inputStack;
	this.inputStack2 = inputStack2;
	this.inputLiquid = inputLiquid;
	this.resultLiquid = resultLiquid;
	this.brewTime = brewTime;
}

public int getBrewTime() {

	return this.brewTime;
}

public ItemStack getInput1() {

	return this.inputStack.copy();
}

public ItemStack getInput2() {

	if(this.inputStack2 == null){
	return null;
	}
	return this.inputStack2.copy();
}

public LiquidStack getLiquidInput() {

	if(this.inputLiquid == null){
	return null;
	}
	return this.inputLiquid.copy();
}

public LiquidStack getLiquidOutput() {

	return this.resultLiquid.copy();
}
}

Link to comment
Share on other sites

I moved the BrewingRecipe code into my brewing manager, so that should be fine. Still need to solve this crash though... I shall try re-adding all my items, just to check none of them are conflicting with 0. Shall Report back shortly.

 

EDIT: Ok, now the breakline no longer refers to id conflicts of 0 (turns out I forgot to change my config class to use my ID's for 2 items... Silly mistake ¬¬)

 

However, we are back to the original crash of:

 

2013-08-19 16:16:17 [iNFO] [sTDERR] java.lang.NullPointerException

2013-08-19 16:16:17 [iNFO] [sTDERR] at RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33)

2013-08-19 16:16:17 [iNFO] [sTDERR] at RV97.Drinks.DrinksCore.preInit(DrinksCore.java:44)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:494)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.post(EventBus.java:267)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:192)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:172)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.post(EventBus.java:267)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:103)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.common.Loader.loadMods(Loader.java:515)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:163)

2013-08-19 16:16:17 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.startGame(Minecraft.java:411)

2013-08-19 16:16:17 [iNFO] [sTDERR] at net.minecraft.client.MinecraftAppletImpl.startGame(MinecraftAppletImpl.java:44)

2013-08-19 16:16:17 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.run(Minecraft.java:733)

2013-08-19 16:16:17 [iNFO] [sTDERR] at java.lang.Thread.run(Unknown Source)

 

Link to comment
Share on other sites

2013-08-19 16:16:17  [sTDERR] java.lang.NullPointerException

2013-08-19 16:16:17  [sTDERR]    at RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33)

 

can we see those lines ?, actually the whole class and everythign related to it, its a NPE it shouldnt be that hard

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

@hydroFlame

My Liquids class as requested:

package RV97.Drinks;

import cpw.mods.fml.common.registry.LanguageRegistry;
import RV97.Drinks.Config.ItemInfo;
import RV97.Drinks.Items.Items;
import RV97.Drinks.Utils.Crafting.CraftingManager;
import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraftforge.liquids.LiquidContainerData;
import net.minecraftforge.liquids.LiquidContainerRegistry;
import net.minecraftforge.liquids.LiquidDictionary;
import net.minecraftforge.liquids.LiquidStack;

public class Liquids {
public static Item applejackDaniels;
public static Item goldApplejackDaniels;
public static Item witherWine;
public static Item zambambooze;
public static Item spiderSpirit;

public static void init(){
	applejackDaniels = new Item(ItemInfo.LIQUID_ID).setUnlocalizedName("applejackDaniels");
	LanguageRegistry.addName(applejackDaniels, "Apple JackDaniels");
}

public static void registerLiquids(){
	LiquidDictionary.getOrCreateLiquid("Apple JackDaniels", new LiquidStack(applejackDaniels, 1));
	LiquidContainerRegistry.registerLiquid(new LiquidContainerData(LiquidDictionary.getLiquid("Apple JackDaniels", 1000), new ItemStack(Items.drink,1,1), new ItemStack(Items.mug)));
}

public static void registerLiquidRecipes(){
	CraftingManager.brewery.addRecipe(new ItemStack(Item.sugar), new ItemStack(Item.appleRed), new LiquidStack(Block.waterStill.blockID, 1000), new LiquidStack(Block.lavaStill, 1000), 300);
}
}

 

Line 33 is: CraftingManager.brewery.addRecipe(new ItemStack(Item.sugar), new ItemStack(Item.appleRed), new LiquidStack(Block.waterStill.blockID, 1000), new LiquidStack(Block.lavaStill, 1000), 300);

 

@GotoLink

I moved that code into the BrewingManager code, which is the only class that tries to access those lines, so that should fix it (atleast, for now).

Link to comment
Share on other sites

@hydroflame

I am not sure... Where should it be? (I might have forgotten to create a class or two, as this is my first crafting system.)

 

@GotoLink

I did indeed remove the "final" keyword :)

Nice ;)

 

In your CraftingManager constructor maybe ?  ::)

public class CraftingManager {
public static IBrewingManager brewery;
public CraftingManager(IBrewingManager brewingMnger)
{
this.brewery = brewingMnger;
}
}

Link to comment
Share on other sites

I am not sure... Where should it be? (I might have forgotten to create a class or two, as this is my first crafting system.)

"somewhere" xD

literally, the NullPointerException is due to that

you are trying to call a method on a object that doesnt exists

 

public static IBrewingManager brewery;

this mean "yeah i have a IBreingManager" (but only that i have one, it doesnt say what or who it is)

 

then you go

CraftingManager.brewery.addRecipe(args)

and the JVM goes ragemode yelling

WHO THE F*** ARE YOU TALKING ABOUT, THERE'S NOTHING THERE !!!

 

so probably in your main mod class during preinit or wtv you should make:

CraftingManager.brewery = new BrewingManager();

 

actually it doesnt matter WHERE you place that, as long as its before

 

2013-08-18 18:56:08 [sEVERE] [ForgeModLoader] Caught exception from RV97Drinks

java.lang.NullPointerException

  at RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33)

  at RV97.Drinks.DrinksCore.preInit(DrinksCore.java:44)

line 44 of the method preInit in class DrinksCore. because thats when the code needs it ;)

 

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Ok, that solved it! Thanks for the explaination, I have never heard someone explain something like that xD

 

Just to use this thread a little more, I seem to be having trouble with searching through recipes. In my BrewingManager, I try to make a getRecipe function, but on my "for (BrewingRecipe r : this.recipe)" line, eclipse is telling me "Type mismatch: cannot convert from element type Object to BrewingManager.BrewingRecipe" and as I am still kinda nooby (as you may have gathered :P) I cant't figure out a solution... (Basically, just tell me how to solve this :3)

 

Thanks for all the help so far, I really appreciate it! :)

Link to comment
Share on other sites

that actually simple, your for loop should work but your List does not specify a generic type

 

google "java generic types" and you should find a butload of info on that

but basicly you want to make a

 

private List<BrewingRecipe> theList;

instead of a

private List theList;

the first one specify its a list of Brewing recipe while the 2nd will accept anything :\

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • The future of Bitcoin recovery is a topic of great interest and excitement, particularly with the emergence of innovative companies like Dexdert Net Pro Recovery leading the charge. As the cryptocurrency market continues to evolve and face new challenges, the need for effective solutions to help users recover lost or stolen Bitcoin has become increasingly critical. Dexdert Net Pro, a specialized firm dedicated to this very purpose, has positioned itself at the forefront of this emerging field. Through their proprietary techniques and deep expertise in blockchain technology, Dexdert Net Pro has developed a comprehensive approach to tracking down and retrieving misplaced or compromised Bitcoin, providing a lifeline to individuals and businesses who have fallen victim to the inherent risks of the digital currency landscape. Their team of seasoned investigators and cryptography experts employ a meticulous, multi-pronged strategy, leveraging advanced data analysis, forensic techniques, and collaborative partnerships with law enforcement to painstakingly trace the movement of lost or stolen coins, often recovering funds that would otherwise be considered irrecoverable. This pioneering work not only restores financial assets but also helps to bolster confidence and trust in the long-term viability of Bitcoin, cementing Dexdert Net Pro role as a crucial player in shaping the future of cryptocurrency recovery and security. As the digital finance ecosystem continues to evolve, the importance of innovative solutions like those offered by Dexdert Net Pro will only grow, ensuring that users can navigate the complexities of Bitcoin with greater peace of mind and protection. Call Dexdert Net Pro now     
    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.