[1.19.1] Unable to override vanilla recipe

[Edivad99]

I am contributing to an open source project and I should change the ingredients of a vanilla recipe.

I generated the new recipe via datagen and it was added to the path generated/resources/data/minecraft/recipes/rail.json along with its advancement in generated/resources/data/minecraft/advancements/recipes/transportation/rail.json

I start the game but it shows me the original recipe and not the modified one

Can you help me?

This is the the commit: https://github.com/Edivad99/Railcraft/commit/056addce1ef2e7af1cc151c79a62a436c3bac056

And this is the build.gradle: https://github.com/Edivad99/Railcraft/blob/1.19.x/build.gradle

[warjort]

Personally, I am against mods automatically altering vanilla stuff like this. It just leads to mod conflicts and confusion.

Mods should let the end user or modpack developer decide, e.g. by providing an optional datapack.

 

Anyway, you can see your issue if you click on datapacks in the create new world screen.

The forge mod which contains the vanilla recipe is above your mod in the list. So it won't use your recipe.

If you switch the order it will use your recipe.

 

The way this works looks backwards to me - but I might be reading it wrong?. I haven't looked at this code before.

See ServerLifecycleHooks.serverPackFinder()

It takes a list (really a LinkedHashMap) of mods in dependency order and adds them one by one to the datapack list at the "BOTTOM".

 

This means the datapacks will be in reverse order of the dependencies?

I would expect it the other way around so a mod that depends upon another mod can override the dependee's resources.

 

In your case, that would mean your mod would appear above forge since it depends upon it. But doesn't look like this is how it works currently.

[Edivad99]

Thanks for replying. I found how to fix. Go to mods.toml, in the modid = "forge" section and put ordering = "AFTER"

[warjort]

8 minutes ago, Edivad99 said:

Thanks for replying. I found how to fix. Go to mods.toml, in the modid = "forge" section and put ordering = "AFTER"

Right, so I was reading it wrong. 🙂

It was just your dependency wasn't specified "correctly".

Edited August 3, 2022 by warjort

[Edivad99]

Yes, it was set to NONE, probably loads the datapack in alphabetical order.