Delays

[mrkirby153]

How would I add a delay between something? I have a class that builds a house and I would like to add a 1/2 second delay between each block placement

[hydroflame]

shoot the task ti another thread and handle everything from there 

 

hint: Thread.sleep(500); wont do anything for 500ms

[diesieben07]

shoot the task ti another thread and handle everything from there 

 

hint: Thread.sleep(500); wont do anything for 500ms

Don't do that. Minecraft is Single-Threaded. Use Tickhandlers / ScheduledTickHandlers.

[hydroflame]

why the hell not, it works

[diesieben07]

why the hell not, it works

It might work, it might explode any time. If you modify the world or anything else from a different thread things WILL explode sooner or later.

The problem with Multithreading is that it might work, even though the code is buggy. For a LONG time. And then suddenly it goes boom.

[hydroflame]

the only i could see why it would fail is because of ssp when a player switch dimention. but if that happens just make a playertracker and send the message to the thread and ask it to finish all at once.

 

i guess scheduledtickhandler could be more "safe" but my during my test i wasn't able to make it blow up with another thread ....

[diesieben07]

the only i could see why it would fail is because of ssp when a player switch dimention. but if that happens just make a playertracker and send the message to the thread and ask it to finish all at once.

 

i guess scheduledtickhandler could be more "safe" but my during my test i wasn't able to make it blow up with another thread ....

Most stuff in Minecraft is not threadsafe (packetsending is one of the few things that is, because it HAS to be). You have been lucky probably during your local tests. But if the mod will go on a more frequently visited server it gets more and more likely that a method that isn't threadsafe gets called from your thread and the minecraft main thread at the same time. That might NOT blow it up, it might as well just produce unwanted behavior, even damage the world or whatever, depending on what you do in your thread.

[hydroflame]

heu .. the method that buidl the structure wouldnt be public

 

 

pseudo code of what i did:

public class StructurebuilderThread extends Thread{
    private ConcurrentLinkedQueue<BuildTask> tasks = new ConcurrentLinkedQueue<BuildTask>();
    public void addBuildTask(World world, int x, int y, int z){
        tasks.add(new BuildMyStructure(world, x, y, z));
    }

    public void run(){
        while(true){
            if(there is a task in queue){
                executeTask(tasks.poll());
            }
        }
    }

    private void executeTask(BuildTask task){
        //actual building here
    }
}

 

anyway op, diesieben is right you should use ScheduledTickHandler

[diesieben07]

@hydroflame: You will be calling world.setBlock from that other thread, right? That is NOT safe. Because another Thread may set a block at the same time, and that will cause interference because minecraft is not designed to compute 2 things at a time.

[mrkirby153]

How would I implement a tickhandler into https://github.com/mrkirby153/MscHouses/blob/master/common/mrkirby153/MscHouses/generation/HouseGen.java between the world.setBlock()

[diesieben07]

You can't just add the TickHandler "in between". You have to reorganize your code, split the world generation into smaller sub-parts (possibly make an interface and make an implementor for each partial stage of the generation).

 

Then in a TickHandler (probably a Scheduled one) you have an array of these implementors/generators in order. every time its time to generate the next piece, increment a counter and get the generator at that array index. Then let it generate.

[mrkirby153]

May I please have an example? I'm a visual learner when it comes to code

[Mazetar]

How proficient are you with OOP?

[mrkirby153]

What's OOP?

[Mazetar]

What's OOP?

 

It's time to go back to school mate

 

Either: courses.vswe.se or http://see.stanford.edu/see/lecturelist.aspx?coll=824a47e1-135f-4508-a5aa-866adcae1111

 

Free courses which you need!

[mrkirby153]

Actually, I was talking about the acronym. What does OOP mean? Ive never heard the acronym

[hydroflame]

object oriented programming, a term probably as common as LOL in the programming world

[mrkirby153]

OH! I'm pretty proficient with OOP then

[mrkirby153]

I also created a Schedueld Tick Handler that "fires" a tick every .5 seconds. Maybe I can use that?

[hydroflame]

sure

[mrkirby153]

But, I don't know how to!

 

Also, in my tick handler, every 1/2 seconds it increases a variable and I have a method to reset the variable back to 0

 

[hydroflame]

every time your tickhandler ticks ... create a new block of the structure

[mrkirby153]

May I please have an example?

[Mazetar]

Inside the tickHandler, when it ticks check if there are anything needing to get placed.

Place one of the blocks and remove it from the list of things getting placed.

done.

[mrkirby153]

May I have a CODE example?