SOLVED - Modify NBT Tags

[Diamown]

Hey, I want to modify an existing item tag, I want to add to a creative tab a light block with a level of 8, I tried many times but failed, can you help me fix it (i'm using forge 1.19) ?

Edited August 22, 2022 by Diamown
specify version of forge

[warjort]

If I understand your question correctly, override fillItemCategory() for your Item to add ItemStack(s) that do what you want.

 

[warjort]

11 minutes ago, warjort said:

If I understand your question correctly, override fillItemCategory() for your Item to add ItemStack(s) that do what you want.

 

Although since you are probably using a BlockItem? You should override the fillItemCategory() on your Block.

[Diamown]

It's not the problem, I'm aldray using fillItemCategory() but I want to add an vanilla block with a modified nbt tag : "level"

[warjort]

Then just override fillItemList() for your CreativeModeTab.

Edited August 22, 2022 by warjort

[Diamown]

The problem is just to get a ItemStack of a vanilla item with a modified BlockState

[Luis_ST]

You can take a look at LightBlock#getCloneItemStack how to get the ItemStack certain BlockState.
You can copy the logic there or you call the vanilla logic with a BlockState which has the values you want to have a ItemStack of.

[Diamown]

I finaly found a working way :

Quote

 

ItemStack lightItem = Items.LIGHT.getDefaultInstance();

CompoundTag compoundtag = new CompoundTag();

CompoundTag compoundtag1 = new CompoundTag();

compoundtag1.putInt("level", light);

compoundtag.put("BlockStateTag", compoundtag1);

lightItem.setTag(compoundtag);

 

 

Edited August 22, 2022 by Diamown

[warjort]

There's some pretty bad habits in that code. 🙂

And I don't think it works properly?

 

* You shouldn't just setTag() - this will wipe out other important info already in the item stack created by getDefaultInstance(). You should modify only the part you are interested in.

* You should use symbolic constants to make the code more readable. It also helps to trap when future changes by Mojang will affect your code.

* The block state values are stored as Strings - in general you should use the property to generate the serialized value - getName(T)

 

            var lightStack = Items.LIGHT.getDefaultInstance();
            var blockStateTag = lightStack.getOrCreateTagElement(BlockItem.BLOCK_STATE_TAG);
            blockStateTag.putString(BlockStateProperties.LEVEL.getName(), BlockStateProperties.LEVEL.getName(8)); // putString("level", "8")