Synched Entity Model

[LuccaPossamai]

Hello, I'm making an Entity that extends AbstractArrow, but when I was making the Renderer and the Model. I realized that the "setupAnim(...)" method was running on entities that it shouldn't run on. In the case,  an entity's "animation" was running on another entity animation.

I think the problem is in the renderer, here's the code.  

Spoiler

public class AmethystBoulderRenderer extends EntityRenderer<AmethystBoulder> {
    private static final ResourceLocation TEXTURE_LOCATION = new ResourceLocation(ModMain.MODID, "textures/entity/amethyst_boulder.png");
    protected AmethystBoulderModel<AmethystBoulder> model;

    public AmethystBoulderRenderer(EntityRendererProvider.Context p_174368_) {
        super(p_174368_);
        this.model = new AmethystBoulderModel<>(p_174368_.bakeLayer(ModModelLayers.SLIME_BALL));
    }

    @Override
    public void render(AmethystBoulder p_114080_, float p_114081_, float p_114082_, PoseStack p_114083_, MultiBufferSource p_114084_, int p_114085_) {
        int size = p_114080_.getSize();
        this.shadowRadius = 0.35F * size;

        p_114083_.pushPose();
        p_114083_.mulPose(Vector3f.YP.rotationDegrees(Mth.lerp(p_114082_, p_114080_.yRotO, p_114080_.getYRot()) - 90.0F));
        p_114083_.mulPose(Vector3f.ZP.rotationDegrees(Mth.lerp(p_114082_, p_114080_.xRotO, p_114080_.getXRot())));
        p_114083_.scale(-0.5F * size, -0.5F * size, 0.5F * size);
        if(!p_114080_.inGround() && !p_114080_.isNoGravity()) {
            this.model.setupAnim(p_114080_, p_114082_, 0, 0, 0, p_114080_.getTicksSinceLastKick());
        }
        VertexConsumer vertexconsumer = p_114084_.getBuffer(this.model.renderType(TEXTURE_LOCATION));
        this.model.renderToBuffer(p_114083_, vertexconsumer, p_114085_, OverlayTexture.NO_OVERLAY, 1.0F, 1.0F, 1.0F, 1.0F);
        p_114083_.popPose();
        super.render(p_114080_, p_114081_, p_114081_, p_114083_, p_114084_, p_114085_);
    }
    
    @Override
    public @NotNull ResourceLocation getTextureLocation(AmethystBoulder p_115860_) {
        return TEXTURE_LOCATION;
    }
}

 

Here's the Model class too:

Spoiler

public class AmethystBoulderModel<T extends AmethystBoulder> extends HierarchicalModel<T> {
    private final ModelPart root;
    private final ModelPart main;

    public AmethystBoulderModel(ModelPart p_170916_) {
        this.root = p_170916_;
        this.main = p_170916_.getChild("main");
    }

    public static LayerDefinition createBodyLayer() {
        MeshDefinition meshdefinition = new MeshDefinition();
        PartDefinition partdefinition = meshdefinition.getRoot();
        //-8, -16, -8
        partdefinition.addOrReplaceChild("main", CubeListBuilder.create().texOffs(0, 0).addBox(-8.0F, -8.0F, -8.0F, 16.0F, 16.0F, 16.0F), PartPose.offset(0,-8,0));
        return LayerDefinition.create(meshdefinition, 64, 32);
    }

    public ModelPart root() {
        return this.root;
    }


    private double log(float tick){
        double base = 1.1D;
        return Math.log(tick + 1) / Math.log(base);
    }

    @Override
    public void setupAnim(T p_102618_, float p_102619_, float p_102620_, float p_102621_, float p_102622_, float tick) {
        if(!p_102618_.isNoGravity() && !p_102618_.inGround()) {
            this.main.zRot = (float) (-5 * (log(tick)) * (Math.PI / 180F));
        }
    }

 

 

[warjort]

Show your registration code.

While you are at it show all the code, so we don't have to play a guessing game on what you might be doing wrong.

Edited November 16, 2022 by warjort

[LuccaPossamai]

Spoiler

public class ModEntityTypes {

    public static final DeferredRegister<EntityType<?>> ENTITIES = DeferredRegister.create(ForgeRegistries.ENTITY_TYPES, ModMain.MODID);


    public static final RegistryObject<EntityType<IceIsolator>> ICE_ISOLATOR = ENTITIES.register("ice_isolator", () -> EntityType.Builder.of(
            IceIsolator::new,
            MobCategory.CREATURE)
            .canSpawnFarFromPlayer()
            .sized(0.6F, 1.95F)
            .clientTrackingRange(8).build("ice_isolator"));

    public static final RegistryObject<EntityType<SpiritualNomadEntity>> NOMAD = ENTITIES.register("spiritual_nomad", () ->
            EntityType.Builder.of(
            SpiritualNomadEntity::new,
            MobCategory.MISC)
            .canSpawnFarFromPlayer()
            .sized(0.6F, 1.95F)
            .clientTrackingRange(8).build("spiritual_nomad"));

    public static final RegistryObject<EntityType<ThrownAlgidAxe>> ALGID_AXE = ENTITIES.register("algid_axe", () ->
            EntityType.Builder.<ThrownAlgidAxe>of(
            ThrownAlgidAxe::new,
            MobCategory.MISC)
            .sized(0.5F, 0.5F)
            .clientTrackingRange(4)
            .updateInterval(20).build("algid_axe"));

    public static final RegistryObject<EntityType<ColdFireball>> COLD_FIREBALL = ENTITIES.register("cold_fireball", () ->
            EntityType.Builder.<ColdFireball>of(ColdFireball::new, MobCategory.MISC)
            .sized(0.3125F, 0.3125F).clientTrackingRange(4).updateInterval(10).build("cold_fireball"));

    public static final RegistryObject<EntityType<AmethystBoulder>> AMETHYST_BOULDER = ENTITIES.register("amethyst_boulder", () ->
            EntityType.Builder.<AmethystBoulder>of(AmethystBoulder::new, MobCategory.MISC)
                    .sized(0.5F, 0.5F).clientTrackingRange(4).updateInterval(10).build("amethyst_boulder"));



}

 

All the other entities model work fine.

[warjort]

No the registration of entity renders. That's why I said post all the code.

Otherwise, this will be another time sink of a thread trying to track down a simple typo in code we can't see.

Edited November 16, 2022 by warjort

[LuccaPossamai]

Oh, I see. Sorry, here's the repository https://github.com/luccaPossamai/M.O.Hard-FORGE. 

I will send the renderers registration anyway.

Spoiler

@Mod.EventBusSubscriber(modid = ModMain.MODID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class EntitiesRenderer {

    @SubscribeEvent
    public static void register(EntityRenderersEvent.RegisterRenderers event){
        event.registerEntityRenderer(ModEntityTypes.ICE_ISOLATOR.get(), IceIsolatorRenderer::new);
        event.registerEntityRenderer(ModEntityTypes.NOMAD.get(), SpiritualNomadRenderer::new);
        event.registerEntityRenderer(ModEntityTypes.ALGID_AXE.get(), AlgidAxeRenderer::new);
        event.registerEntityRenderer(ModEntityTypes.COLD_FIREBALL.get(), ColdFireballRenderer::new);
        event.registerEntityRenderer(ModEntityTypes.AMETHYST_BOULDER.get(), AmethystBoulderRenderer::new);
    }

}

 

 

[warjort]

I don't see an obvious typo or incorrect use of static methods/fields.

So I tried to run your mod, but I get this error.

Quote

Caused by: java.io.FileNotFoundException: mohard:particles/vilio.json
        at net.minecraft.server.packs.resources.ResourceProvider.lambda$getResourceOrThrow$0(ResourceProvider.java:20) ~[forge-1.19.2-43.1.52_mapped_official_1.19.2.jar%23183!/:?] {re:classloading}
 

Can you make sure the repo is up-to-date with what you are testing.

Also can you give instructions on how I can reproduce the issue.

[LuccaPossamai]

Oh I'm sorry, now It's fixed in the repository.

To see the problem you must right click an item called "Wand"(Artifacts tab). This way you'll launch an amethyst boulder, when it stops bouncing, if you press right click again you'll launch another boulder, but, the one that is in the ground will rotate too.

[warjort]

Ok, I understand the problem now.

When you said 

Quote

I realized that the "setupAnim(...)" method was running on entities that it shouldn't run on. In the case,  an entity's "animation" was running on another entity animation.

I thought you meant it was drawing the model for a completely different entity type. I was looking for where you had a miss typed a resource location.

 

Your problem is the model is shared by all entities. So if you rotate one entity, you need to reset the model when doing the next entity.

You only changing it conditionally so the entity will have the rotation from the previous entity if your condition check fails.

For some reason you are double checking the condition as well?

https://github.com/luccaPossamai/M.O.Hard-FORGE/blob/deabf4f1850ea3ea30f8220ed067a1709229cee6/src/main/java/net/lucca/mohard/entities/amethystBoulder/AmethystBoulderRenderer.java#L34

https://github.com/luccaPossamai/M.O.Hard-FORGE/blob/deabf4f1850ea3ea30f8220ed067a1709229cee6/src/main/java/net/lucca/mohard/entities/amethystBoulder/AmethystBoulderModel.java#L40

Edited November 16, 2022 by warjort

[LuccaPossamai]

I was double checking to see with the debugger, but I had not seen the problem, I finally managed to fix it here, thank you very much.