Variable Weapon Damage

[Draco18s]

Is it reasonably possible to have a single Item class that would allow for variable weapon strength (using NBT tags) without having to go through the enchantment system (i.e. Sharpness)?

 

As far as I can tell, item damage is handled via getItemAttributeModifiers(), which does not pass an ItemStack (so no NBT data).

 

Resorting to the Sharpness enchantment isn't out of the question, just less than ideal, as I'd like to handle that independently.

[GotoLink]

LivingHurtEvent/LivingAttackEvent ?

You can get the ItemStack held at the hit time, read the NBT and deal different damage.

[CJCutrone9]

Or, you could create a random number generator and set the damage to that random number.

[Draco18s]

LivingHurtEvent/LivingAttackEvent ?

You can get the ItemStack held at the hit time, read the NBT and deal different damage.

 

Due to the nature of what I'm doing this would be exceedingly difficult.  EXCEEDINGLY.

 

Or, you could create a random number generator and set the damage to that random number.

 

Affects all instances of that item, not a valid solution.

I want each instance to have its own value that is constant, not magically alter every item instance to a different number every time that number is polled.

 

You can just store the AttributeModifiers in the ItemStack nbt directly so ItemStack.getAttributeModifiers understands it (have a look at the method and you will understand).

 

Ah ha!  Brilliant.  I didn't see that ItemStack had the same tidlybits.

[Draco18s]

You can just store the AttributeModifiers in the ItemStack nbt directly so ItemStack.getAttributeModifiers understands it (have a look at the method and you will understand).

 

 

Holycow this was not easy.

 

Here's what I ended up with:

 

public ItemStack attached(ItemStack i, Random rand) {
	NBTTagCompound inbt = i.stackTagCompound;
	NBTTagCompound nnbt = new NBTTagCompound();
	NBTTagList nnbtl = new NBTTagList();
	AttributeModifier att = new AttributeModifier("generic.attackDamage", 1, 0);
	nnbt.setLong("UUIDMost", att.getID().getMostSignificantBits());
	nnbt.setLong("UUIDLeast", att.getID().getLeastSignificantBits());
	nnbt.setString("Name", att.getName());
	nnbt.setDouble("Amount", att.getAmount());
	nnbt.setInteger("Operation", att.getOperation());
	nnbt.setString("AttributeName", att.getName());
	nnbtl.appendTag(nnbt);
	inbt.setTag("AttributeModifiers", nnbtl);
	return i;
}

 

List of modifier names, as they do not appear to be listed anywhere convenient:

 

generic.attackDamage
generic.followRange
generic.maxHealth
generic.knockbackResistance
generic.movementSpeed

 

And a handful of others that only apply to specific mobs (parentheticals indicate what entity):

 

zombie.spawnReinforcements  (zombies)
Baby speed boost (zombies)
Attacking speed boost (endermen, pig zombies)
Drinking speed penalty (witches)

[Draco18s]

SharedMonsterAttributes

 

Ah.  Yes.  Of course, what's funny is when I tried it, an enchanted weapon told me the string was "Weapon damage" and my code didn't work.

(Turned out the line I was missing at the time was

nnbt.setString("AttributeName", att.getName());

  "AttributeName" being what the end-result looks for, but I never found it being set anywhere, though I did find "Name" used in several places).

 

Like I said, pain in the ass to figure out from just the code.