Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[SOLVED] Block metadata resets to 0

superckl

By superckl
in Modder Support

 Share

Recommended Posts

superckl Stone Miner

superckl

Posted
Posted

I'm having a strange problem... When someone right clicks my custom block, I set it's metadata to 1 with:

 

world.setBlockMetadataWithNotify(x, y, z, 1, 2)

 

Where x, y, z, and world are the values passed in onBlockActivated. I have a check in that method so I can make sure the set metadata method returns true, and it does.

 

The problem is, when I close Minecraft and come back, the metadata has reset itself to 0.

 

This is how I am checking the metadata (onChunkLoad):

 

	@ForgeSubscribe
public void onChunkLoad(ChunkDataEvent.Load e){
	for(ExtendedBlockStorage storage:e.getChunk().getBlockStorageArray())
		if(storage != null && !storage.isEmpty())
			for(int x = 0; x < 16; x++)
				for(int z = 0; z < 16; z++)
					for(int y = 0; y < 16; y++)
						if(storage.getExtBlockID(x, y, z) == FirstMod.instance.fishDirt.blockID){
							System.out.println(storage.getExtBlockMetadata(x, y, z));
							System.out.println(((e.getChunk().xPosition << 4) + x) +":"+ (storage.getYLocation()+y) +":"+ ((e.getChunk().zPosition << 4) + z));
						}

}

 

The prints are from me testing if the coordinates matched up to when I set the metadata(they do). The fist print prints 0. I can not figure out why.

 

I'm a fairly adept java programmer (about a year's experience) but I just started this whole forge modding thing, so if I made a stupid mistake somewhere, please correct me (nicely :P). And, before you ask, yes I did a Google search and a search on here.

width=450 height=160http://i.imgur.com/nVI9Y.png[/img]

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

client-server disparity.

 

Minecraft.getMinecraft().theWorld returns the client's world, so you're only changing the block on the client side, and when the chunk gets an update packet from the server, the block will reset.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Do a quick "if(!world.isRemote){}" around your code and see if that changes anything.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Around the part where you're changing the block metadata?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
superckl Stone Miner

superckl

Posted
  • Author
Posted 

	@Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int par6, float par7, float par8, float par9) {
	if(world.isRemote){
		return true;
	}
	Location location = new Location(x, y, z);
    	if(!FirstMod.instance.fishDirts.remove(location)){
    			FirstMod.instance.fishDirts.add(location);
    			if(world.setBlockMetadataWithNotify(x, y, z, 1, 2))
    				System.out.println("set to 1");
    			Minecraft.getMinecraft().theWorld.addWeatherEffect(new EntityLightningBolt(Minecraft.getMinecraft().theWorld, x, y, z));
    	}else{
    		if(Minecraft.getMinecraft().theWorld.setBlockMetadataWithNotify(x, y, z, 0, 2))
    			System.out.println("set to 0");
    	}
	return true;
}

 

That's my onBlockActivated method. The metadata is now somehow permanently set to 1. The "set to 1" print never happens, but the "set to 0" print happens when I deactivate it, as expected.  ???

 

The Location class is made by me for storing x-y-z triplets, if you were wondering (I'm a Bukkit programmer at heart  ;)).

width=450 height=160http://i.imgur.com/nVI9Y.png[/img]

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

Not sure what's going on; I'm a little worn out after a long day.

 

The Location class is made by me for storing x-y-z triplets, if you were wondering (I'm a Bukkit programmer at heart  ;)).

 

Look up Vec3.  You reimplemented it with a new name.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
MineMaarten Creeper Killer

MineMaarten

Posted
Posted 

Location location = new Location(x, y, z);
    	if(!FirstMod.instance.fishDirts.remove(location)){

Well, you're making a new Location object which you're trying to remove from a list? In that case, you'll always fail to remove it, as the reference of the new object never can be the same as one of the objects in the list. Unless you've correctly overriden the equals() method in your Location class?

 

Also this will not work on the server side, as mentioned before by Draco18s:

Minecraft.getMinecraft().theWorld.addWeatherEffect(new EntityLightningBolt(Minecraft.getMinecraft().theWorld, x, y, z));

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Link to comment
Share on other sites
superckl Stone Miner

superckl

Posted
  • Author
Posted

Here's my base class:

@Mod(modid="FirstMod", name="First Mod", version="1.0")
@NetworkMod(clientSideRequired=true)
public class FirstMod{

public final ItemStack fishRod = new ItemStack(new FishRod(900));
public final Block fishDirt = new FishDirt(901);

@Instance(value = "FirstMod")
public static FirstMod instance;

public Set<Location> fishDirts = new LocationSet();

@cpw.mods.fml.common.Mod.EventHandler
public void preInit(FMLPreInitializationEvent e){

}

@cpw.mods.fml.common.Mod.EventHandler
public void load(FMLInitializationEvent e){
	TickRegistry.registerTickHandler(new PlayerTickListener(), Side.CLIENT);
	TickRegistry.registerTickHandler(new WorldTickListener(), Side.CLIENT);
	MinecraftForge.EVENT_BUS.register(new EventHandler());
	GameRegistry.registerBlock(this.fishDirt, "FishDirt");
	GameRegistry.registerItem(this.fishRod.getItem(), "FishRod");
	LanguageRegistry.addName(this.fishRod, "Great Rod of the Fish God");
	LanguageRegistry.addName(this.fishDirt, "Great Dirt of the Fish God");
	GameRegistry.addRecipe(this.fishRod, "  x", " y ", 'x', new ItemStack(Item.fishRaw), 'y', new ItemStack(Item.stick));
	GameRegistry.addRecipe(new ItemStack(this.fishDirt), "xxx", "xyx", "xxx", 'x', new ItemStack(Item.fishRaw), 'y', new ItemStack(Block.dirt));
}

@cpw.mods.fml.common.Mod.EventHandler
public void postInit(FMLPostInitializationEvent e){
}


}

If you require anything else, just ask. I don't think the Tick or Event handlers are necessary as they don't touch anything with blocks or metadata (except the chunk load one).

width=450 height=160http://i.imgur.com/nVI9Y.png[/img]

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • CatzRule81
      [1.18.2] Custom armor set extending DyeableArmorItem is dye-able, but not displaying

      By CatzRule81 · Posted

      I am not using hardcoded recipes, I'm using Vanilla's already existing code for leather armor dying. (via extending and implementing DyeableArmorItem / DyeableLeatherItem respectively) I have actually figured out that it's something to do with registering item colors to the ItemColors instance, but I'm trying to figure out where exactly in my mod's code I would be placing a call to the required event handler. Unfortunately the tutorial is criminally undescriptive. The most I've found is that it has to be done during client initialization. I'm currently trying to do the necessary setup via hijacking the item registry since trying to modify the item classes directly (via using SubscribeEvent in the item's constructor didn't work. Class so far: // mrrp mrow - mcmod item painter v1.0 - catzrule ch package catzadvitems.init; import net.minecraft.client.color.item.ItemColors; import net.minecraft.world.item.Item; import net.minecraftforge.registries.ObjectHolder; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.client.event.ColorHandlerEvent; import catzadvitems.item.DyeableWoolArmorItem; @Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD) public class Painter { @ObjectHolder("cai:dyeable_wool_chestplate") public static final Item W_CHEST = null; @ObjectHolder("cai:dyeable_wool_leggings") public static final Item W_LEGS = null; @ObjectHolder("cai:dyeable_wool_boots") public static final Item W_SOCKS = null; public Painter() { // left blank, idk if forge throws a fit if constructors are missing, not taking the chance of it happening. } @SubscribeEvent public static void init(FMLClientSetupEvent event) { new Painter(); } @Mod.EventBusSubscriber private static class ForgeBusEvents { @SubscribeEvent public static void registerItemColors(ColorHandlerEvent.Item event) { ItemColors col = event.getItemColors(); col.register(DyeableUnderArmorItem::getItemDyedColor, W_CHEST, W_LEGS, W_SOCKS); //placeholder for other dye-able items here later.. } } } (for those wondering, i couldn't think of a creative wool helmet name)
    • HalfZonedOut
      Crashes after saying mod loading error

      By HalfZonedOut · Posted

      nvm found out it was because i had create h and not f
    • Shipwrecker
      [1.18.2] Custom armor set extending DyeableArmorItem is dye-able, but not displaying

      By Shipwrecker · Posted

      Maybe there's something happening in the 'leather armor + dye' recipe itself that would be updating the held item texture?
    • Shipwrecker
      [1.20.1] Difficulty getting custom player model to render

      By Shipwrecker · Posted

      @SubscribeEvent public static void onRenderPlayer(RenderPlayerEvent.Pre e) { e.setCanceled(true); model.renderToBuffer(e.getPoseStack(), pBuffer, e.getPackedLight(), 0f, 0f, 0f, 0f, 0f); //ToaPlayerRenderer.render(); } Since getting the render method from a separate class is proving to be bit of a brick wall for me (but seems to be the solution in older versions of minecraft/forge) I've decided to try and pursue using the renderToBuffer method directly from the model itself. I've tried this route before but can't figure out what variables to feed it for the vertexConsumer and still can't seem to figure it out; if this is even a path to pursue.  The vanilla model files do not include any form of render methods, and seem to be fully constructed from their layer definitions? Their renderer files seem to take their layers which are used by the render method in the vanilla MobRenderer class. But for modded entities we @Override this function and don't have to feed the method variables because of that? I assume that the render method in the extended renderer takes the layer definitions from the renderer classes which take those from the model files. Or maybe instead of trying to use a render method I should be calling the super from the renderer like   new ToaPlayerRenderer(context, false); Except I'm not sure what I would provide for context? There's a context method in the vanilla EntityRendererProvider class which doesn't look especially helpful. I've been trying something like <e.getEntity(), model<e.getEntity()>> since that generally seems to be what is provided to the renderers for context, but I don't know if it's THE context I'm looking for? Especially since the method being called doesn't want to take this or variations of this.   In short; I feel like I'm super super close but I have to be missing something obvious? Maybe this insane inane ramble post will provide some insight into this puzzle?
    • CatzRule81
      [1.18.2] Custom armor set extending DyeableArmorItem is dye-able, but not displaying

      By CatzRule81 · Posted

      bump

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept