Hello

 

I am trying to add a potion effect when my item is held that lasts until the player selects a different item.

 

    public void onUpdate(ItemStack par1ItemStack, World par2World, Entity par3Entity, int par4, boolean par5, EntityPlayer par6)
    {
     if(par6.getCurrentEquippedItem().equals(getUnlocalizedName()))
     {
      par6.addPotionEffect(new PotionEffect(Potion.moveSpeed.id, 100, 3, true));
     }
     else
     {
      par6.curePotionEffects(par1ItemStack);
     }
    }

 

For some reason this doesn't work. How can I get it to work?

 

Here is the link to the full item's class: http://pastebin.com/R3EHXvif

 

Thanks in advance for the help.

See line 153.

 

Probably not the best method in the world, but it works.

(Note: that particular class doesn't care about currently-active status, but that's just a flag)

I don't know where you came up with that onUpdate method, but the correct signature only has 5 parameters:

public void onUpdate(ItemStack par1ItemStack, World par2World, Entity par3Entity, int par4, boolean par5) {}

With the incorrect signature, this method will never get called unless you call it yourself. Adding '@Override' above methods such as this will help prevent you from making simple mistakes in the future.

 

par5 is true if the itemstack is currently being used, so you could just check 'if (par5) add potion effect'