Jump to content

[SOLVED] Sword dynamic damage to entities (based on item damage)


Recommended Posts

Posted

I'm trying to make a custom Sword that will deal damage to entities based on current sword item damage.

 

Currently, I have a functioning sword that extends the ItemSword class, and uses a custom ToolMaterial.

Damage vs entities is normally based on ToolMaterial the sword is made of, and I am able to change that,

but I would like to reduce this damage dealt if the sword item itself is damaged (used).

 

I see that there are functions "public float func_82803_g()" and "public Multimap func_111205_h()" in ItemSword and

they both take weaponDamage into account, but those functions have no arguments, so there is no way to access itemStack

from them in order to check how damaged the sword is.

 

I also checked the hitEntity function, but it doesn't do anything except damage the sword and return boolean.

 

Can someone help me with this?

Posted

you want to make it like this:

 

damage of the sword is higher, entities get less damage.

damage of the sword is lower, entities get more damage.

 

if you want that then just make a math variable for that.

And there is more than one way to make a entitybased or itembased damage.

And you were right. its the HitEntity function.

You can hurt entities on two ways. With the multimap function or with the hit entitiy function.

 

You just need the entity you want to hurt/heal. i made a sword that damage 1 damage it 1 extra half heart and heals a full heart. this means it makes no damage xD

Posted

So basically you say that I should make ToolMaterial default damage 0, and calculate all damage in hitEntity function?

That way the Multimap function will deal no damage, and I would have control over entity in hitEntity...

 

Thanks, i will try that...

Posted

Ok, everything regarding damage works fine now. Thank you!

 

Now I have a problem of displaying a custom Attack Damage number on hover on item in inventory - I can't seem to find the function that returns this...

Posted

Now I have a problem of displaying a custom Attack Damage number on hover on item in inventory - I can't seem to find the function that returns this...

 

I think ItemSword handles that.  I recall running across it recently, but not recently enough to remember where I saw it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Now I have a problem of displaying a custom Attack Damage number on hover on item in inventory - I can't seem to find the function that returns this...

 

I think ItemSword handles that.  I recall running across it recently, but not recently enough to remember where I saw it.

 

Only functions in ItemSword that mention damage (as far as I can see) are:

 

public float func_82803_g()
{
    return this.toolMaterial.getDamageVsEntity();
}

 

and

 

public Multimap func_111205_h()
{
Multimap multimap = super.func_111205_h();
multimap.put(SharedMonsterAttributes.field_111264_e.func_111108_a(), new AttributeModifier(field_111210_e, "Weapon modifier", (double)this.weaponDamage, 0));
return multimap;
}

 

I tried overriding both of them, but there appears to be no change of display value on hover...

 

In Item class there is addInformation function that deals with adding info on hover, but that is not overriden anywhere in ItemSword.

There must be a simple method I'm overlooking...

Posted

In Item class there is addInformation function that deals with adding info on hover, but that is not overriden anywhere in ItemSword.

There must be a simple method I'm overlooking...

 

addInformation does add tooltips, but I think that Multimap func_111205_h() is the one I was thinking of.

 

If you're trying to override it and then get the multimap for your own purposes, super.func_111205_h() will give you what ItemSword is already adding, which you don't want.  You'd have to look at the base Item class's implementation.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

In Item class there is addInformation function that deals with adding info on hover, but that is not overriden anywhere in ItemSword.

There must be a simple method I'm overlooking...

 

addInformation does add tooltips, but I think that Multimap func_111205_h() is the one I was thinking of.

 

If you're trying to override it and then get the multimap for your own purposes, super.func_111205_h() will give you what ItemSword is already adding, which you don't want.  You'd have to look at the base Item class's implementation.

 

You are right.

Before, I tried overriding and setting custom value, but it didn't work because the first line is "Multimap multimap = super.func_111205_h();"

Super (in this case) is not Item, but ItemSword, so the returned multimap already had the value set.

I looked up the overridden Item method, ant it was simply returning "HashMultimap.create();".

Finally, I changed the method to create a new Multimap, and now it's showing the info correctly.

 

Thank you!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
    • Ah, it appears I spoke too soon, I still need a little help here. I now have the forceloading working reliably.  However, I've realized it's not always the first tick that loads the entity.  I've seen it take anywhere from 2-20ish to actually go through, in which time my debugging has revealed that the chunk is loaded, but during which time calling  serverLevelIn.getEntity(uuidIn) returns a null result.  I suspect this has to do with queuing and how entities are loaded into the game.  While not optimal, it's acceptable, and I don't think there's a whole ton I can do to avoid it. However, my concern is that occasionally teleporting an entity in this manner causes a lag spike.  It's not every time and gives the appearance of being correlated with when other chunks are loading in.  It's also not typically a long spike, but can last a second or two, which is less than ideal.  The gist of how I'm summoning is here (although I've omitted some parts that weren't relevant.  The lag occurs before the actual summon so I'm pretty confident it's the loading, and not the actual summon call). ChunkPos chunkPos = new ChunkPos(entityPosIn); if (serverLevelIn.areEntitiesLoaded(chunkPos.toLong())) { boolean isSummoned = // The method I'm using for actual summoning is called here. Apart from a few checks, the bulk of it is shown later on. if (isSummoned) { // Code that runs here just notifies the player of the summon, clears it from the queue, and removes the forceload } } else { // I continue forcing the chunk until the summon succeeds, to make sure it isn't inadvertently cleared ForgeChunkManager.forceChunk(serverLevelIn, MODID, summonPosIn, chunkPos.x, chunkPos.z, true, true); } The summon code itself uses serverLevelIn.getEntity(uuidIn) to retrieve the entity, and moves it as such.  It is then moved thusly: if (entity.isAlive()) { entity.moveTo(posIn.getX(), posIn.getY(), posIn.getZ()); serverLevelIn.playSound(null, entity, SoundEvents.ENDERMAN_TELEPORT, SoundSource.NEUTRAL, 1.0F, 1.0F); return true; } I originally was calling .getEntity() more frequently and didn't have the check for whether or not entities were loaded in place to prevent unnecessary code calls, but even with those safety measures in place, the lag still persists.  Could this just be an issue with 1.18's lack of optimization in certain areas?  Is there anything I can do to mitigate it?  Is there a performance boosting mod I could recommend alongside my own to reduce the chunk loading lag? At the end of the day, it does work, and I'm putting measures in place to prevent players from abusing the system to cause lag (i.e. each player can only have one queued summon at a time-- trying to summon another replaces the first call).  It's also not an unacceptable level of lag, IMO, given the infrequency of such calls, and the fact that I'm providing the option to toggle off the feature if server admins don't want it used.  However, no amount of lag is ideal, so if possible I'd love to find a more elegant solution-- or at least a mod recommendation to help improve it. Thanks!
    • When i start my forge server its on but when i try to join its come a error Internal Exception: java.lang.OutOfMemoryError: Requested array size exceeds VM limit Server infos: Linux Minecraft version 1.20.1 -Xmx11G -Xms8G
    • Also add the latest.log from your logs-folder
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.