[SOLVED] Really weird rendering bug

nerdboy64 · August 20, 2012

I have a block in my mod that changes its texture using a custom block model, which is really a re-purposed ladder model. but I'm getting this really strange bug where any other blocks in the same chunk with a y value greater than or equal to that of my block will be displayed with the texture my block is currently using. If there are multiple instances of my block, the affected blocks show the texture of the first one placed.

Here are some screenshots of the bug:

Totally normal, none of my blocks have been placed yet. The birch planks outline a chunk, from 0,0 to 16,16.

I place one of my blocks down, and this happens:

My block is a "gun rack," which holds guns from my mod and changes texture to look like whichever one is attached to it. When I place a gun on the block, this happens:

If I place down another gun rack and put a different gun on it, the bugged blocks keep the texture of the first one.

Here's my code:

BlockNewGunRack (It's "new" because it's designed to replace a previous version which needed a separate block ID for every possible gun.)

package net.minecraft.src;

import static net.minecraftforge.common.ForgeDirection.EAST;
import static net.minecraftforge.common.ForgeDirection.NORTH;
import static net.minecraftforge.common.ForgeDirection.SOUTH;
import static net.minecraftforge.common.ForgeDirection.WEST;

import java.util.Random;

import net.minecraft.client.Minecraft;

import cpw.mods.fml.common.Side;
import cpw.mods.fml.common.asm.SideOnly;

public class BlockNewGunRack extends BlockContainer {

int[] blockCoords = new int[3];

public BlockNewGunRack(int par1) {
	super(par1, Material.circuits);
	this.setCreativeTab(CreativeTabs.tabDeco);
}

@Override
public TileEntity createNewTileEntity(World wld) {
	return new TileEntityNewGunRack();
}
    
    public String getTextureFile(){
            return "/simpleguns/forgetest/LD/simpleguns.png";
    }
    
    public int getBlockTextureFromSide(int i){
    	World wld = Minecraft.getMinecraft().theWorld;
    	if(wld != null){
    		if(wld.getBlockTileEntity(blockCoords[0], blockCoords[1], blockCoords[2]) != null)
    			return ((TileEntityNewGunRack)wld.getBlockTileEntity(blockCoords[0], blockCoords[1], blockCoords[2])).texture;
    	}
    	return 128;
    }
    
    public int getBlockTexture(IBlockAccess wld, int par2, int par3, int par4, int par5)
    {
    	if(wld != null){
    		if((TileEntityNewGunRack)wld.getBlockTileEntity(par2, par3, par4) != null)
    			if(((TileEntityNewGunRack)wld.getBlockTileEntity(par2, par3, par4)).hasGun)
    				return ((TileEntityNewGunRack)wld.getBlockTileEntity(par2, par3, par4)).texture;
    	}
    	return 128;
    }
    
    public boolean onBlockActivated(World wld, int par2, int par3, int par4, EntityPlayer plr, int par6, float par7, float par8, float par9){
    	if(!wld.blockHasTileEntity(par2, par3, par4)) wld.setBlockTileEntity(par2, par3, par4, createNewTileEntity(wld));
    	if(((TileEntityNewGunRack)wld.getBlockTileEntity(par2, par3, par4)).dropGun(wld)) return true;
    	else if(plr.getCurrentEquippedItem() == null) return false;
    	else if(plr.getCurrentEquippedItem().getItem() instanceof ItemGun){
    		((ItemGun)plr.getCurrentEquippedItem().getItem()).placeOnGunRack(plr.getCurrentEquippedItem(), plr, wld, par2, par3, par4);
    		return true;
    	}
    	return false;
    }
    
    public void onBlockDestroyedByPlayer(World par1World, int par2, int par3, int par4, int par5) {
    	if(par1World.getBlockTileEntity(par2, par3, par4) != null){
    		TileEntityNewGunRack ent = (TileEntityNewGunRack)par1World.getBlockTileEntity(par2, par3, par4);
    		if(ent.hasGun) ent.dropGun(par1World);
    	}else System.out.println("No tile entity!");
    }

    public AxisAlignedBB getCollisionBoundingBoxFromPool(World par1World, int par2, int par3, int par4)
    {
        return null;
    }

    @SideOnly(Side.CLIENT)

    /**
     * Returns the bounding box of the wired rectangular prism to render.
     */
    public AxisAlignedBB getSelectedBoundingBoxFromPool(World par1World, int par2, int par3, int par4)
    {
        int var5 = par1World.getBlockMetadata(par2, par3, par4);
        float var6 = 0.125F;

        if (var5 == 2)
        {
            this.setBlockBounds(0.0F, 0.0F, 1.0F - var6, 1.0F, 1.0F, 1.0F);
        }

        if (var5 == 3)
        {
            this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 1.0F, var6);
        }

        if (var5 == 4)
        {
            this.setBlockBounds(1.0F - var6, 0.0F, 0.0F, 1.0F, 1.0F, 1.0F);
        }

        if (var5 == 5)
        {
            this.setBlockBounds(0.0F, 0.0F, 0.0F, var6, 1.0F, 1.0F);
        }

        return super.getSelectedBoundingBoxFromPool(par1World, par2, par3, par4);
    }

    /**
     * Is this block (a) opaque and (b) a full 1m cube?  This determines whether or not to render the shared face of two
     * adjacent blocks and also whether the player can attach torches, redstone wire, etc to this block.
     */
    public boolean isOpaqueCube()
    {
        return false;
    }

    /**
     * If this block doesn't render as an ordinary block it will return False (examples: signs, buttons, stairs, etc)
     */
    public boolean renderAsNormalBlock()
    {
        return false;
    }

    /**
     * The type of render function that is called for this block
     */
    public int getRenderType()
    {
        return ClientProxySG.GunRackRenderID;
    }

    /**
     * Checks to see if its valid to put this block at the specified coordinates. Args: world, x, y, z
     */
    public boolean canPlaceBlockAt(World par1World, int par2, int par3, int par4)
    {
        return par1World.isBlockSolidOnSide(par2 - 1, par3, par4, EAST ) ||
               par1World.isBlockSolidOnSide(par2 + 1, par3, par4, WEST ) ||
               par1World.isBlockSolidOnSide(par2, par3, par4 - 1, SOUTH) ||
               par1World.isBlockSolidOnSide(par2, par3, par4 + 1, NORTH);
    }

    /**
     * called before onBlockPlacedBy by ItemBlock and ItemReed
     */
    public void updateBlockMetadata(World par1World, int par2, int par3, int par4, int par5, float par6, float par7, float par8)
    {
        int var9 = par1World.getBlockMetadata(par2, par3, par4);

        if ((var9 == 0 || par5 == 2) && par1World.isBlockSolidOnSide(par2, par3, par4 + 1, NORTH))
        {
            var9 = 2;
        }

        if ((var9 == 0 || par5 == 3) && par1World.isBlockSolidOnSide(par2, par3, par4 - 1, SOUTH))
        {
            var9 = 3;
        }

        if ((var9 == 0 || par5 == 4) && par1World.isBlockSolidOnSide(par2 + 1, par3, par4, WEST))
        {
            var9 = 4;
        }

        if ((var9 == 0 || par5 == 5) && par1World.isBlockSolidOnSide(par2 - 1, par3, par4, EAST))
        {
            var9 = 5;
        }

        par1World.setBlockMetadataWithNotify(par2, par3, par4, var9);
    }

    /**
     * Lets the block know when one of its neighbor changes. Doesn't know which neighbor changed (coordinates passed are
     * their own) Args: x, y, z, neighbor blockID
     */
    public void onNeighborBlockChange(World par1World, int par2, int par3, int par4, int par5)
    {
        int var6 = par1World.getBlockMetadata(par2, par3, par4);
        boolean var7 = false;

        if (var6 == 2 && par1World.isBlockSolidOnSide(par2, par3, par4 + 1, NORTH))
        {
            var7 = true;
        }

        if (var6 == 3 && par1World.isBlockSolidOnSide(par2, par3, par4 - 1, SOUTH))
        {
            var7 = true;
        }

        if (var6 == 4 && par1World.isBlockSolidOnSide(par2 + 1, par3, par4, WEST))
        {
            var7 = true;
        }

        if (var6 == 5 && par1World.isBlockSolidOnSide(par2 - 1, par3, par4, EAST))
        {
            var7 = true;
        }

        if (!var7)
        {
            this.dropBlockAsItem(par1World, par2, par3, par4, var6, 0);
            par1World.setBlockWithNotify(par2, par3, par4, 0);
        }

        super.onNeighborBlockChange(par1World, par2, par3, par4, par5);
    }
    
    public void onBlockPlacedBy(World wld, int par2, int par3, int par4, EntityLiving par5EntityLiving) {
    	if(!this.hasTileEntity(wld.getBlockMetadata(par2, par3, par4))){
    		wld.setBlockTileEntity(par2, par3, par4, createNewTileEntity(wld));
    	}
    	blockCoords[0] = par2;
    	blockCoords[1] = par3;
    	blockCoords[2] = par4;
    }

    /**
     * Returns the quantity of items to drop on block destruction.
     */
    public int quantityDropped(Random par1Random)
    {
        return 1;
    }
    
    public int tickRate()
    {
        return 1;
    }

}

TileEntityNewGunRack:

package net.minecraft.src;

import cpw.mods.fml.common.Side;

public class TileEntityNewGunRack extends TileEntity{
public int id = 0; //Item ID of stored gun
public int texture = 128; //Texture to use for the gun rack
public int ammo = 0; //Ammo remaining in stored gun
public int[] enchantments = new int[4]; //Enchantment levels of stored gun
public boolean hasGun = false; //True is a gun is stored on this gun rack

public TileEntityNewGunRack(){

}

public void storeGun(World wld, ItemStack itm){
	id = itm.getItem().shiftedIndex;
	texture = itm.getIconIndex();
	ammo = itm.getItemDamage();
	enchantments[0] = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, itm);
	enchantments[1] = EnchantmentHelper.getEnchantmentLevel(Enchantment.punch.effectId, itm);
	enchantments[2] = EnchantmentHelper.getEnchantmentLevel(Enchantment.flame.effectId, itm);
	enchantments[3] = EnchantmentHelper.getEnchantmentLevel(Enchantment.infinity.effectId, itm);
	hasGun = true;
	wld.setBlockAndMetadataWithNotify(xCoord, yCoord, zCoord, SimpleGunsForge.gunrack.blockID, wld.getBlockMetadata(xCoord, yCoord, zCoord));
	wld.markBlockNeedsUpdate(xCoord, yCoord, zCoord);
}

public boolean dropGun(World wld){
	if(hasGun == false) return false;
	ItemStack itm = new ItemStack(id, 1, ammo);
	EntityItem ent = new EntityItem(wld, xCoord, yCoord, zCoord, itm);
	wld.spawnEntityInWorld(ent);
	id = 0;
	texture = 128;
	ammo = 0;
	enchantments[0] = 0;
	enchantments[1] = 0;
	enchantments[2] = 0;
	enchantments[3] = 0;
	hasGun = false;
	wld.setBlockAndMetadataWithNotify(xCoord, yCoord, zCoord, SimpleGunsForge.gunrack.blockID, wld.getBlockMetadata(xCoord, yCoord, zCoord));
	wld.markBlockNeedsUpdate(xCoord, yCoord, zCoord);
	return true;
}

public void writeToNBT(NBTTagCompound nbttagcompound)
    {
	super.writeToNBT(nbttagcompound);
	nbttagcompound.setBoolean("hasGun", hasGun);
	if(hasGun){
        nbttagcompound.setInteger("gunID", id);
        nbttagcompound.setInteger("ammoCount", ammo);
        nbttagcompound.setInteger("texture", texture);
        nbttagcompound.setInteger("power", enchantments[0]);
        nbttagcompound.setInteger("punch", enchantments[1]);
        nbttagcompound.setInteger("fire", enchantments[2]);
        nbttagcompound.setInteger("infinity", enchantments[3]);
	}
    }

public void readFromNBT(NBTTagCompound nbt)
    {
        super.readFromNBT(nbt);
        hasGun = nbt.getBoolean("hasGun");
        if(hasGun){
        id = nbt.getInteger("gunID");
        ammo = nbt.getInteger("ammoCount");
        texture = nbt.getInteger("texture");
		enchantments[0] = nbt.getInteger("power");
		enchantments[1] = nbt.getInteger("punch");
		enchantments[2] = nbt.getInteger("fire");
		enchantments[3] = nbt.getInteger("infinity");
        } else {
        	texture = 128;
        }
    }

public boolean canInteractWith(EntityPlayer entityplayer)
    {
        if(worldObj.getBlockTileEntity(xCoord, yCoord, zCoord) != this)
        {
            return false;
        }
        return entityplayer.getDistanceSq((double)xCoord + 0.5D, (double)yCoord + 0.5D, (double)zCoord + 0.5D) <= 64D;
    }
}

BlockRendererSG which has the code for this and any future custom block models I use.

package net.minecraft.src;

import cpw.mods.fml.client.registry.ISimpleBlockRenderingHandler;

public class BlockRendererSG implements ISimpleBlockRenderingHandler{
public BlockRendererSG(){

}

@Override
public void renderInventoryBlock(Block block, int metadata, int modelID, RenderBlocks renderer) {

}

@Override
public boolean renderWorldBlock(IBlockAccess world, int x, int y, int z, Block block, int modelId, RenderBlocks renderer) {
	if (modelId == ClientProxySG.GunRackRenderID){
		return renderBlockGunRack(block, x, y, z, renderer);
	}
	return false;
}

@Override
public boolean shouldRender3DInInventory() {
	// TODO Auto-generated method stub
	return false;
}

@Override
public int getRenderId() {
	// TODO Auto-generated method stub
	return 0;
}

private boolean renderBlockGunRack(Block block, int i, int j, int k, RenderBlocks renderblocks){
	Tessellator var5 = Tessellator.instance;
        int var6 = block.getBlockTexture(renderblocks.blockAccess, i, j, k, 0);
        if(renderblocks.blockAccess.getBlockTileEntity(i, j, k)!= null){
        	if(renderblocks.blockAccess.getBlockTileEntity(i, j, k) instanceof TileEntityNewGunRack){
        		var6 = ((TileEntityNewGunRack)renderblocks.blockAccess.getBlockTileEntity(i, j, k)).texture;
        	}
        }
        renderblocks.overrideBlockTexture = var6;
        var5.setBrightness(block.getMixedBrightnessForBlock(renderblocks.blockAccess, i, j, k));
        float var7 = 1.0F;
        var5.setColorOpaque_F(var7, var7, var7);
        int var22 = (var6 & 15) << 4;
        int var8 = var6 & 240;
        double var9 = (double)((float)var22 / 256.0F);
        double var11 = (double)(((float)var22 + 15.99F) / 256.0F);
        double var13 = (double)((float)var8 / 256.0F);
        double var15 = (double)(((float)var8 + 15.99F) / 256.0F);
        int var17 = renderblocks.blockAccess.getBlockMetadata(i, j, k);
        double var18 = 0.0D;
        double var20 = 0.05000000074505806D;

        if (var17 == 5)
        {
            var5.addVertexWithUV((double)i + var20, (double)(j + 1) + var18, (double)(k + 1) + var18, var9, var13);
            var5.addVertexWithUV((double)i + var20, (double)(j + 0) - var18, (double)(k + 1) + var18, var9, var15);
            var5.addVertexWithUV((double)i + var20, (double)(j + 0) - var18, (double)(k + 0) - var18, var11, var15);
            var5.addVertexWithUV((double)i + var20, (double)(j + 1) + var18, (double)(k + 0) - var18, var11, var13);
        }

        if (var17 == 4)
        {
            var5.addVertexWithUV((double)(i + 1) - var20, (double)(j + 0) - var18, (double)(k + 1) + var18, var11, var15);
            var5.addVertexWithUV((double)(i + 1) - var20, (double)(j + 1) + var18, (double)(k + 1) + var18, var11, var13);
            var5.addVertexWithUV((double)(i + 1) - var20, (double)(j + 1) + var18, (double)(k + 0) - var18, var9, var13);
            var5.addVertexWithUV((double)(i + 1) - var20, (double)(j + 0) - var18, (double)(k + 0) - var18, var9, var15);
        }

        if (var17 == 3)
        {
            var5.addVertexWithUV((double)(i + 1) + var18, (double)(j + 0) - var18, (double)k + var20, var11, var15);
            var5.addVertexWithUV((double)(i + 1) + var18, (double)(j + 1) + var18, (double)k + var20, var11, var13);
            var5.addVertexWithUV((double)(i + 0) - var18, (double)(j + 1) + var18, (double)k + var20, var9, var13);
            var5.addVertexWithUV((double)(i + 0) - var18, (double)(j + 0) - var18, (double)k + var20, var9, var15);
        }

        if (var17 == 2)
        {
            var5.addVertexWithUV((double)(i + 1) + var18, (double)(j + 1) + var18, (double)(k + 1) - var20, var9, var13);
            var5.addVertexWithUV((double)(i + 1) + var18, (double)(j + 0) - var18, (double)(k + 1) - var20, var9, var15);
            var5.addVertexWithUV((double)(i + 0) - var18, (double)(j + 0) - var18, (double)(k + 1) - var20, var11, var15);
            var5.addVertexWithUV((double)(i + 0) - var18, (double)(j + 1) + var18, (double)(k + 1) - var20, var11, var13);
        }

        return true;
    }

}

And, last but not least, the code used to add the model to the game. This is all the relevant parts of the client-side proxy; I've only removed some completely unrelated achievement descriptions and a bunch of commented methods left over from ModLoaderMP.

package net.minecraft.src;

import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;
import java.io.IOException;

import org.lwjgl.input.Mouse;

import cpw.mods.fml.client.modloader.ModLoaderBlockRendererHandler;
import cpw.mods.fml.client.registry.RenderingRegistry;
import cpw.mods.fml.common.Mod.Init;
import cpw.mods.fml.common.Side;
import cpw.mods.fml.common.registry.TickRegistry;
import net.minecraft.client.Minecraft;
import net.minecraftforge.client.MinecraftForgeClient;

public class ClientProxySG extends CommonProxySG {

public ClientProxySG(){
    	MinecraftForgeClient.preloadTexture("/simpleguns/forgetest/LD/simpleguns.png");
    	TickRegistry.registerTickHandler(new ClientTickHandlerSG(), Side.CLIENT);
}

public void registerRenderInformation(){
	RenderingRegistry.registerEntityRenderingHandler(EntitySGBullet.class, new RenderSGBullet(0.5F));
	GunRackRenderID = RenderingRegistry.getNextAvailableRenderId();
	RenderingRegistry.registerBlockHandler(GunRackRenderID, new BlockRendererSG());
}
}

LexManos · August 20, 2012

use setTextureFile

Don't override getTextureFile.

Also, multiple calls to getTileEntity is costly, cache its result.

And you are not reverting the texture override. You need to just call Forge's beforeBlockRender and afterBlockRender to have it setup the Tessellator properly.

nerdboy64 · August 20, 2012

Changing to setTextureFile and removing override code for getTextureFile: Check.

Lowering number of calls to getTileEntity: Check.

Implementing beforeBlockRender and afterBlockRender: Check, unless I did it wrong. I just put those at the beginning and end of my renderWorldBlock() method, right? Like this:

public boolean renderWorldBlock(IBlockAccess world, int x, int y, int z, Block block, int modelId, RenderBlocks renderer) {
	ForgeHooksClient.beforeBlockRender(block, renderer);
	if (modelId == ClientProxySG.GunRackRenderID){
		return renderBlockGunRack(block, x, y, z, renderer);
	}
	return false;
}

public boolean renderBlockGunRack(Block block, int i, int j, int k, RenderBlocks renderblocks){
	//if(block.getRenderType() == ClientProxySG.GunRackRenderID){
		Tessellator var5 = Tessellator.instance;
        //int var6 = block.getBlockTexture(renderblocks.blockAccess, i, j, k, 0);
		int var6 = 128;
		TileEntityNewGunRack ent = (TileEntityNewGunRack) renderblocks.blockAccess.getBlockTileEntity(i, j, k);
        if(ent != null) var6 = ((TileEntityNewGunRack)renderblocks.blockAccess.getBlockTileEntity(i, j, k)).texture;
        renderblocks.overrideBlockTexture = var6;
        var5.setBrightness(block.getMixedBrightnessForBlock(renderblocks.blockAccess, i, j, k));
        float var7 = 1.0F;
        var5.setColorOpaque_F(var7, var7, var7);
        int var22 = (var6 & 15) << 4;
        int var8 = var6 & 240;
        double var9 = (double)((float)var22 / 256.0F);
        double var11 = (double)(((float)var22 + 15.99F) / 256.0F);
        double var13 = (double)((float)var8 / 256.0F);
        double var15 = (double)(((float)var8 + 15.99F) / 256.0F);
        int var17 = renderblocks.blockAccess.getBlockMetadata(i, j, k);
        double var18 = 0.0D;
        double var20 = 0.05000000074505806D;
        ForgeHooksClient.afterBlockRender(block, renderblocks);

        if (var17 == 5)
        {
            var5.addVertexWithUV((double)i + var20, (double)(j + 1) + var18, (double)(k + 1) + var18, var9, var13);
            var5.addVertexWithUV((double)i + var20, (double)(j + 0) - var18, (double)(k + 1) + var18, var9, var15);
            var5.addVertexWithUV((double)i + var20, (double)(j + 0) - var18, (double)(k + 0) - var18, var11, var15);
            var5.addVertexWithUV((double)i + var20, (double)(j + 1) + var18, (double)(k + 0) - var18, var11, var13);
        }

        if (var17 == 4)
        {
            var5.addVertexWithUV((double)(i + 1) - var20, (double)(j + 0) - var18, (double)(k + 1) + var18, var11, var15);
            var5.addVertexWithUV((double)(i + 1) - var20, (double)(j + 1) + var18, (double)(k + 1) + var18, var11, var13);
            var5.addVertexWithUV((double)(i + 1) - var20, (double)(j + 1) + var18, (double)(k + 0) - var18, var9, var13);
            var5.addVertexWithUV((double)(i + 1) - var20, (double)(j + 0) - var18, (double)(k + 0) - var18, var9, var15);
        }

        if (var17 == 3)
        {
            var5.addVertexWithUV((double)(i + 1) + var18, (double)(j + 0) - var18, (double)k + var20, var11, var15);
            var5.addVertexWithUV((double)(i + 1) + var18, (double)(j + 1) + var18, (double)k + var20, var11, var13);
            var5.addVertexWithUV((double)(i + 0) - var18, (double)(j + 1) + var18, (double)k + var20, var9, var13);
            var5.addVertexWithUV((double)(i + 0) - var18, (double)(j + 0) - var18, (double)k + var20, var9, var15);
        }

        if (var17 == 2)
        {
            var5.addVertexWithUV((double)(i + 1) + var18, (double)(j + 1) + var18, (double)(k + 1) - var20, var9, var13);
            var5.addVertexWithUV((double)(i + 1) + var18, (double)(j + 0) - var18, (double)(k + 1) - var20, var9, var15);
            var5.addVertexWithUV((double)(i + 0) - var18, (double)(j + 0) - var18, (double)(k + 1) - var20, var11, var15);
            var5.addVertexWithUV((double)(i + 0) - var18, (double)(j + 1) + var18, (double)(k + 1) - var20, var11, var13);
        }
	//}
        return true;
    }

So far, the result is the same.

nerdboy64 · August 20, 2012

Upon closer inspection of afterBlockRender, I discovered that overrideBlockTexture must be -1 for it to work. Added that at the end of renderBlockGunRack and it worked.

LexManos · August 20, 2012

Just a note, your whole override texture is useless.

Don't use it.

Also, you should really rename your variables it makes it less obvious that you just copy/pasted decompiled code.

Sign In

[SOLVED] Really weird rendering bug

Recommended Posts

nerdboy64

LexManos

nerdboy64

nerdboy64

LexManos

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information