Biome too...watery

[DanilaFE]

I want it to be more like a forest biome, flat with less water. How would I do that?

[Draco18s]

Send me your code for that now, I want.

 

(More specifically, it's almost exactly like a world generator a bunch of people would like to see in Mystcraft)

[DanilaFE]

Actually, I kinda figured it out. The biome had so much water because the biome height was far below sea level. I brought it up a bit and it works.

[Draco18s]

I still want your original, "failed" code.  It looked awesome in its own way.

[Mazetar]

Was the only change you did between the first and second post screenshots changing the biome height?

or did you change other stuff too?

[DanilaFE]

Was the only change you did between the first and second post screenshots changing the biome height?

or did you change other stuff too?

Funny, just the biome height. Honestly, I wasn't even expecting the dimension to load, I have barely done anything in the chunk provider. Like seriously, five lines of code or so. 

Initiating the biome

frozenBiome = new BiomeGenFrozen(45).setBiomeName("frozenBiome").setEnableSnow().setMinMaxHeight(0.3F, 1F).setTemperatureRainfall(0.3F, 0.5F);

Dimension stuff

    DimensionManager.registerProviderType(FrozenDimensionID, FrozenProvider.class, false);
            DimensionManager.registerDimension(FrozenDimensionID, FrozenDimensionID); 

Biome class

	public BiomeGenFrozen(int id) {
	super(id);
	// TODO Auto-generated constructor stub
	this.topBlock = (byte)FrozenWorld.FrozenBiomeDirt.blockID;
	this.spawnableCaveCreatureList.removeAll(spawnableCaveCreatureList);
	this.spawnableMonsterList.removeAll(spawnableMonsterList);
	this.spawnableWaterCreatureList.removeAll(spawnableWaterCreatureList);
	this.spawnableCreatureList.removeAll(spawnableCreatureList);
//Removing all mobs because I was going to replace them. I need all my mobs to do something similar
//to the ones in the overworld, but a bit different so I will make new ones extending the originals.
}

}

Provider

public class FrozenProvider extends WorldProvider{

public void registerWorldChunkManager(){
	this.worldChunkMgr = new WorldChunkManagerHell(FrozenWorld.frozenBiome, 0.2F, 1); 
	this.dimensionId = FrozenWorld.FrozenDimensionID;
}

public IChunkProvider createChunkProvider(){
	return new ChunkProviderFrozen(this.worldObj, this.worldObj.getSeed(), true);

}

public String getDimensionName() {
	// TODO Auto-generated method stub
	return "Frozen Dimension";
}

}

Chunk provider. As I said, very, very empty. I'm just barely learning how to do this.

public class ChunkProviderFrozen implements IChunkProvider {
private Random rand;
private World worldobj;
private final boolean mapFeaturesEnabled;
private double[] NoiseArray;
private double[] StoneNoiseArray = new double[256];
private MapGenBase caveGenerator = new MapGenCaves();
private MapGenScatteredFeature ScatteredFeatureGen = new MapGenScatteredFeature();
private BiomeGenBase[] biomesForGen;
{
caveGenerator = TerrainGen.getModdedMapGen(caveGenerator, EventType.CAVE);
ScatteredFeatureGen = (MapGenScatteredFeature) TerrainGen.getModdedMapGen(ScatteredFeatureGen, EventType.SCATTERED_FEATURE);
}
public ChunkProviderFrozen(World worldObj, long seed, boolean b) {
	mapFeaturesEnabled = b;
	worldobj = worldObj;
	this.rand = new Random(seed);
}


public boolean chunkExists(int i, int j) {
	// TODO Auto-generated method stub
	return false;
}


public Chunk provideChunk(int i, int j) {
	// TODO Auto-generated method stub
	return null;
}


public Chunk loadChunk(int i, int j) {
	// TODO Auto-generated method stub
	return null;
}


public void populate(IChunkProvider ichunkprovider, int i, int j) {
int k = i * 16;
int l = j *16;
BiomeGenBase biome = this.worldobj.getBiomeGenForCoords(k+16, l + 16);
this.rand.setSeed(this.worldobj.getSeed());
long i1 = this.rand.nextLong() / 2L * 2L + 1L;
long j1 = this.rand.nextLong() / 2L * 2L + 1L;
this.rand.setSeed((long)i * i1 + j * j1);
boolean flag = false;
MinecraftForge.EVENT_BUS.post(new PopulateChunkEvent.Pre(ichunkprovider, worldobj, rand, i, j, flag));
if(mapFeaturesEnabled){
	this.ScatteredFeatureGen.generateStructuresInChunk(worldobj, rand, i, j);
}
//int k1;
//int l1;
//int m1;
//Unused code, WIP

}


public boolean saveChunks(boolean flag, IProgressUpdate iprogressupdate) {
	// TODO Auto-generated method stub
	return false;
}


public boolean unloadQueuedChunks() {
	// TODO Auto-generated method stub
	return false;
}


public boolean canSave() {
	// TODO Auto-generated method stub
	return false;
}


public String makeString() {
	// TODO Auto-generated method stub
	return null;
}


public List getPossibleCreatures(EnumCreatureType enumcreaturetype, int i,
		int j, int k) {
	// TODO Auto-generated method stub
	return null;
}


public ChunkPosition findClosestStructure(World world, String s, int i,
		int j, int k) {
	// TODO Auto-generated method stub
	return null;
}


public int getLoadedChunkCount() {
	// TODO Auto-generated method stub
	return 0;
}


public void recreateStructures(int i, int j) {
	// TODO Auto-generated method stub

}


public void saveExtraData() {
	// TODO Auto-generated method stub

}

}

[Draco18s]

I'll see if I can use that at some point to provide an "archipelago" type landscape for Mystcraft worlds.  I ventured into the worldgenerator code at one point to see what I could screw with and get the kind of look I wanted (to no success) and then here you come along and have exactly what I want without having done hardly anything (and don't want the result yourself).

 

Thanks.

[Dklory]

Great biomee!!

[zakerunner]

Sorry to hijack the thread, but I'm trying to learn to mod in a handful of new biomes. How did you learn to implement that frozen biome? Or did you just delve into the code to find out yourself?

[DanilaFE]

You're not hijacking anything, friend. If you look at my earlier post it has all the code I used for the biome - just creating it and registering the biome adds it to the world (as far as it worked for me)Ignore the chunk and dimension providers, those are for the dimension. Look at FrozenBiome and the main class. It's also quite annoying because I have my own biome that is supposed to be dimension-specific spawn in the overworld.

 

Happy modding!