Jump to content

Recommended Posts

Posted

So this is my world gen everything seems to look fine but it doenst work it generates altars trees and such but it only generates them in deserts.

When it does generates it generates around 10 trees perchuck and i can't seem to find out what i'm doing wrong help please

 

 

import java.util.Random;

 

import net.minecraft.world.World;

import net.minecraft.world.chunk.IChunkProvider;

 

 

import cpw.mods.fml.common.IWorldGenerator;

import cpw.mods.fml.common.registry.GameRegistry;

 

public class WorldGeneratorTrees implements IWorldGenerator {

 

public WorldGeneratorTrees() {

GameRegistry.registerWorldGenerator(this);

}

 

@SuppressWarnings("static-access")

@Override

public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {

if(!(world.getWorldInfo().getTerrainType() == world.getWorldInfo().getTerrainType().FLAT)){

generateBigTree(world, random, chunkX, chunkZ);

generateAltar(world, random, chunkX, chunkZ);

generateOtherTree(world, random, chunkX, chunkZ);

for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(32);

        int z = chunkZ + random.nextInt(32);

        int y = world.getHeightValue(x, z);

        new WorldGenTeak().generate(world, random, x, y, z);

    }

 

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(32);

        int z = chunkZ + random.nextInt(32);

        int y = world.getHeightValue(x, z);

        new WorldGenHollow().generate(world, random, x, y, z);

    }

   

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(32);

        int z = chunkZ + random.nextInt(32);

        int y = world.getHeightValue(x, z);

        new WorldGenWillow().generate(world, random, x, y, z);

    }

}

}

public static void generateAltar(World world, Random random, int chunkX, int chunkZ)

    {

 

  for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(32);

        int z = chunkZ + random.nextInt(32);

        int y = world.getHeightValue(x, z);

        new EssenceMine().generate(world, random, x, y, z);

    }

 

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(128);

        int z = chunkZ + random.nextInt(128);

        int y = world.getHeightValue(x, z);

        new WorldGenAltarAir().generate(world, random, x, y, z);

    }

    }

public static void generateOtherTree(World world, Random random, int chunkX, int chunkZ)

    {

 

  for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(32);

        int z = chunkZ + random.nextInt(32);

        int y = world.getHeightValue(x, z);

        new WorldGenTeak().generate(world, random, x, y, z);

    }

 

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(32);

        int z = chunkZ + random.nextInt(32);

        int y = world.getHeightValue(x, z);

        new WorldGenHollow().generate(world, random, x, y, z);

    }

   

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(32);

        int z = chunkZ + random.nextInt(32);

        int y = world.getHeightValue(x, z);

        new WorldGenWillow().generate(world, random, x, y, z);

    }

    }

    public static void generateBigTree(World world, Random random, int chunkX, int chunkZ)

    {

   

    //normaal

for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(128);

        int z = chunkZ + random.nextInt(128);

        int y = world.getHeightValue(x, z);

new WorldGenTree(false, 5, 0, 0, false, WoodCutting.woodcuttingleaves.blockID, WoodCutting.woodcuttinglog.blockID).generate(world, random, x, y, z);

}

 

//oak

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(64);

        int z = chunkZ + random.nextInt(64);

        int y = world.getHeightValue(x, z);

        int meta = 2;

        new WorldGenBigTree(true, WoodCutting.woodcuttinglog.blockID, meta, WoodCutting.woodcuttingleaves.blockID, meta).generate(world, random, x, y, z);

    }

   

    //yew

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(128);

        int z = chunkZ + random.nextInt(128);

        int y = world.getHeightValue(x, z);

        int meta = 9;

        new WorldGenBigTree(true, WoodCutting.woodcuttinglog.blockID, meta, WoodCutting.woodcuttingleaves.blockID, meta).generate(world, random, x, y, z);

    }

   

    //mahogany

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(32);

        int z = chunkZ + random.nextInt(32);

        int y = world.getHeightValue(x, z);

        int meta = 7;

        new WorldGenBigTree(true, WoodCutting.woodcuttinglog.blockID, meta, WoodCutting.woodcuttingleaves.blockID, meta).generate(world, random, x, y, z);

    }

   

    //maple

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(32);

        int z = chunkZ + random.nextInt(32);

        int y = world.getHeightValue(x, z);

        int meta = 5;

        new WorldGenBigTree(true, WoodCutting.woodcuttinglog.blockID, meta, WoodCutting.woodcuttingleaves.blockID, meta).generate(world, random, x, y, z);

    }

    }

}

 

I'm always happy to help others!

 

Java is not my main programming language but I have alot experience in PHP/HTML/JS/CSS3/C#/SQL

Posted

Not sure about your desert problem. Maybe the problem is in one of the other World Gen files.

 

When you use .nextInt though Im pretty sure you want the upper limit to always be 16 so it only spawns into that chunk.

Posted
  On 12/28/2013 at 2:50 PM, CJLetsGame said:

When you use .nextInt though Im pretty sure you want the upper limit to always be 16 so it only spawns into that chunk.

 

Just to clarify this portion.

He's talking about these lines:

 int x = chunkX + random.nextInt(32);
int z = chunkZ + random.nextInt(32);

You shouldn't generate a value higher than 15 with your random, or you're not generating inside that chunk, you're generating in a neighboring chunk.

And while you can, you shouldn't.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Okay well thanks i'll change all the values to 16 to test it again hold on

I'm always happy to help others!

 

Java is not my main programming language but I have alot experience in PHP/HTML/JS/CSS3/C#/SQL

Posted

Nothing seems to generate now.

 

 

public WorldGeneratorTrees() {

GameRegistry.registerWorldGenerator(this);

}

 

@SuppressWarnings("static-access")

@Override

public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {

if(!(world.getWorldInfo().getTerrainType() == world.getWorldInfo().getTerrainType().FLAT)){

generateBigTree(world, random, chunkX, chunkZ);

generateAltar(world, random, chunkX, chunkZ);

generateOtherTree(world, random, chunkX, chunkZ);

for(int i = 0; i < 15; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        new WorldGenTeak().generate(world, random, x, y, z);

    }

 

    for(int i = 0; i < 15; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        new WorldGenHollow().generate(world, random, x, y, z);

    }

   

    for(int i = 0; i < 15; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        new WorldGenWillow().generate(world, random, x, y, z);

    }

}

}

public static void generateAltar(World world, Random random, int chunkX, int chunkZ)

    {

 

  for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        new EssenceMine().generate(world, random, x, y, z);

    }

 

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        new WorldGenAltarAir().generate(world, random, x, y, z);

    }

    }

public static void generateOtherTree(World world, Random random, int chunkX, int chunkZ)

    {

 

  for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        new WorldGenTeak().generate(world, random, x, y, z);

    }

 

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        new WorldGenHollow().generate(world, random, x, y, z);

    }

   

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        new WorldGenWillow().generate(world, random, x, y, z);

    }

    }

    public static void generateBigTree(World world, Random random, int chunkX, int chunkZ)

    {

   

    //normaal

for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

new WorldGenTree(false, 5, 0, 0, false, WoodCutting.woodcuttingleaves.blockID, WoodCutting.woodcuttinglog.blockID).generate(world, random, x, y, z);

}

 

//oak

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        int meta = 2;

        new WorldGenBigTree(true, WoodCutting.woodcuttinglog.blockID, meta, WoodCutting.woodcuttingleaves.blockID, meta).generate(world, random, x, y, z);

    }

   

    //yew

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        int meta = 9;

        new WorldGenBigTree(true, WoodCutting.woodcuttinglog.blockID, meta, WoodCutting.woodcuttingleaves.blockID, meta).generate(world, random, x, y, z);

    }

   

    //mahogany

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        int meta = 7;

        new WorldGenBigTree(true, WoodCutting.woodcuttinglog.blockID, meta, WoodCutting.woodcuttingleaves.blockID, meta).generate(world, random, x, y, z);

    }

   

    //maple

    for(int i = 0; i < 1; i++){

        int x = chunkX + random.nextInt(16);

        int z = chunkZ + random.nextInt(16);

        int y = world.getHeightValue(x, z);

        int meta = 5;

        new WorldGenBigTree(true, WoodCutting.woodcuttinglog.blockID, meta, WoodCutting.woodcuttingleaves.blockID, meta).generate(world, random, x, y, z);

    }

    }

}

 

on the models so they should spawn normally

protected int[] GetValidSpawnBlocks() {

return new int[] {

Block.grass.blockID,

Block.dirt.blockID

};

}

 

I'm always happy to help others!

 

Java is not my main programming language but I have alot experience in PHP/HTML/JS/CSS3/C#/SQL

Posted

You need to multiply chunkX and chunkZ by 16, as they are chunk coordinates, not world coordinates.

 

int x = chunkX*16 + random.nextInt(16);

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • https://mclo.gs/9y5ciD2 anyone ever had this issue?  Internal exception illegal argument exception: unable to fit 3194354 into 3
    • Hoffman Law Recovery helped me recovered my lost funds
    • Hi! I'm trying to add my custom models/textures renderer like this: public class PonyPlayerWrapperRenderer extends EntityRenderer<Player> { // wrapper class under my LivingEntityRenderer class implementation private final PonyPlayerRenderer innerRenderer; private final PonyPlayerRenderer innerSlimRenderer; public PonyPlayerWrapperRenderer(final EntityRendererProvider.Context context) { super(context); System.out.println("creating new PonyPlayerWrapperRenderer"); this.innerRenderer = new PonyPlayerRenderer(context, false); this.innerSlimRenderer = new PonyPlayerRenderer(context, true); } @Override public void render(final Player entity, final float yaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource bufferSource, final int packedLight) { System.out.println("PonyPlayerWrapperRenderer render: " + entity.toString()); if (entity instanceof AbstractClientPlayer clientPlayer) { if (clientPlayer.getModelName().contains("slim")) { innerSlimRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } else { innerRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } } } @Override public ResourceLocation getTextureLocation(final Player player) { System.out.println("PonyPlayerWrapperRenderer getTextureLocation"); if (player instanceof AbstractClientPlayer clientPlayer) { return clientPlayer.getSkinTextureLocation(); } System.out.println("player instanceof AbstractClientPlayer is false"); return getDefaultSkin(player.getUUID()); } } public class PonyPlayerRenderer extends LivingEntityRenderer<AbstractClientPlayer, PlayerModel<AbstractClientPlayer>> { private final PlayerModel<AbstractClientPlayer> earthModel; private final PlayerModel<AbstractClientPlayer> pegasusModel; private final PlayerModel<AbstractClientPlayer> unicornModel; public PonyPlayerRenderer(final EntityRendererProvider.Context context, final boolean slim) { super( context, slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)), 0.5f ); System.out.println("creating new PonyPlayerRenderer"); this.earthModel = slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); this.pegasusModel = new PegasusModel(context.bakeLayer(PegasusModel.LAYER_LOCATION)); this.unicornModel = new UnicornModel(context.bakeLayer(UnicornModel.LAYER_LOCATION)); } @Override public void render(final AbstractClientPlayer player, final float entityYaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource buffer, final int packedLight) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); this.model = switch (race) { case PEGASUS -> pegasusModel; case UNICORN -> unicornModel; case EARTH -> earthModel; }; super.render(player, entityYaw, partialTicks, poseStack, buffer, packedLight); } @Override public ResourceLocation getTextureLocation(final AbstractClientPlayer player) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); return switch (race) { case EARTH -> fromNamespaceAndPath(MODID, "textures/entity/earth_pony.png"); case PEGASUS -> fromNamespaceAndPath(MODID, "textures/entity/pegasus.png"); case UNICORN -> fromNamespaceAndPath(MODID, "textures/entity/unicorn.png"); }; } } @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { // mod bus render registration config @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onRegisterRenderers(final EntityRenderersEvent.RegisterRenderers event) { event.registerEntityRenderer(EntityType.PLAYER, PonyPlayerWrapperRenderer::new); System.out.println("onRegisterRenderers end"); } } Method onRegisterRenderers() is called and I can see it being logged. But when I enter the world, my PonyWrapperRenderer render() method doesn't ever seem to be called. I also tried to put my renderer to EntityRenderDispatcher's playerRenderers via reflection: @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onClientSetup(final FMLClientSetupEvent event) { event.enqueueWork(() -> { try { final EntityRenderDispatcher dispatcher = Minecraft.getInstance().getEntityRenderDispatcher(); final Field renderersField = getEntityRenderDispatcherField("playerRenderers"); final Field itemInHandRenderer = getEntityRenderDispatcherField("itemInHandRenderer"); @SuppressWarnings("unchecked") final Map<String, EntityRenderer<? extends Player>> playerRenderers = (Map<String, EntityRenderer<? extends Player>>)renderersField.get(dispatcher); final PonyPlayerWrapperRenderer renderer = new PonyPlayerWrapperRenderer( new EntityRendererProvider.Context( dispatcher, Minecraft.getInstance().getItemRenderer(), Minecraft.getInstance().getBlockRenderer(), (ItemInHandRenderer)itemInHandRenderer.get(dispatcher), Minecraft.getInstance().getResourceManager(), Minecraft.getInstance().getEntityModels(), Minecraft.getInstance().font ) ); playerRenderers.put("default", renderer); playerRenderers.put("slim", renderer); System.out.println("Player renderers replaced"); } catch (final Exception e) { throw new RuntimeException("Failed to replace player renderers", e); } }); } private static Field getEntityRenderDispatcherField(final String fieldName) throws NoSuchFieldException { final Field field = EntityRenderDispatcher.class.getDeclaredField(fieldName); field.setAccessible(true); return field; } } But I receive the error before Minecraft Client appears (RuntimeException: Failed to replace player renderers - from ClientRenderers onClientSetup() method - and its cause below): java.lang.IllegalArgumentException: No model for layer anotherlittlepony:earth_pony#main at net.minecraft.client.model.geom.EntityModelSet.bakeLayer(EntityModelSet.java:18) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.EntityRendererProvider$Context.bakeLayer(EntityRendererProvider.java:69) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerRenderer.<init>(PonyPlayerRenderer.java:32) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerWrapperRenderer.<init>(PonyPlayerWrapperRenderer.java:24) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.ClientRenderers.lambda$onClientSetup$0(ClientRenderers.java:79) ~[main/:?] {re:classloading} ... 33 more Problem appears when EntityRendererProvider context tries to bakeLayer with my model layer location: new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); // PonyPlayerRenderer.java:32 public class PonyModel extends PlayerModel<AbstractClientPlayer> { // the model class itself public static final ModelLayerLocation LAYER_LOCATION = new ModelLayerLocation( ResourceLocation.fromNamespaceAndPath(MODID, "earth_pony"), "main" ); public PonyModel(final ModelPart root) { super(root, false); } public static LayerDefinition createBodyLayer() { // some CubeListBuilder stuff for model appearance } } Textures PNGs are placed at: resources/assets/[my mod id]/textures/entity. My forge version is 1.20.1. Would appreciate any help.
    • Well, a bit more information about what you're trying to do would be helpful. e.g. why you're trying to use "INVOKE_ASSIGN" instead of "INVOKE". "INVOKE_ASSIGN" calls your code after the "target" is called and its value is stored, if applicable. "INVOKE" calls your code before the target is called. "target" expects a fully qualified name, as per the SpongePowered docs, if that name is going to be remapped (which it will be if your injecting into Minecraft itself and not another mod). For more information on fully qualified names versus canonical names, see the Java specifications. Here's an example of a working "@At" from my own code that targets the "getClosestsVulnerablePlayerToEntity" call inside a mob's logic: @At(value = "INVOKE_ASSIGN", target = "net.minecraft.world.World.getClosestVulnerablePlayerToEntity(Lnet/minecraft/entity/Entity;D)Lnet/minecraft/entity/player/EntityPlayer;") Hope this helps!
    • Ran it one more time just to check, and there's no errors this time on the log??? Log : https://mclo.gs/LnuaAiu I tried allocating more memory to the modpack, around 8000MB and it's still the same; stopping at "LOAD_REGISTRIES". Are some of the mods clashing, maybe? I have no clue what to do LOL
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.