Do action on client player LivingDeathEvent

[Naamah]

Hello, I've been trying to get this to work forever. I have some code that gives an item when a player joins and I've been using that as a base, but it hasn't been working.

This is my current code:

@SubscribeEvent
    public void playerKilled(LivingDeathEvent event){
        if (event.getEntity() instanceof Player && !event.getEntity().isDeadOrDying()) {
            Player player = (Player) event.getEntity();
            if (player.getInventory().contains(new ItemStack(ModItems.FIRE_PROTECTION_POPPET.get()))) {
                player.getInventory().removeItem(new ItemStack(ModItems.FIRE_PROTECTION_POPPET.get()));
            }
        }
    }

In a sense, I am trying to "use up" the item when the player dies without them literally dying (like the totem of undying). I'm not exactly sure how to check the way the totem of undying works, but any tips would be appreciated.

[sfxprt2]

14 hours ago, Naamah said:

Hello, I've been trying to get this to work forever. I have some code that gives an item when a player joins and I've been using that as a base, but it hasn't been working.

This is my current code:

@SubscribeEvent
    public void playerKilled(LivingDeathEvent event){
        if (event.getEntity() instanceof Player && !event.getEntity().isDeadOrDying()) {
            Player player = (Player) event.getEntity();
            if (player.getInventory().contains(new ItemStack(ModItems.FIRE_PROTECTION_POPPET.get()))) {
                player.getInventory().removeItem(new ItemStack(ModItems.FIRE_PROTECTION_POPPET.get()));
            }
        }
    }

In a sense, I am trying to "use up" the item when the player dies without them literally dying (like the totem of undying). I'm not exactly sure how to check the way the totem of undying works, but any tips would be appreciated.

when you say that it isnt working what specifically isnt working because you are now talking about remaking totem of undying for your custom item. Im going to assume you are wondering how to make your player not die. Just cancel the event. You can read the docs on LivingDeathEvent here

for future reference, you need to look up the class in your IDE. For IntelliJ its Ctrl+N

[Naamah]

14 hours ago, sfxprt2 said:

when you say that it isnt working what specifically isnt working because you are now talking about remaking totem of undying for your custom item. Im going to assume you are wondering how to make your player not die. Just cancel the event. You can read the docs on LivingDeathEvent here

for future reference, you need to look up the class in your IDE. For IntelliJ its Ctrl+N

Thanks for the response. I ended up going with this:
 

public class PlayerDeathHandler {

    @SubscribeEvent
    public void playerKilled(LivingDeathEvent event) {
        if (event.getEntity() instanceof Player player) {
            ItemStack poppetStack = new ItemStack(ModItems.DEATH_PROTECTION_POPPET.get());

            if (player.getInventory().contains(poppetStack)) {
                event.setCanceled(true);
                
                player.setHealth(player.getMaxHealth());
                
                for (int i = 0; i < player.getInventory().getContainerSize(); i++) {
                    ItemStack stackInSlot = player.getInventory().getItem(i);
                    if (stackInSlot.getItem() == poppetStack.getItem()) {
                        stackInSlot.shrink(1);
                        if (stackInSlot.isEmpty()) {
                            player.getInventory().setItem(i, ItemStack.EMPTY);
                        }
                        break;
                    }
                }
            }
        }
    }
}

It works like a charm, but are there any issues that COULD arise using this? I don't have much experience with Forge, so I'm not sure about the common issues and whatnot.

Edited May 29 by Naamah