Jump to content

Recommended Posts

Posted

Hi all

 

Over the past month I've noticed that the biggest thing holding up progress on the change to 1.7.2 seems to be the deobfuscation of the names.  The folks at MCP are obviously very busy, but it seems to me that they've done the hard work already weeks ago, i.e. decompiling the source and making it compile.  The deobfuscation is the easy part, it's something that the hundreds of us out here could do in a couple of days.

 

So the idea is basically - can we somehow use the gradle setup to apply deobfuscation that we have supplied ourselves (instead of needing an official MCP release)?  in a text file, or from a minecraft forum web database, or whatever? 

Perhaps this looks something like -

(1) the cached forge and minecraft source all use searge names;

(2) at the start of a session, the deobfuscation "patch" is updated (from wherever) and creates a deobfuscated copy of the cached forge and minecraft sources

(3) ideally, there is some sort of mechanism so that user source code can use either searge or deobfuscated names without conflict - so that when the names are updated, the user source code doesn't break.

 

Even the ability to create a deobfuscation patch for my own use would be nice, rather than having to use the searge names even though I know what the deobfuscated name is.

 

I know next to nothing about how the deobfuscation currently works, and not much more about gradle.  But it sounds "so simple", is there a good reason why this wouldn't work?  (Apart from needing a deobfuscation database separate from MCPbot, and some sort of quality control checking)

 

-TGG

Posted

We are working on it, however, it's going slow due to very low motivation/respect form the community -.-

Howerver, you can keep an eye on things on Abrar's Git, where it's being developed. https://github.com/AbrarSyed/Srg2Source

We need some testing and integration code written up. Once this is functional, we will have the MCP mappings snapshotted so that the end modder can pick what snapshot they want to mod against.

 

It'll happen, eventually, Hopefully it'll be officially rolled out in the 1.7.4 update and the RB, but I need to get on fluids as well..

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Ah, it appears I spoke too soon, I still need a little help here. I now have the forceloading working reliably.  However, I've realized it's not always the first tick that loads the entity.  I've seen it take anywhere from 2-20ish to actually go through, in which time my debugging has revealed that the chunk is loaded, but during which time calling  serverLevelIn.getEntity(uuidIn) returns a null result.  I suspect this has to do with queuing and how entities are loaded into the game.  While not optimal, it's acceptable, and I don't think there's a whole ton I can do to avoid it. However, my concern is that occasionally teleporting an entity in this manner causes a lag spike.  It's not every time and gives the appearance of being correlated with when other chunks are loading in.  It's also not typically a long spike, but can last a second or two, which is less than ideal.  The gist of how I'm summoning is here (although I've omitted some parts that weren't relevant.  The lag occurs before the actual summon so I'm pretty confident it's the loading, and not the actual summon call). ChunkPos chunkPos = new ChunkPos(entityPosIn); if (serverLevelIn.areEntitiesLoaded(chunkPos.toLong())) { boolean isSummoned = // The method I'm using for actual summoning is called here. Apart from a few checks, the bulk of it is shown later on. if (isSummoned) { // Code that runs here just notifies the player of the summon, clears it from the queue, and removes the forceload } } else { // I continue forcing the chunk until the summon succeeds, to make sure it isn't inadvertently cleared ForgeChunkManager.forceChunk(serverLevelIn, MODID, summonPosIn, chunkPos.x, chunkPos.z, true, true); } The summon code itself uses serverLevelIn.getEntity(uuidIn) to retrieve the entity, and moves it as such.  It is then moved thusly: if (entity.isAlive()) { entity.moveTo(posIn.getX(), posIn.getY(), posIn.getZ()); serverLevelIn.playSound(null, entity, SoundEvents.ENDERMAN_TELEPORT, SoundSource.NEUTRAL, 1.0F, 1.0F); return true; } I originally was calling .getEntity() more frequently and didn't have the check for whether or not entities were loaded in place to prevent unnecessary code calls, but even with those safety measures in place, the lag still persists.  Could this just be an issue with 1.18's lack of optimization in certain areas?  Is there anything I can do to mitigate it?  Is there a performance boosting mod I could recommend alongside my own to reduce the chunk loading lag? At the end of the day, it does work, and I'm putting measures in place to prevent players from abusing the system to cause lag (i.e. each player can only have one queued summon at a time-- trying to summon another replaces the first call).  It's also not an unacceptable level of lag, IMO, given the infrequency of such calls, and the fact that I'm providing the option to toggle off the feature if server admins don't want it used.  However, no amount of lag is ideal, so if possible I'd love to find a more elegant solution-- or at least a mod recommendation to help improve it. Thanks!
    • When i start my forge server its on but when i try to join its come a error Internal Exception: java.lang.OutOfMemoryError: Requested array size exceeds VM limit Server infos: Linux Minecraft version 1.20.1 -Xmx11G -Xms8G
    • Also add the latest.log from your logs-folder
    • Add the mods in groups
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.