Jump to content

Recommended Posts

Posted

How can I make it so that when the user holds right click, onItemRightClick doesn't get called multiple times? Is there any built in function or would I have to program a lock manually? If I need to program it manually, how would I go about doing so?

Posted

Hi

 

Unfortunately it is pretty difficult to override some of the minecraft default behaviour for user inputs.  You could perhaps stop multiple clicking by overrwriting the repeat counter every tick using your own TickEvent.

 

            if (this.gameSettings.keyBindUseItem.pressed && this.rightClickDelayTimer == 0 && !this.thePlayer.isUsingItem())
            {
                this.clickMouse(1);
            }

 

Unfortunately rightClickDelayTimer is private so you would need to use reflection (AccessTransformer) to access it.

 

This link talks a bit more about user input and where the clicks are detected (and the "repeat click every x ticks" code)

 

http://greyminecraftcoder.blogspot.com.au/2013/10/user-input.html

 

If you dig through the vanilla code you might be able to find a place to intercept it, for example the PlayerInteractEvent (with RIGHT_CLICK_AIR)

 

Some items (eg) the bow do this by overriding getMaxItemUseDuration, that might also be of help.

 

-TGG

 

Posted

public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World,	EntityPlayer par3EntityPlayer) {
   if(par1ItemStack.stackTagCompound.getIteger("onItemRightClickDelay") == 0) {
      par1ItemStack.stackTagCompound.setInteger("onItemRightClickDelay", 5);
      //do stuff
   }
}

 

Then you can either tick that value down in onUpdate or you can wait for the onItemStoppedUsing (sp?) and set it back to zero

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Use Draco's, I'm dumb.

 

package tlhpoe.fs.item;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemBow;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class ItemTest extends ItemBow {
private boolean fired;

@Override
public ItemStack onItemRightClick(ItemStack is, World w, EntityPlayer player) {
	if(!w.isRemote) {
		if(!fired) {
			fired = true;
		}
	}
	return is;
}

@Override
public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4) {
	fired = false;
}
}

Kain

Posted

The noest of nos.  There's a reason I referenced the item stack NBT data.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • 3 years later...
Posted
  On 2/13/2014 at 3:14 PM, Draco18s said:

 

public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World,	EntityPlayer par3EntityPlayer) {
   if(par1ItemStack.stackTagCompound.getIteger("onItemRightClickDelay") == 0) {
      par1ItemStack.stackTagCompound.setInteger("onItemRightClickDelay", 5);
      //do stuff
   }
}
 

 

 

Then you can either tick that value down in onUpdate or you can wait for the onItemStoppedUsing (sp?) and set it back to zero

Expand  

This inplementation worked thanks. 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
    • Crashes the server when trying to start. Error code -1. Log  
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.