Adding Light API to the Forge

[Abastro]

I think the light calculation process of the Minecraft is not enough customized through Forge,

 

So I suggest adding a 'Light API' to the Forge.

 

Light API would give modders access to Minecraft's light calculation process,

 

so modders can modify the light properties for their world, etc.

[Abastro]

What I wanted was changing basic light calculation method of minecraft,

which covers every parts of the world, not specific Tile entity or something.

 

I think there is plenty of modularizable things at light calculation.

if that is not possible, at least I want interfaces like 'LightCalcHandler' for specific added world.

[LexManos]

Not trying to sound like a dick but to give some illustration to your request i'm going to use a little hyperbole.

"I want your program to do the thingy with the stuff and the doohickey"

"What?"

"I want thingies!"

 

You need to be more specific, "Light API" is very broad, we expose and expand upon A LOT of light related things in Minecraft.

[Abastro]

So, I'd say more details about this..

 

What I want is:

 

1. Separate getSunBrightness, calculateSkylightSubtracted, etc. from getCelestialAngle

I realized that what we can change about the skylight is only the Celestial Angle, but one could want to make it dark while sun is still on the surface.

So I want to make them independent, like moving the methods to the worldprovider, etc,

and change their name more understandable like "getSkyBrightness"

so they can use this easily to Solar panel, etc.

 

2. Modifiable getBlockLightValue in World class and Chunk class, etc.

Maybe someone would want to add light diffraction to his/her world,

so making these methods modifiable in the worldprovider class will be better.

 

3. Give getCelestialAngle more parameters.

I want to make the mod 'Stellarium' which makes celestial angle differs via coordinates.

so, I want some parameters which could give the coordinates information, etc.

Of course I know that this have many issues, but I really want it.

 

4. Customizing Moon Factors

I've seen that we can only modify the phase of the moon through the world.

I want it more specific and direct, like moving the method "getCurrentMoonPhaseFactor" to the worldprovider.

There would be many ways...

 

5. Gather Dispersed Effect of Rain and Thunder, etc. into one or more classes.

I've seen that Effect of Rain and Thunder is dispersed on many functions.

I think it would be better to gather them into one or more classes,

and customize them, and give some space to other (weather) effects which can be added by some mods.

[Abastro]

Can I make a PullRequest, then?

[Abastro]

I want any answer on this suggestion..

[SanAndreaP]

I want any answer on this suggestion..

 

There's nothing stopping you making a PR, it either gets accepted or rejected.