Jump to content

Recommended Posts

Posted

i am making a simple item and trying to make a config for ids thats follows the mod. but when i load the mod the id of the item is set to 0 (256 for items) and i have been trying diffrent approches on the problem. but cant seem to find the problem.

 

here is the entire class:

http://pastebin.com/90vGpE0i

 

thanks for the help in addvance

Posted

a) Why are your EventHandlers static?

b) You create the Item before you load the config.

c) You should do all your Item creation and stuffs in preInit.

yea i can tell you none of that makes any diffrence. that was the first i tryied and did not work. i have made the event handlers not static anymore. but what ever the place i but the item creation it will not get the id from the config file :(

Posted

Maybe it's different in 1.6.4, but in my version (1.7.2) Configuration does not have the signature you used. It doesn't even have that method.

 

Code you use:

config.getItem("Talisman core id", 6244, "determens the id of the core").getInt(6244);

 

The code I found:

    public Property get(String category, String key, int defaultValue, String comment)

 

So, get vs getItem, and the argument order and types differ.

Posted

Show your new code.

here is what the code looks like right now: http://pastebin.com/JGSzCxAg

 

Maybe it's different in 1.6.4, but in my version (1.7.2) Configuration does not have the signature you used. It doesn't even have that method.

 

Code you use:

config.getItem("Talisman core id", 6244, "determens the id of the core").getInt(6244);

 

The code I found:

    public Property get(String category, String key, int defaultValue, String comment)

 

So, get vs getItem, and the argument order and types differ.

there is a get(String category, String key, int defaultValue) in 1.6.4 but i found the getItem method and that takes one less parameter than get, and that is the category :)

Posted

public static Item talismancore;

public static int talibaseID;

 

PRE INT:

Configuration config = new Configuration(event.getSuggestedConfigurationFile());

config.load();

talibaseID = config.get("Item", "Talisman core ID", theid).getInt();

config.save();

 

LOAD:

talismancore = new talismancore(talismancoreID - 256).setUnlocalizedName("talismancore");

 

Thats it!

 

 

Posted

It works fine for me on 1.6.4!

Don't know why he have to create items in preInit!

Yea i know right. I have a mod were i have done the same but have no config file. Is it the config that makes me need the preinit?

 

And i did not have the time yesterday to try it out, i will today when i get home.

Posted

It works fine for me on 1.6.4!

Don't know why he have to create items in preInit!

Yea i know right. I have a mod were i have done the same but have no config file. Is it the config that makes me need the preinit?

 

And i did not have the time yesterday to try it out, i will today when i get home.

 

look here why you should register your items / blocks in preinit:

http://greyminecraftcoder.blogspot.de/2013/11/how-forge-starts-up-your-code.html

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Posted

well what happens when i put my item constructor inside preinit it make an error in init where i register my item.

[spoiler=Code not working]

public static int talismancoreID;

 

@EventHandler

public void modconfig(FMLPreInitializationEvent event){

Item talismancore = new talismancore(talibase.talismancoreID).setUnlocalizedName("talismancore");

Configuration config = new Configuration(event.getSuggestedConfigurationFile());

config.load();

 

talibase.talismancoreID = talibase.talismancoreID + config.getItem("Talisman core id", 6244, "determens the id of the core").getInt(6244);

 

config.save();

}

 

@EventHandler

public void Load(FMLInitializationEvent event){

 

 

Item talismancore; // <-- eclipse wants that there

//GameRegistry

GameRegistry.registerItem(talismancore, "talismancore");

 

//LanguageRegistry

LanguageRegistry.addName(talismancore, "Talisman Core");

 

}

 

 

and it does't want to be a public constructor. so what do i do now???

Posted

Please learn basic java before modding.

trust me, i would have learned it if i havent been stuck in a totaly stupid school system where i need 5 more years of school before i can actualy do anysort of programing, and i am only 17 -_-. but can someone tell me so i can learn from my failiure and hopefully get on with evrybodys lifes?

Posted

SanAndreasP:I know what order the forge uses to load up the mod.

 

demand12:CTRL+C and CTRL+V my code and you are basically done!

i am sorry, i have scrolled past your code since you posted it, i have been scrolling to fast to see it xD.

 

but i tried your code, AND IT WORKS!!! thank you very much good sir

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi,  I'm using Forge 47.3.0 for Minecraft 1.20.1 I apologise if this is obvious I am very new to modding for Minecraft. I sucessfully made a mod that launched without errors or crashes (without it doing anything) but in order to add the features I need, I need to add "Custom Portal API [Forge]" as a dependency. However no matter the way I've tried to acheive this, it crashes. I am pretty sure it's not the way I'm putting it in the repositories, the dependencies or the way I'm refrencing it, as I've a hundred diffrent combinations and multiple Maven methods. And on all those diffrent variations I still get this crash: pastebin.com/UhumzZCZ Any tips would be invaluable as I've been loosing my mind over this!
    • Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!
    • Instructions on how to install newer Java can be found in the FAQ
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.