[1.7.2] Extending redstone lamps

[[vF]rufus]

Hello, i'm new to modding and i want to make my custom textured redstone lamp. From my knowledge i know that the blocks needs extending from other if you want to add similar. I get the lamp working, but when activate it, she puts the original redstone lamp texture and dont use mine. So can anyone help me ?

[Graphicscore]

How about you post some code of what you've done ?

[[vF]rufus]

How about you post some code of what you've done ?

Sure

Here is my MainClass

 

 

 

package net.rufus.mb;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.rufus.mb.blocks.BlueBrick;
import net.rufus.mb.blocks.GreenBrick;
import net.rufus.mb.blocks.GreenLamp;
import net.rufus.mb.blocks.RedBrick;
import net.rufus.mt.CommonProxy;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.registry.GameRegistry;

@Mod(modid = MainClass.modid, version = MainClass.version)
public class MainClass {

@SidedProxy(clientSide = "net.rufus.mb.ClientProxy", serverSide = "net.rufus.mb.CommonProxy")
public static CommonProxy proxy;

public static final String modid = "mb";
public static final String version = "1.0";

public static Block GreenBrick;
public static Block BlueBrick;
public static Block RedBrick;

public static Block GreenLamp;
public static Block GreenOre;

public static CreativeTabs MoreBlocks = new CreativeTabs("MoreBlocks"){
	public Item getTabIconItem() {
		return Item.getItemFromBlock(Blocks.acacia_stairs);
	}
};

public MainClass(){

	GreenBrick = new GreenBrick(Material.rock);
	BlueBrick = new BlueBrick(Material.rock);
	RedBrick = new RedBrick(Material.rock);

	GreenLamp = new GreenLamp(false);
	GreenOre = new GreenOre(Material.rock);

	GameRegistry.registerBlock(GreenBrick, "GreenBrick");
	GameRegistry.registerBlock(BlueBrick, "BlueBrick");
	GameRegistry.registerBlock(RedBrick, "RedBrick");

	GameRegistry.registerBlock(GreenLamp, "GreenLamp");
	GameRegistry.registerBlock(GreenOre, "GreenOre");

	GameRegistry.registerWorldGenerator(new OreGenerator(), 1);
}
}

 

 

 

And here is my GreenLamp class

 

 

package net.rufus.mb.blocks;

import net.minecraft.block.BlockRedstoneLight;
import net.minecraft.world.IBlockAccess;
import net.rufus.mb.MainClass;

public class GreenLamp extends BlockRedstoneLight {
public GreenLamp(boolean p_i45421_1_) {
	super(p_i45421_1_);
	setCreativeTab(MainClass.MoreBlocks);
	setBlockName("GreenLamp");
	setBlockTextureName(MainClass.modid + ":GreenLampIdle");
}
}

 

 

[hotrods20]

Taking a quick look at the redstone lamp code, check the onBlockAdded, onNeighborChange, and updateTick code.  You will see it is changing it to a different lamp object.  Change that to your active lamp object and everything will be all good.

[[vF]rufus]

Taking a quick look at the redstone lamp code, check the onBlockAdded, onNeighborChange, and updateTick code.  You will see it is changing it to a different lamp object.  Change that to your active lamp object and everything will be all good.

 

Ok, but when its ones activated then stays in that texture .. For testing i putted 3 various textures. Here is the code :

package net.rufus.mb.blocks;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockRedstoneLight;
import net.minecraft.init.Blocks;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.rufus.mb.MainClass;

public class GreenLamp extends BlockRedstoneLight {
private boolean field_150171_a;
public GreenLamp(boolean p_i45421_1_) {
	super(p_i45421_1_);
	setCreativeTab(MainClass.MoreBlocks);
	setBlockName("GreenLamp");
	setBlockTextureName(MainClass.modid + ":GreenLampIdle");
}
public void onBlockAdded(World p_149726_1_, int p_149726_2_, int p_149726_3_, int p_149726_4_)
    {
        if (!p_149726_1_.isRemote)
        {
            if (this.field_150171_a && !p_149726_1_.isBlockIndirectlyGettingPowered(p_149726_2_, p_149726_3_, p_149726_4_))
            {
                p_149726_1_.scheduleBlockUpdate(p_149726_2_, p_149726_3_, p_149726_4_, this, 4);
            }
            else if (!this.field_150171_a && p_149726_1_.isBlockIndirectlyGettingPowered(p_149726_2_, p_149726_3_, p_149726_4_))
            {
                p_149726_1_.setBlock(p_149726_2_, p_149726_3_, p_149726_4_, MainClass.BlueBrick, 0, 2);
            }
        }
    }

public void onNeighborBlockChange(World p_149695_1_, int p_149695_2_, int p_149695_3_, int p_149695_4_, Block p_149695_5_)
    {
        if (!p_149695_1_.isRemote)
        {
            if (this.field_150171_a && !p_149695_1_.isBlockIndirectlyGettingPowered(p_149695_2_, p_149695_3_, p_149695_4_))
            {
                p_149695_1_.scheduleBlockUpdate(p_149695_2_, p_149695_3_, p_149695_4_, this, 4);
            }
            else if (!this.field_150171_a && p_149695_1_.isBlockIndirectlyGettingPowered(p_149695_2_, p_149695_3_, p_149695_4_))
            {
                p_149695_1_.setBlock(p_149695_2_, p_149695_3_, p_149695_4_, MainClass.RedBrick, 0, 2);
            }
        }
    }

public void updateTick(World p_149674_1_, int p_149674_2_, int p_149674_3_, int p_149674_4_, Random p_149674_5_)
    {
        if (!p_149674_1_.isRemote && this.field_150171_a && !p_149674_1_.isBlockIndirectlyGettingPowered(p_149674_2_, p_149674_3_, p_149674_4_))
        {
            p_149674_1_.setBlock(p_149674_2_, p_149674_3_, p_149674_4_, MainClass.GreenLamp, 0, 2);
        }
    }

}

[hotrods20]

Your problem is you're turning them into the other objects which are incapable of turning into lamps.  You need to declare two(2) lamps in your MainClass.  IdleLamp and ActiveLamp.  Change the code based on that.

[[vF]rufus]

Your problem is you're turning them into the other objects which are incapable of turning into lamps.  You need to declare two(2) lamps in your MainClass.  IdleLamp and ActiveLamp.  Change the code based on that.

Ok, but i maked to lamps : GreenLampON and GreenLampOFF. It works perfect but the texture isn't updating And also in MainClass where i usually put the material of a block it wants boolean... When i click the fix thing it puts "false" in the brackets. And one last question. All of this needs to be in GreenLamp class right ? Then what setBlockName should i put and the texture name ?

[hotrods20]

setBlockTextureName(MainClass.modid + ":GreenLampIdle");

You are setting the texture to be GreenLampIdle.  You need to have the texture be based on the lamps state.  Do what the redstone lamp does,

.setTextureName("redstone_lamp_off")
.setTextureName("redstone_lamp_on")

You set the texture names when you initialize the redstone lamp variables.  So,

public static Block myLampOn = new BlockMyLamp(var...).setTextureName(modid + ":GreenLampIdle");
public static Block myLampOff = new BlockMyLamp(var...).setTextureName(modid + ":GreenLampActive");

 

Quick Edit: Remove

setBlockTextureName(MainClass.modid + ":GreenLampIdle");

from your BlockLamp class.

[[vF]rufus]

Thank you very much ! Now i can made lamps Lock.