Posted June 1, 201411 yr I have added a 3D Custom Rendered Block that has a custom model called BlockCampfire. I have been trying to make it flammable and havent found any way to do so. Does anyone know how I could achieve this functionality. My block is directionally placeable and It shows up in game properly with the appropriate hitbox. I have been trying to make this block ignitable like netherrack is so that it burns until it is put out. But the netherrack class doesnt implement anything to do with fire. I havent been able to dig up any documentation on how the infinite burning works for netherrack and am confused as to how to implement flammability to a block so that it may be ignited in game by the flint and steel. Here are my classes that render the Block BlockCampfire.java public class BlockCampfire extends BlockContainer { public BlockCampfire(Material material) { super(material); this.setHardness(3.0f); this.setResistance(5.0f); this.setStepSound(soundTypeGrass); this.setBlockBounds(0F, 0F, 0F,1F,0.1F,1F); this.setCreativeTab(CommonProxy.CustomModTab); } public void onBlockPlacedBy(World world, int i, int j, int k, EntityLiving entityliving) { int l = MathHelper.floor_double((double)((entityliving.rotationYaw * 4F) / 360F) + 2.5D) & 3; world.setBlockMetadataWithNotify(i, j, k, l, 2); System.out.println(l); } public boolean isOpaqueCube(){ return false; } public boolean renderAsNormalBlock(){ return false; } @Override public int getRenderType(){ int id; id = RenderingRegistry.getNextAvailableRenderId(); return id; } @Override public TileEntity createNewTileEntity(World world, int var2) { return new TileEntityCampfire(); } @Override public void onBlockPlacedBy(World world, int i, int j, int k, EntityLivingBase entityliving, ItemStack itemStack) { int facingDirection = MathHelper.floor_double((double) ((entityliving.rotationYaw * 4F) / 360F) + 0.5D) & 3; int newFacing = 0; if (facingDirection == 0) { newFacing = 2; } if (facingDirection == 1) { newFacing = 5; } if (facingDirection == 2) { newFacing = 3; } if (facingDirection == 3) { newFacing = 4; } TileEntity tileEntity = world.getTileEntity(i, j, k); if (tileEntity != null && tileEntity instanceof TileEntityCampfire) { TileEntityCampfire tileEntityCampfire = (TileEntityCampfire) tileEntity; tileEntityCampfire.setFacingDirection(newFacing); world.markBlockForUpdate(i, j, k); } } @SideOnly(Side.CLIENT) public void registerBlockIcons(IIconRegister iconRegister) { this.blockIcon = iconRegister.registerIcon(CustomMod.modid + ":" + this.getUnlocalizedName().substring(5)); } } TileEntityCampfire public class TileEntityCampfire extends TileEntity { private int blockCampfirefacingDirection; public int getFacingDirection() { return blockCampfirefacingDirection; } public void setFacingDirection(int direction) { this.blockCampfirefacingDirection = direction; } @Override public Packet getDescriptionPacket() { NBTTagCompound tag = new NBTTagCompound(); writeToNBT(tag); return new S35PacketUpdateTileEntity(xCoord, yCoord, zCoord, 1, tag); } @Override public void onDataPacket(NetworkManager net, S35PacketUpdateTileEntity packet) { readFromNBT(packet.func_148857_g()); } @Override public void readFromNBT(NBTTagCompound nbttagcompound) { super.readFromNBT(nbttagcompound); blockCampfirefacingDirection = nbttagcompound.getInteger("blockfacingDirection"); } @Override public void writeToNBT(NBTTagCompound nbttagcompound) { super.writeToNBT(nbttagcompound); nbttagcompound.setInteger("blockfacingDirection", blockCampfirefacingDirection); } } BlockRenderCampfire class public class BlockRenderCampfire extends TileEntitySpecialRenderer{ private static final ResourceLocation Campfiretexture = new ResourceLocation("custommod:textures/blocks/blockCampfire.png"); private BlockModelCampfire modelCampfire; public BlockRenderCampfire() { this.modelCampfire = new BlockModelCampfire(); } protected ResourceLocation getBlockTexture(Block Campfire) { return this.Campfiretexture; } public void renderBlockToFaceAnyDirection(TileEntityCampfire blockCampfire, double x, double y, double z, float scale) { GL11.glPushMatrix(); GL11.glTranslatef((float) x + 0.5F, (float) y + 1.5F, (float) z + 0.5F); this.bindTexture(Campfiretexture); //Rotates model, as for some reason it is initially upside (180 = angle, 1.0F at end = about z axis) GL11.glRotatef(180, 0.0F, 0.0F, 1.0F); int facingDirection = blockCampfire.getFacingDirection(); int direction = 0; //South if (facingDirection == 2) { direction = 0; } //North if (facingDirection == 3) { direction = 180; } //East if (facingDirection == 4) { direction = -90; } //West if (facingDirection == 5) { direction = 90; } //Rotates model on the spot, depending on direction, making the front always to player) (k = angle, 1.0F in middle = about y axis) GL11.glRotatef(direction, 0.0F, 1.0F, 0.0F); GL11.glDisable(GL11.GL_CULL_FACE); GL11.glEnable(GL11.GL_ALPHA_TEST); this.modelCampfire.render((Entity)null, 0.0F, 0.0F, -0.1F, 0.0F, 0.0F, 0.0625F); GL11.glPopMatrix(); } @Override public void renderTileEntityAt(TileEntity tileentity, double x, double y, double z, float f) { this.renderBlockToFaceAnyDirection((TileEntityCampfire) tileentity, x, y, z, f); } } ItemRenderCampfire class public class ItemRenderCampfire implements IItemRenderer { protected ModelBase blockModelCampfire; protected ResourceLocation blockCampfireTexture; TileEntitySpecialRenderer render; private TileEntity entity; public ItemRenderCampfire(TileEntitySpecialRenderer render, TileEntity entity){ blockModelCampfire = new BlockModelCampfire(); blockCampfireTexture = new ResourceLocation("custommod:textures/blocks/blockCampfire.png"); this.entity = entity; this.render = render; } @Override public boolean handleRenderType(ItemStack item, ItemRenderType type) { switch (type) { case EQUIPPED: case EQUIPPED_FIRST_PERSON: case ENTITY: case INVENTORY: return true; default: return false; } } @Override public boolean shouldUseRenderHelper(ItemRenderType type, ItemStack item, ItemRendererHelper helper) { switch (type) { case ENTITY: { return false; } case EQUIPPED: { return false; } case EQUIPPED_FIRST_PERSON: { return false; } case INVENTORY:// this case statement is required to get an inventory texture { return helper == ItemRendererHelper.INVENTORY_BLOCK; } default: { return false; } } } @Override public void renderItem(ItemRenderType type, ItemStack item, Object... data) { switch (type) { case EQUIPPED: case EQUIPPED_FIRST_PERSON: GL11.glPushMatrix(); // rotates the item GL11.glRotatef(0, 0, 0, 1); GL11.glRotatef(0, 0, 1, 0); GL11.glRotatef(00, 1, 0, 0); GL11.glTranslatef(0.5f, 0.90f,0.3f); GL11.glScalef(-2F, -2F, -2F); Minecraft.getMinecraft().renderEngine .bindTexture(this.blockCampfireTexture); // renders the item blockModelCampfire.render((Entity) data[1], 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0225f); GL11.glPopMatrix(); default: break; // Renders the Campfire on ground as a pickable item } switch (type) { case ENTITY: GL11.glPushMatrix(); // rotates the item and translates the item GL11.glRotatef(0, 0, 0, 1); GL11.glRotatef(180, 0, 1, 0); GL11.glRotatef(180, 1, 0, 0); GL11.glTranslatef(0, -2.95f, 0f); GL11.glScalef(6F, 6F, 6F); Minecraft.getMinecraft().renderEngine .bindTexture(this.blockCampfireTexture); // renders the item blockModelCampfire.render((Entity) data[1], 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0225f); GL11.glPopMatrix(); default: break; } switch (type) { case INVENTORY: GL11.glPushMatrix(); // rotates the item and translates the item GL11.glRotatef(0, 0, 0, 1); GL11.glRotatef(45, 0, 1, 0); GL11.glRotatef(10, 1, 0, 0); GL11.glTranslatef(0f, -2.2f, 0f); GL11.glScalef(4.2F, 4.2F, 4.2F); Minecraft.getMinecraft().renderEngine .bindTexture(this.blockCampfireTexture); // renders the item blockModelCampfire.render(null, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0225f); GL11.glPopMatrix(); default: break; } } protected ResourceLocation getEntityTexture(Entity Campfire) { return this.blockCampfireTexture; } }
June 1, 201411 yr Author I have found the method you pointed me to but I am unsure as to how to add it to my block @Override public boolean isFireSource(World world, int x, int y, int z, ForgeDirection side) { if (this == Blocks.netherrack && side == UP) { return true; } if ((world.provider instanceof WorldProviderEnd) && this == Blocks.bedrock && side == UP) { return true; } return false; } When I add this.isFireSource(world, x, y, z, UP); to my constructor I get errors that tell me the variables are undefined
June 1, 201411 yr Learn java. You need to declare those fields and things like that. You can override that method in your Block class.
June 1, 201411 yr Read again, no. Those would be null. You can override that method in your Block class.
June 1, 201411 yr Author I created that method in my block class and I am overriding it. public class BlockCampfire extends BlockContainer { public BlockCampfire(Material material) { super(material); this.setHardness(3.0f); this.setResistance(5.0f); this.setStepSound(soundTypeGrass); this.setBlockBounds(0F, 0F, 0F,1F,0.1F,1F); this.setCreativeTab(CommonProxy.custommodTab); this.setLightLevel(10F); } public void onBlockPlacedBy(World world, int i, int j, int k, EntityLiving entityliving) { int l = MathHelper.floor_double((double)((entityliving.rotationYaw * 4F) / 360F) + 2.5D) & 3; world.setBlockMetadataWithNotify(i, j, k, l, 2); System.out.println(l); } @Override public boolean isFireSource(World world, int x, int y, int z, ForgeDirection side) { if (this == CommonProxy.blockCampfire && side == UP) { return true; } return true;} public boolean isOpaqueCube(){ return false; } public boolean renderAsNormalBlock(){ return false; } @Override public int getRenderType(){ int id; id = RenderingRegistry.getNextAvailableRenderId(); return id; } @Override public TileEntity createNewTileEntity(World world, int var2) { return new TileEntityCampfire(); } @Override public void onBlockPlacedBy(World world, int i, int j, int k, EntityLivingBase entityliving, ItemStack itemStack) { int facingDirection = MathHelper.floor_double((double) ((entityliving.rotationYaw * 4F) / 360F) + 0.5D) & 3; int newFacing = 0; if (facingDirection == 0) { newFacing = 2; } if (facingDirection == 1) { newFacing = 5; } if (facingDirection == 2) { newFacing = 3; } if (facingDirection == 3) { newFacing = 4; } TileEntity tileEntity = world.getTileEntity(i, j, k); if (tileEntity != null && tileEntity instanceof TileEntityCampfire) { TileEntityCampfire tileEntityCampfire = (TileEntityCampfire) tileEntity; tileEntityCampfire.setFacingDirection(newFacing); world.markBlockForUpdate(i, j, k); } } @SideOnly(Side.CLIENT) public void registerBlockIcons(IIconRegister iconRegister) { this.blockIcon = iconRegister.registerIcon(CustomMod.modid + ":" + this.getUnlocalizedName().substring(5)); } } But it looks as if it isn't being called
June 1, 201411 yr Author I am stumped by this, if anyone has any examples or is willing to help I will be continuing to try to figure this out
June 4, 201411 yr I'm looking for a solution to the same problem for my woodchips. When I first made my woodchips block for 1.6 and earlier, I just edited BlockFire.java, but now I'm trying to use Forge, and I'm finding everything a lot harder to do. I found several methods in Block.java: getFlammability, isFlammable, getFireSpreadSpeed; but for some reason I can't override them in my modblock class. I guess it might have something to do with protected variables. The Forge documentation says that they return Flammability and FireSpreadSpeed values, but I think this might be wrong, and they're simply returning the blockID of the block in question, which is then picked up by BlockFire.java in its setBurnRate method, at which point the blockIDs are matched with Flammability and SpreadSpeed values. I thought I might cheat by popping in planks, and tricking fire into thinking that my woodchips were planks, but that doesn't change the fact that blockFireSpreadSpeed and blockFlammability are protected.
June 9, 201411 yr Author Yes I seem to have run into the same problem, I want to try and find a method that doesn't edit Minecraft base classes. So far no luck still. I have been looking at all of the methods you mentioned and haven't found out much yet, its still an unsolved problem.
June 9, 201411 yr Hi The code from Block.isFireSource() certainly looks like it should do the trick /** * Currently only called by fire when it is on top of this block. * Returning true will prevent the fire from naturally dying during updating. * Also prevents firing from dying from rain. * * @param world The current world * @param x The blocks X position * @param y The blocks Y position * @param z The blocks Z position * @param metadata The blocks current metadata * @param side The face that the fire is coming from * @return True if this block sustains fire, meaning it will never go out. */ public boolean isFireSource(World world, int x, int y, int z, int metadata, ForgeDirection side) { if (blockID == Block.netherrack.blockID && side == UP) { return true; } if ((world.provider instanceof WorldProviderEnd) && blockID == Block.bedrock.blockID && side == UP) { return true; } return false; } Have you tried public class BlockCampfire extends BlockContainer { [..] @Override public boolean isFireSource(World world, int x, int y, int z, ForgeDirection side) { return (side == UP); } When you light a fire on top of the campfire block using flint and steel, it should call your isFireSource. @Spaceboot1: > but for some reason I can't override them in my modblock class. .. that means you must be doing something wrong because there's nothing special about those methods. Show your code? -TGG
June 10, 201411 yr Author When I replace my .isFireSource method in public class BlockCampfire extends BlockContainer { public BlockCampfire(Material material) { super(material); this.setHardness(3.0f); this.setResistance(5.0f); this.setStepSound(soundTypeGrass); this.setBlockBounds(0F, 0F, 0F,1F,0.1F,1F); this.setCreativeTab(CommonProxy.custommodTab); this.setLightLevel(10F); } public void onBlockPlacedBy(World world, int i, int j, int k, EntityLiving entityliving) { int l = MathHelper.floor_double((double)((entityliving.rotationYaw * 4F) / 360F) + 2.5D) & 3; world.setBlockMetadataWithNotify(i, j, k, l, 2); System.out.println(l); } @Override public boolean isFireSource(World world, int x, int y, int z, ForgeDirection side) { if (this == CommonProxy.blockCampfire && side == UP) { return true; } return true;} public boolean isOpaqueCube(){ return false; } public boolean renderAsNormalBlock(){ return false; } @Override public int getRenderType(){ int id; id = RenderingRegistry.getNextAvailableRenderId(); return id; } @Override public TileEntity createNewTileEntity(World world, int var2) { return new TileEntityCampfire(); } @Override public void onBlockPlacedBy(World world, int i, int j, int k, EntityLivingBase entityliving, ItemStack itemStack) { int facingDirection = MathHelper.floor_double((double) ((entityliving.rotationYaw * 4F) / 360F) + 0.5D) & 3; int newFacing = 0; if (facingDirection == 0) { newFacing = 2; } if (facingDirection == 1) { newFacing = 5; } if (facingDirection == 2) { newFacing = 3; } if (facingDirection == 3) { newFacing = 4; } TileEntity tileEntity = world.getTileEntity(i, j, k); if (tileEntity != null && tileEntity instanceof TileEntityCampfire) { TileEntityCampfire tileEntityCampfire = (TileEntityCampfire) tileEntity; tileEntityCampfire.setFacingDirection(newFacing); world.markBlockForUpdate(i, j, k); } } @SideOnly(Side.CLIENT) public void registerBlockIcons(IIconRegister iconRegister) { this.blockIcon = iconRegister.registerIcon(CustomMod.modid + ":" + this.getUnlocalizedName().substring(5)); } } with the code you suggested and then I try to light the flint nothing happens, and when I added System.out.println("UP"); to the method you suggested (above the return statement) nothing is displayed in the console suggesting that the method isnt being called
June 10, 201411 yr Hi DieSieben You will have to set burn properties for your Block as well, otherwise the fire instantly removes itself when it's added. Are you sure about that? If I look through the code in BlockFire.onUpdate I see Block base = Block.blocksList[par1World.getBlockId(wx, wy - 1, wz)]; boolean blockBelowIsFireSource = (base != null && base.isFireSource(par1World, wx, wy - 1, wz, par1World.getBlockMetadata(wx, wy - 1, wz), UP)); if (!this.canPlaceBlockAt(par1World, wx, wy, wz)) { par1World.setBlockToAir(wx, wy, wz); } and public boolean canPlaceBlockAt(World par1World, int wx, int wy, int wz) { return par1World.doesBlockHaveSolidTopSurface(wx, wy - 1, wz) || this.canNeighborBurn(par1World, wx, wy, wz); } i.e. so long as the block below isFireSource() and has a doesBlockHaveSolidTopSurface, it should sustain a fire above it, even if the other burn properties are not used? @Thornack Odd. Try putting the breakpoint into BlockFire.updateTick() and then use your flint to light the top of the block. Then trace through to see why it doesn't call your Block's method. -TGG
June 10, 201411 yr Author @TheGreyGhost I am not sure how to add the breakpoint where you suggested as that would involve editing minecraft base classes wouldnt it? Im not sure how to go about doing that I know that you can find the class files in Referenced Libraries then forgeSrc-1.7.2-10.12.1.1060.jar and I have found the BlockFire.class file in package net.minecraft.block and the method you mentioned but I cannot edit it for some reason. When I try to put my System.out.println("UP"); into the method I simply cannot type anything or paste anything in. My Campfire block class looks like this package soccer.block; import static net.minecraftforge.common.util.ForgeDirection.UP; import net.minecraft.block.Block; import net.minecraft.block.BlockContainer; import net.minecraft.block.material.Material; import net.minecraft.client.renderer.texture.IIconRegister; import net.minecraft.entity.EntityLiving; import net.minecraft.entity.EntityLivingBase; import net.minecraft.init.Blocks; import net.minecraft.item.ItemStack; import net.minecraft.tileentity.TileEntity; import net.minecraft.util.MathHelper; import net.minecraft.world.World; import net.minecraft.world.WorldProviderEnd; import net.minecraftforge.common.util.ForgeDirection; import soccer.CommonProxy; import soccer.Soccer; importsoccer.tileentity.TileEntityCampfire; import cpw.mods.fml.client.registry.RenderingRegistry; import cpw.mods.fml.relauncher.Side; import cpw.mods.fml.relauncher.SideOnly; public class BlockCampfire extends BlockContainer { public BlockCampfire(Material material) { super(material); this.setHardness(3.0f); this.setResistance(5.0f); this.setStepSound(soundTypeGrass); this.setBlockBounds(0F, 0F, 0F,1F,0.1F,1F); this.setCreativeTab(CommonProxy.soccerTab); this.setLightLevel(10F); } public void onBlockPlacedBy(World world, int i, int j, int k, EntityLiving entityliving) { int l = MathHelper.floor_double((double)((entityliving.rotationYaw * 4F) / 360F) + 2.5D) & 3; world.setBlockMetadataWithNotify(i, j, k, l, 2); System.out.println(l); } @Override public boolean isFireSource(World world, int x, int y, int z, ForgeDirection side) { System.out.println("UP"); return (side == UP); } public boolean isOpaqueCube(){ return false; } public boolean renderAsNormalBlock(){ return false; } @Override public int getRenderType(){ int id; id = RenderingRegistry.getNextAvailableRenderId(); return id; } @Override public TileEntity createNewTileEntity(World world, int var2) { return new TileEntityCampfire(); } // this method makes the block directionally placeable @Override public void onBlockPlacedBy(World world, int i, int j, int k, EntityLivingBase entityliving, ItemStack itemStack) { int facingDirection = MathHelper.floor_double((double) ((entityliving.rotationYaw * 4F) / 360F) + 0.5D) & 3; int newFacing = 0; if (facingDirection == 0) { newFacing = 2; } if (facingDirection == 1) { newFacing = 5; } if (facingDirection == 2) { newFacing = 3; } if (facingDirection == 3) { newFacing = 4; } TileEntity tileEntity = world.getTileEntity(i, j, k); if (tileEntity != null && tileEntity instanceof TileEntityCampfire) { TileEntityCampfire tileEntityCampfire = (TileEntityCampfire) tileEntity; tileEntityCampfire.setFacingDirection(newFacing); world.markBlockForUpdate(i, j, k); } } @SideOnly(Side.CLIENT) public void registerBlockIcons(IIconRegister iconRegister) { this.blockIcon = iconRegister.registerIcon(Soccer.modid + ":" + this.getUnlocalizedName().substring(5)); } } where this method isnt being called when I try to light the block with flint @Override public boolean isFireSource(World world, int x, int y, int z, ForgeDirection side) { System.out.println("UP"); return (side == UP); }
June 11, 201411 yr @TheGreyGhost I am not sure how to add the breakpoint where you suggested as that would involve editing minecraft base classes wouldnt it? Im not sure how to go about doing that I know that you can find the class files in Referenced Libraries then forgeSrc-1.7.2-10.12.1.1060.jar and I have found the BlockFire.class file in package net.minecraft.block and the method you mentioned but I cannot edit it for some reason. When I try to put my System.out.println("UP"); into the method I simply cannot type anything or paste anything in. Yeah an unfortunate side effect of the gradle setup is that it's a lot difficult to put testing statements into the vanilla code. That's why you can't paste anything in. But you can still use breakpoints in there (you're looking in the right place), which in this case should be all you need. If you're not sure how to use them, try this http://www.vogella.com/tutorials/EclipseDebugging/article.html It's really quite awesome what you can do with the debugger and once you've learnt how to use it you'll wonder how you ever managed without it... I don't see any obvious issues with the Campfire class, if you have no luck with the debugger, post a link to your project and I can download in the next couple of days to try it myself. -TGG
July 21, 201411 yr In your constructor: Blocks.fire.setFireInfo(this, 5, 20); 5 is the encouragement value, 20 is the flammability (these are the values for wooden planks). You Only Live Once, So Win At Golf. Sorry for my English, I'm American.
September 13, 201411 yr Well, I know this thread has long since been abandoned, but I found a solution for myself at least. In my block class I simply added the code: @Override public boolean isFireSource(World world, int x, int y, int z, ForgeDirection side) { return true; } Pretty simple right? Check out my website at: http://mattkx4.github.io/
September 14, 201411 yr Yeah, when you consider that diesieben answered that in the second post. It makes it real real simple. Did he even get a thank you? -S- (if I helped, please click Thank and applaud) http://6upnqa.dm2301.livefilestore.com/y2mtf-vG7Tqq1TiiVpIm53KWj7294NDPoHfSHHb4PzZiMAUfRCfK0UY0MwOu7Q3zTBNVTKqWjr2-xgBfFRpQT5p-QivtvknPpoABMNUw9br9WuZcBFkjePhnAbW500gVm-P/sequiturian.png[/img]
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.