Jump to content

Recommended Posts

Posted

Basically, with the current mod I am trying to port, which is "Rise of the Automatons", I've hit a bit of a snag. Basically one of the blocks added won't render properly. Based on the old code it seems he was able to render it within one class, but it doesn't seem to work. Ironically I utilized similar processes for another block and it rendered exactly. Here is the unported code, and current code. I know some of the current code may be redundant, but It shall be cleaned up.

Unported:

 

public class AM_BlockGlow extends Block
{

    protected AM_BlockGlow(int i, int j)
    {
        super(i, j, Material.glass);
  float f = 0.1875F;
float f2 = 1F-f;
this.setBlockBounds(f,0,f,f2,1F-0.5F,f2);
if(j==AutomatonLogger.glowy){
loadSprites1();
}else{
loadSprites2();
}
       
    }
/*public int idDropped(int i, Random random)
{
return Item.energy.shiftedIndex;
}*/


    public int D[];
//public static int E[]={1,1};
public void loadSprites1(){

D=new int[2];
D[0]=AutomatonUniversal.modOverride("/terrain.png", "/automatons/crystal1.png");
D[1]=AutomatonUniversal.modOverride("/terrain.png", "/automatons/crystal2.png");
blockIndexInTexture=D[0];


/*E=new int[2];
E[0]=D[0];
E[1]=D[1];*/
}
public void loadSprites2(){
D=new int[2];
D[0]=AutomatonUniversal.modOverride("/terrain.png", "/automatons/glowy1.png");
D[1]=AutomatonUniversal.modOverride("/terrain.png", "/automatons/glowy2.png");
blockIndexInTexture=D[0];


}

    public AxisAlignedBB getCollisionBoundingBoxFromPool(World world, int i, int j, int k)
    {
        float f = 0.25F;
        return AxisAlignedBB.getBoundingBoxFromPool((float)i + f, j, (float)k + f, (float)(i + 1) - f, (float)(j + 0.5F), (float)(k + 1) - f);
    }

    public AxisAlignedBB getSelectedBoundingBoxFromPool(World world, int i, int j, int k)
    {
        float f = 0.25F;
        return AxisAlignedBB.getBoundingBoxFromPool((float)i + f, j, (float)k + f, (float)(i + 1) - f, (float)(j + 0.5F), (float)(k + 1) - f);
    }


    public int getBlockTextureFromSide(int i)
    {


if(i <=1 )
        {
            return D[1];
        } else
        {
            return D[0];
        }

        
    }


    public boolean renderAsNormalBlock()
    {
        return false;
    }

    public boolean isOpaqueCube()
    {
        return false;
    }

    public int getRenderType()
    {
        return 13;
    }

    public boolean canPlaceBlockAt(World world, int i, int j, int k)
    {
        if(!super.canPlaceBlockAt(world, i, j, k))
        {
            return false;
     } else
      {
         return canBlockStay(world, i, j, k);
     }
  }


    public boolean canBlockStay(World world, int i, int j, int k)
    {

        if(world.getBlockMaterial(i, j-1, k ).isSolid())
        {
            return true;
        } else
        {
            return false;
        }
    }

}

 

 

Current:

 

public class AM_Shard extends Block {


@SideOnly(Side.CLIENT)
private IIcon[] texture;

public static String block1;
public static String block2;
public static String block3;
public static String block4;
public int D[] = {27, 28};

final static String[] subBlocks = new String[] {block1, block2};

public AM_Shard(String name1, String name2) {
	super(Material.rock);
	block1 = name1;
	block2 = name2;
	this.setCreativeTab(AM_CreativeTabs.tabBlock);
	this.setHarvestLevel("pickaxe", 2);
	this.setHardness(4.5F);
	this.setStepSound(Block.soundTypeStone);
	float f = 0.1875F;
	float f2 = 1F - f;
	this.setBlockBounds(f, 0F, f, f2, 1-0.5F, f2);
	this.loadSprites(27, 28);

}

@Override
public boolean renderAsNormalBlock() {
	return false;
}

@Override
public int getRenderType() {
	return 13;
}

public Block loadSprites(int i, int j) {
	this.D[0] = i;
	this.D[1] = j;
	return this;
}

@Override
public AxisAlignedBB getSelectedBoundingBoxFromPool(World par1World, int i, int j, int k) {

	float f = 0.25F;
	return AxisAlignedBB.getBoundingBox((float) i + f, j, (float) k + f, (float) (i + 1) - f, (float) (j + 0.5F), (float) (k + 1) - f);
}

@Override
public AxisAlignedBB getCollisionBoundingBoxFromPool(World par1World, int i, int j, int k) {

	float f = 0.25F;
	return AxisAlignedBB.getBoundingBox((float) i + f, j, (float) k + f, (float) (i + 1) - f, (float) (j + 0.5F), (float) (k + 1) - f);
}

@Override
public boolean isOpaqueCube() {
	return false;
}


@SideOnly(Side.CLIENT)
@Override
public void registerBlockIcons(IIconRegister iconRegister){
	texture = new IIcon[subBlocks.length];

	for(int i = 0; i < subBlocks.length; i++){
		texture[0] = iconRegister.registerIcon(Strings.MODID + ":" + "crystal2");
		texture[1] = iconRegister.registerIcon(Strings.MODID + ":" + "crystal1");


	}
}

@SideOnly(Side.CLIENT)
public void getSubBlocks(Item block, CreativeTabs creativeTabs, List list){

	for(int i = 0; i < subBlocks.length; i++){
		list.add(new ItemStack(this, 1, i));
	}
}

@SideOnly(Side.CLIENT)
@Override
public IIcon getIcon(int side, int meta){
	{
		if(side == 0 || side == 1){
			return texture[1];
		}
		else{
			return texture[0];
		}
	}
}

public int damageDropped(int meta){
	return meta;
}


}

 

So any help here on why it's not rendering correctly?

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Posted

First of all remove that "loadSprites" stuff (and everything related to it). It's from the old ModLoader days. Please define what you mean by "don't render properly".

Ok, the loadsprites stuff I mentioned as "Redundant". But on the topic of what I mean is this:

 

 

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Posted

Well, I'm trying to keep it similar to the old code, besides I have no idea what one would work, since the ones I've tested before still give the same results as the cactus one.

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Posted

If you don't override getRenderType at all, what does it look like?

Ok I completely removed getRenderType, and it now looks like how it looked with a render type :( I even saved and double checked

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Posted

Hrm, that is weird. Are you sure you didn't screw up the texture?

Hmm, I didn't think so, because I've been using code and textures that were used before by the original modder. I can bring up it's old github repository, linked below.

https://github.com/Aninon/Automatons

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Posted

Oh god, that's ... a mess. "Let me just include allll the files in this repo..." Yay.

Again: I really can't see anything in your code that would cause this, except a broken texture (or maybe your block bounds).

Hmm, I'd assume that I either adjust the pixel locations in the texture file until it reads it correctly, or change the block bounds.

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Posted

Ok I feel stupid now, found the problem, throughout the coding process I seemed to have misnamed the textures, and used the top texture as the side texture. *facepalm That's why it messed up xD

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.