Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Biome Dictionary, inconsistency in default registrations


keybounce
 Share

Recommended Posts

BiomeDictionary.java has the following registration:

        registerBiomeType(extremeHills,        MOUNTAIN, HILLS                              );

 

In MakeBestGuess(), Hills and Mountain are exclusive; all the other extreme hills variants are either hills or mountains.

 

Equally, Extreme Hills + (162) and Extreme Hills M (131) are marked as hills, not mountains.

 

===

 

MakeBestGuess() is using a comparison of height variation against 1.5F. This value being tested used to be the max height (in 164 and earlier); none of the vanilla biomes have a height variation that large in 1.7. Even the savannah variants at 163/164 don't hit that, and they are the largest in vanilla 1.7. I think this test is definitely bugged.

 

Jeb! The sheep! The fence pens, they do nothing still leak!

Link to comment
Share on other sites

  • 1 month later...

Additional flaws:

 

1. Ice Mountains, despite the name, has the same base height 0.45 and variation 0.3 as all the hills. It should have the hills tag, not the mountains (it is not in the same category with extreme hills).

2. Mesa Plateau F M and Mesa Plateau M also have the same 0.45 and 0.3. Yet "FM" has no height tag, and "M" has the "plains" tag. (biomes 166 and 167)

3. "Savanna Plateau M" has the biggest heights in the game -- base 1.05, variation 1.2125, can get really high, yet is only "hills" -- that's like calling the Himalayas "hills".

 

Jeb! The sheep! The fence pens, they do nothing still leak!

Link to comment
Share on other sites

Where can I find instructions on submitting a pull request to forge?

 

(I'm serious: I don't know how to fetch the source, compile it, test it, make changes, and then get those changes sent back to you. What little I understand is that forge is not quite the same as normal mods and has a different behavior, and I have enough trouble getting a github pull request for mods I play around with a lot.)

Jeb! The sheep! The fence pens, they do nothing still leak!

Link to comment
Share on other sites

Where can I find instructions on submitting a pull request to forge?

 

(I'm serious: I don't know how to fetch the source, compile it, test it, make changes, and then get those changes sent back to you. What little I understand is that forge is not quite the same as normal mods and has a different behavior, and I have enough trouble getting a github pull request for mods I play around with a lot.)

 

Goto https://github.com/MinecraftForge/MinecraftForge and read the

For Contributors

part of the readme.txt

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Hi guys! I currently have a project that I've been developing in a 'vanilla' environment that I'm actually looking to transfer over to Forge, simply because of how much better the experience would be using Forge. Before starting on this Forge mod, I was planning ahead and was looking at options for proxies, of which I would greatly like to use Velocity. In their docs and by asking around their Discord, they don't support support versions of Forge of 1.13 or later because of changes in the "handshake protocol". But I also really don't want to use an unsupported version of Forge, such as 1.12.2, to be able to use a proxy. I was pointed in the direction of potentially making my own client-side mod to allow Forge to be compatible with an updated proxy, such as Velocity. When asking for a direction for achieving this, I was told to have a look at how the Forge server implements logins and that the discrepancy might be with how modified the handshake protocol is. This sounds like quite the challenge to me and I'm completely up for trying to accomplish it. So for the sake of planning ahead and having a rough idea of how I could accomplish that when the time comes to work on it, has anyone else had experience with trying to achieve this? I appreciate any help or direction offered! Thanks! 
    • Been trying to set up a server for myself and a few friends through BisectHosting. I ended up replicating the server on my own computer to see if the issue persisted (if it was on bisect's end) and it was still there. Every time a player tries to connect to the server they start connecting but after only around 2 seconds the player is disconnected with the error message Payload size exceeds 1048576 bytes.  Upon inspection of the server debug file, the player always disconnects while fmlhandshake ticking packet info is being sent, and I have repeatedly made sure the mods and their configs are identical. I tried to get RandomPatches to increase the max allowed byte size, as the default seems to be 32767, but either something is wrong with it or some other mod is limiting the packet size limit.     Server Debug: https://pastebin.com/xZLbtdQB (only includes portions from after the server launched as I couldn't upload the whole file) Server Log: https://pastebin.com/yrJ3tNaW (similarly only after server launched (hence the weird say commands) Client Log: https://pastebin.com/inSzZV96 (whole thing for once) Modlist: https://pastebin.com/Qvurg45j (All but Optifine and BetterFoliage are present on the server as they have caused issues during startup)   Honestly stumped on how to fix this, been working on it for 10 hours across two days to no avail.
    • quiero dormir uwu
    • Hi, mod called "charging gadgets" is crushing forge minecraft 1.18.1 when i place block from this mod, im temporary playing On 1.18 cuz its not happening on 1.18 but c'mon, pls fix it, 1.18.1 is better and I Wonder i could use this version
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.