Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Minecraft Forge
  • Support & Bug Reports
  • Biome Dictionary, inconsistency in default registrations
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
keybounce

Biome Dictionary, inconsistency in default registrations

By keybounce, September 14, 2014 in Support & Bug Reports

  • Reply to this topic
  • Start new topic

Recommended Posts

keybounce    2

keybounce

keybounce    2

  • Stone Miner
  • keybounce
  • Members
  • 2
  • 92 posts
Posted September 14, 2014

BiomeDictionary.java has the following registration:

        registerBiomeType(extremeHills,        MOUNTAIN, HILLS                              );

 

In MakeBestGuess(), Hills and Mountain are exclusive; all the other extreme hills variants are either hills or mountains.

 

Equally, Extreme Hills + (162) and Extreme Hills M (131) are marked as hills, not mountains.

 

===

 

MakeBestGuess() is using a comparison of height variation against 1.5F. This value being tested used to be the max height (in 164 and earlier); none of the vanilla biomes have a height variation that large in 1.7. Even the savannah variants at 163/164 don't hit that, and they are the largest in vanilla 1.7. I think this test is definitely bugged.

 

  • Quote

Jeb! The sheep! The fence pens, they do nothing still leak!

Share this post


Link to post
Share on other sites

keybounce    2

keybounce

keybounce    2

  • Stone Miner
  • keybounce
  • Members
  • 2
  • 92 posts
Posted October 19, 2014

Additional flaws:

 

1. Ice Mountains, despite the name, has the same base height 0.45 and variation 0.3 as all the hills. It should have the hills tag, not the mountains (it is not in the same category with extreme hills).

2. Mesa Plateau F M and Mesa Plateau M also have the same 0.45 and 0.3. Yet "FM" has no height tag, and "M" has the "plains" tag. (biomes 166 and 167)

3. "Savanna Plateau M" has the biggest heights in the game -- base 1.05, variation 1.2125, can get really high, yet is only "hills" -- that's like calling the Himalayas "hills".

 

  • Quote

Jeb! The sheep! The fence pens, they do nothing still leak!

Share this post


Link to post
Share on other sites

LexManos    1617

LexManos

LexManos    1617

  • Reality Controller
  • LexManos
  • Forge Code God
  • 1617
  • 8928 posts
Posted October 19, 2014

Feel free to PR it with these justifications, untill then dont care they are rather arbitrarily stuck in places anway.

  • Quote

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Patreon: http://www.patreon.com/lexmanos
Paypal: http://paypal.me/LexManos

BitCoin: 1Q8rWvUNMM2T1ZfDaFeeYQyVXtYoeT6tTn

Share this post


Link to post
Share on other sites

keybounce    2

keybounce

keybounce    2

  • Stone Miner
  • keybounce
  • Members
  • 2
  • 92 posts
Posted October 19, 2014

Where can I find instructions on submitting a pull request to forge?

 

(I'm serious: I don't know how to fetch the source, compile it, test it, make changes, and then get those changes sent back to you. What little I understand is that forge is not quite the same as normal mods and has a different behavior, and I have enough trouble getting a github pull request for mods I play around with a lot.)

  • Quote

Jeb! The sheep! The fence pens, they do nothing still leak!

Share this post


Link to post
Share on other sites

SanAndreasP    402

SanAndreasP

SanAndreasP    402

  • World Shaper
  • SanAndreasP
  • Forge Modder
  • 402
  • 1689 posts
Posted October 20, 2014

Where can I find instructions on submitting a pull request to forge?

 

(I'm serious: I don't know how to fetch the source, compile it, test it, make changes, and then get those changes sent back to you. What little I understand is that forge is not quite the same as normal mods and has a different behavior, and I have enough trouble getting a github pull request for mods I play around with a lot.)

 

Goto https://github.com/MinecraftForge/MinecraftForge and read the

For Contributors

part of the readme.txt

  • Quote

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • myrqn
      Forge Not Opening

      By myrqn · Posted just now

      Sorry i meant vanilla minecraft launcher.
    • diesieben07
      [1.15.2] Render as 2D icon in GUI, 3D model in hand

      By diesieben07 · Posted 2 minutes ago

      Item models are generated at runtime, this is handled by Forge in 1.16, but not in 1.15. It is easy to fix though, see the following change you need to make (this is not necessary in 1.16, only when copying this to 1.15): https://github.com/MinecraftForge/MinecraftForge/compare/1.16.x...diesieben07:separate-perspective-itemmodel  
    • diesieben07
      [1.16.4] SimplImpl sends packet to client instead server

      By diesieben07 · Posted 12 minutes ago

      On the server NetworkEvent.Context#getSender gives you the player that sent the packet.
    • diesieben07
      [1.16.4] How i can open a container by clicking on my mob

      By diesieben07 · Posted 15 minutes ago

      UUID should not be used here.
    • diesieben07
      Forge Not Opening

      By diesieben07 · Posted 17 minutes ago

      Lunar client and other "custom clients" are not supported. What is the "mining launcher"? Post a screenshot of your launcher.
  • Topics

    • myrqn
      2
      Forge Not Opening

      By myrqn
      Started 3 hours ago

    • Woodside
      13
      [1.15.2] Render as 2D icon in GUI, 3D model in hand

      By Woodside
      Started Sunday at 08:26 PM

    • S-Spirit
      5
      [1.16.4] SimplImpl sends packet to client instead server

      By S-Spirit
      Started Monday at 08:48 PM

    • Klarks
      40
      [1.16.4] How i can open a container by clicking on my mob

      By Klarks
      Started Saturday at 09:56 PM

    • Piticri
      2
      [FIXED] Square Letters

      By Piticri
      Started 11 hours ago

  • Who's Online (See full list)

    • myrqn
    • Peyang
    • Thorius
    • QWERTY 52 38
    • diesieben07
    • CookieLukas
    • Klarks
  • All Activity
  • Home
  • Minecraft Forge
  • Support & Bug Reports
  • Biome Dictionary, inconsistency in default registrations
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community