Jump to content
Currently supported: All versions

"TileEntityConstructing" and/or "BlockCreated" events

CosmicDan

By CosmicDan
in Suggestions

 Share

Recommended Posts

CosmicDan Tree Puncher

CosmicDan

Posted
Posted

If these were possible, it would give us a lot of power and flexibility - there are many cases I can think of where this would save a significant number of operations/iterations, and open up other areas that are impossible without coremodding.

 

TileEntityConstructing is pretty self explainatory: I would think this'd be injected into the end of TileEntity#createAndLoadEntity. Such an event would allow mods to observe/modify TileEntity data in a less-direct manner (i.e. without a custom mod block within proximity of whichever block has the TE) and also a less-hacky manner (reflection/asm on specific tile entity classes). The main advantage of this is efficiency - a block, tick event, etc. currently has to constantly scan for TileEntities within whatever range, or globally if they're daring enough. Another advantage is simply to make the impossible possible - for example a specific game mechanic (e.g. summoning a boss) that does something to all applicable TE's (e.g. drain all the electricity from your base). This would be doable if a mod were to keep it's own central registry of TE's that it needs to interract as they are created, and just check this array/list/whatever as needed to do it's thing - but that's probably obvious.

 

BlockCreated is a similar idea, but for blocks. Not sure if this is possible/feasible, but it'd be potentially more useful. But maybe only along with an event that is fired when metadata for a block changes (or people can do that themselves with a tick event).

 

Only one is needed really, since it's simple to get one from the other. I would fork MinecraftForge and make a pull request for it, but I'm new to the MCP side of things. Seems that Forge has patch/diff files that it uses, and I know how to make these but I don't know of the specifics in how Forge is built or interracts with MCP. If anybody has some further reading on this, please let me know. That is unless the Forge collective don't see the point in this suggesion, which would be disappointing.

 

Thanks!

Windows software, Android hacking, and other curios

  • 9 months later...
TheEdenCrazy Tree Puncher

TheEdenCrazy

Posted
Posted

After looking through the code a bit, I have found that createAndLoadTileEntity is called when a TE is loaded from nbt storage. If you want an event when a TE is placed, it needs to go in world#addTileEntity and/or the methods related to these like the methods for TE removal.

LexManos Reality Controller

LexManos

Posted
Posted

Both should sufficiently be covered by the block events, and beyond that, there really isn't a good place to hook into this and pushing things like this out into the main event bus would just be horribly inefficient.

I don't see a real reason for you to need this exact event...

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Ernio Reality Controller

Ernio

Posted
Posted

Was about to write same thing.

Anyway - how do you people find topics that old?

 

Look into Forge's code before digging almost year old thread. Stuff changes over time.

 

If you need help in implemeting this (TheEdenCrazy) post what you need (exactly) in Modder Support.

1.7.10 is no longer supported by forge, you are on your own.

LexManos Reality Controller

LexManos

Posted
Posted

Ah, even I missed that it was old cuz the same guy bumped it twice. Anyways, this is unneeded.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Guest
This topic is now closed to further replies.
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TileEntity
      minecraft forge(40.2.24) 1.18.2 crash(org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError)

      By TileEntity · Posted

      It is an issue with Additional Additions
    • dasonQAQ
      minecraft forge(40.2.24) 1.18.2 crash(org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError)

      By dasonQAQ · Posted

      the modpack keep crashing idk why,cause it never said anything about any mods causing it. crash log:https://drive.google.com/file/d/1iYKlUgvHUob8DjyRc3gqP_Viv_kSHO6L/view?usp=sharing mod list:https://drive.google.com/file/d/1MvMT-z9Jg2BITQ4uLshJ1uOh7q9EMBfC/view?usp=sharing but the server(anternos) works just fine
    • 1rom11
      Duplicate recipies in datagen

      By 1rom11 · Posted

      Hello, I am trying to make 2 recipes for a ruby. The first one is turning a block into a ruby and the other one is 9 nuggets into a ruby. But I keep on getting a error java.lang.IllegalStateException: Duplicate recipe rubymod:ruby   Any help would be great on how to fix it
    • PpAdrino
      Caused by: java.lang.IllegalStateException: Rendersystem called from wrong thread

      By PpAdrino · Posted

      Hello everyone, i'm new with programing Mods, and will need a lot of your help if possible,  Im trying to make a new GUI interface responsible to control the Droprate of game, it will control de loot drop and loot table for mobs and even blocks, but i try to make a simple Gui Screen, and wenever i try to use it, the game crash's with the error message in the subject, here is the code im using to:  IDE: IntelliJ Comunity - latest version Forge: 47.3.0 Minecraft version: 1.20.1 mapping_channel: parchment mapping_version=2023.09.03-1.20.1 Crash report link: https://pastebin.com/6dV8k1Fw   Code im using is:    package createchronical.droprateconfig; import com.mojang.blaze3d.systems.RenderSystem; import net.minecraft.client.gui.GuiGraphics; import net.minecraft.client.gui.components.Button; import net.minecraft.client.gui.screens.Screen; import net.minecraft.network.chat.Component; import net.minecraft.resources.ResourceLocation; import java.util.HashMap; import java.util.Map; public class ConfigScreen extends Screen { private static final ResourceLocation BACKGROUND_TEXTURE = new ResourceLocation("droprateconfig", "textures/gui/config_background.png"); // Mapa de mobs e itens com seus respectivos drop rates private final Map<String, Integer> dropRates = new HashMap<>(); public ConfigScreen() { super(Component.literal("Configurações de Drop Rate")); // Inicializa com valores de drop rate padrão dropRates.put("Zombie", 10); // Exemplo de mob dropRates.put("Creeper", 5); // Exemplo de mob dropRates.put("Iron Ore", 50); // Exemplo de item dropRates.put("Diamond", 2); // Exemplo de item } @Override protected void init() { // Cria um botão para cada mob/item e adiciona na tela int yOffset = this.height / 2 - 100; // Posicionamento inicial for (Map.Entry<String, Integer> entry : dropRates.entrySet()) { String itemName = entry.getKey(); int dropRate = entry.getValue(); // Cria um botão para cada mob/item this.addRenderableWidget(Button.builder( Component.literal(itemName + ": " + dropRate + "%"), button -> onDropRateButtonPressed(itemName) ).bounds(this.width / 2 - 100, yOffset, 200, 20).build()); yOffset += 25; // Incrementa a posição Y para o próximo botão } // Adiciona o botão de "Salvar Configurações" this.addRenderableWidget(Button.builder(Component.literal("Salvar Configurações"), button -> onSavePressed()) .bounds(this.width / 2 - 100, yOffset, 200, 20) .build()); } private void onDropRateButtonPressed(String itemName) { // Lógica para alterar o drop rate do item/mob selecionado // Aqui, vamos apenas incrementar o valor como exemplo int currentRate = dropRates.get(itemName); dropRates.put(itemName, currentRate + 5); // Aumenta o drop rate em 5% } private void onSavePressed() { // Lógica para salvar as configurações (temporariamente apenas na memória) // Vamos apenas imprimir para verificar dropRates.forEach((item, rate) -> { System.out.println("Item: " + item + " | Novo Drop Rate: " + rate + "%"); }); // Fecha a tela após salvar Screen pGuiScreen = null; assert this.minecraft != null; this.minecraft.setScreen(pGuiScreen); } @Override public void render(GuiGraphics guiGraphics, int mouseX, int mouseY, float partialTicks) { this.renderBackground(guiGraphics); guiGraphics.blit(BACKGROUND_TEXTURE, this.width / 2 - 128, this.height / 2 - 128, 0, 0, 256, 256, 256, 256); super.render(guiGraphics, mouseX, mouseY, partialTicks); } }  
    • TileEntity
      Unknown Crash, Exception Ticking World

      By TileEntity · Posted

      Also add the latest.log from /logs/

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept