Jump to content

[1.7.10] Messing with stack sizes


cw84

Recommended Posts

Hello,

 

I started playing around with vanilla settings and have learned that when you mess with an Items MaxStackSize, it seems to break the items enchantability...

Items.diamond_sword.setMaxStackSize(;

 

Any reason why this is...? I don't fully understand why commenting out the line above gives me the ability to once again enchant the item.

Link to comment
Share on other sites

Because part of the way minecraft checks if an item is enchantable is wit this method

public boolean isItemTool(ItemStack p_77616_1_)
{
       return this.getItemStackLimit(p_77616_1_) == 1 && this.isDamageable();
}

to fix your problem you need to override isItemTool in your item class and return true.

I am the author of Draconic Evolution

Link to comment
Share on other sites

Put the same method in your class, and tell it to return something else:

@Override
public boolean isItemTool(ItemStack stack) {
return true;
}

@Override is helpful in that it informs you if you have the correct method (i.e. the method that you think exists in the parent class (Item) actually exists), but is not necessary for functionality. Use it anyway, though, to save yourself a lot of headaches.

Link to comment
Share on other sites

I was gonna write same as above but noticed he's (op) trying to setMaxStackSize() on vanilla item, alredy registered in game.

 

@Override is used for extended classes.

 

Anyway - There is probably ton of things you could do to make this work, but since 1.7 I have no idea how to do this without bytecode manipulation, and that is (i presume) too hard for you for now.

 

In the old times I would make class extending ItemSword and set Items.diamond_sword to MyItemSword. This worked fine and was quite compatybile (in your case it would be 100% comp). But since there is new registry system as of 1.7 idk if similar thinking would work.

 

Sry, this is not answer to question, but somewhat extension to it.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Yes, I was able to do @Override on extended class...

 

I have not reached a point to start learning bytecode yet, however I wouldn't mind being pointed towards a good tutorial that explains it. I'll start that read when I am comfortable with my Java skills...

 

So is there an easy way to override the vanilla without advanced Java scripting?

Link to comment
Share on other sites

So is there an easy way to override the vanilla without advanced Java scripting?

 

Remove and replace its recipe so that it craft "I can't believe it's not a diamond sword" instead of a diamond sword.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Reflection can do anything.

 

Problem is: you have to know how to do reflection.  I don't believe there are any helper functions for this.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

If you're replacing the recipe to return your custom Item (which isn't a terrible solution, at least any more than changing the vanilla class is), why can't you just override whatever methods you need in your custom class? You shouldn't need ASM or Reflection at all unless you are trying to change the vanilla class.

 

Btw, Forge (FML, actually) does have a ReflectionHelper class, but you still need to know what you're doing to use it.

Link to comment
Share on other sites

Btw, Forge (FML, actually) does have a ReflectionHelper class, but you still need to know what you're doing to use it.

 

I meant a helper for the specific purpose of overwriting vanilla items.  It's a "relatively" common task, but there's no explicit helper function.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Reflection can do anything.

 

Actually no. There are several limitations of reflection.

 

Reflection mostly allows you to change the scope of private fields and methods so they are visible to your own classes.  However, it does not allow you to change the methods' code to operate differently.  In other words, you can call methods that otherwise would have been private, but you're still stuck with the methods available as they are already written.  Furthermore, you can't change scope of things like static final fields.  And so on.

 

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.