Jump to content

Blocks with different behaviour at night?


Captain Hillman

Recommended Posts

Hi all,

 

I'm attempting to create a block that during the day, has a fairly dull texture, but at night changes to an animated texture, lights up and produces particles. So far I've managed to get a single instance of the block to match this behaviour perfectly via metadata, but I can only get to work on one instance. If multiple instances are present, it seems that only one is chosen (seemingly randomly) for an update.

 

I've added the relevant classes below, anyone have any idea how I can get all instances of these blocks to update correctly?

 

Here's the block class

import java.util.Random;

import net.minecraft.block.material.Material;
import net.minecraft.client.Minecraft;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.IIcon;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import uk.co.thisishillman.particles.EntityFXColoredDust;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class BlockMetalPrecious extends CustomBlock {

    private static String[] names;

    private boolean isNight;
    
public BlockMetalPrecious(Material mat, String unlocalizedName, String... subNames) {
	super(mat, unlocalizedName, subNames);
	this.names = subNames;

	//this.setTickRandomly(true);
}

@Override
public void registerRecipe() {
	//TODO
}

@Override
public Item getItemDropped(int meta, Random rand, int fortune) {
        return Item.getItemFromBlock(this);
    }

@Override
public void randomDisplayTick(World world, int x, int y, int z, Random rand) {
	boolean previousState = isNight;
	int meta = world.getBlockMetadata(x, y, z);
	long worldTime = world.getWorldTime();

	if( (worldTime > 13000) && (worldTime < 23000) ) {
		isNight = true;
	} else {
		isNight = false;
	}

	if(previousState != isNight) {
		if(meta == 2 || meta == 3) {

			if(!previousState && isNight) {
				world.setBlock(x, y, z, this, 3, 2);

			} else if(previousState && !isNight) {
				world.setBlock(x, y, z, this, 2, 2);
			}

			world.notifyBlockChange(x, y, z, this);
			System.out.println("Updated block at: " + x + ", " + y + ", " + z);
			//world.markBlockForUpdate(x, y, z);
		}
	}

	if(isNight && meta == 3 && rand.nextInt(10) <= 2) {
		spawnParticle(world, x, y, z);
	}
}

private void spawnParticle(World world, int x, int y, int z) {
        Random random = world.rand;

        for(int side = 0; side < 6; ++side) {
        	
            double d1 = (double) ((float) x + random.nextFloat());
            double d2 = (double) ((float) y + random.nextFloat());
            double d3 = (double) ((float) z + random.nextFloat());

            if(side == 0 && !world.getBlock(x, y + 1, z).isOpaqueCube()) {
                d2 = (double) (y + 1) + 0.0625;
            }

            if(side == 1 && !world.getBlock(x, y - 1, z).isOpaqueCube()) {
                d2 = (double) (y + 0) - 0.0625;
            }

            if(side == 2 && !world.getBlock(x, y, z + 1).isOpaqueCube()) {
                d3 = (double) (z + 1) + 0.0625;
            }

            if(side == 3 && !world.getBlock(x, y, z - 1).isOpaqueCube()) {
                d3 = (double) (z + 0) - 0.0625;
            }

            if(side == 4 && !world.getBlock(x + 1, y, z).isOpaqueCube()) {
                d1 = (double) (x + 1) + 0.0625;
            }

            if(side == 5 && !world.getBlock(x - 1, y, z).isOpaqueCube()) {
                d1 = (double) (x + 0) - 0.0625;
            }

            if(d1 < (double)x || d1 > (double)(x + 1) || d2 < 0.0 || d2 > (double)(y + 1) || d3 < (double)z || d3 > (double)(z + 1)) {
            	
            	EntityFXColoredDust dust = new EntityFXColoredDust(world, d1, d2, d3, 0.0f, 0.0f, 0.0f);
            	dust.setColor(97f/255f, 1f, 227f/255f);
            	Minecraft.getMinecraft().effectRenderer.addEffect(dust);
            }
        }
    }

@Override
public void updateTick(World world, int x, int y, int z, Random rand) {
	randomDisplayTick(world, x, y, z, new Random());
	world.scheduleBlockUpdate(x, y, z, this, 20);
}

@Override
public int getLightValue(IBlockAccess access, int x, int y, int z) {
	int meta = access.getBlockMetadata(x, y, z);
	if(meta == 3) return 15;

	return super.getLightValue(access, x, y, z);
}

@Override
@SideOnly(Side.CLIENT)
public void registerBlock() {
	GameRegistry.registerBlock(this, ItemBlockMetalPrecious.class, super.getUnlocalizedName());
}

@Override
@SideOnly(Side.CLIENT)
    public IIcon getIcon(int side, int meta) {
	return super.getIcon(side, meta);
    }

}
//End of class.

 

And it's abstract parent...

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.IIcon;
import net.minecraft.world.World;
import uk.co.thisishillman.CustomTabs;
import uk.co.thisishillman.Velociraptor;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public abstract class CustomBlock extends Block {

/** Viewable block name (without Mod-ID) */
private final String superName;

/** Viewable sub-block names (without Mod-ID) */
private String[] subNames;

/* */
@SideOnly(Side.CLIENT)
private IIcon[] blockIcons;

/** Initialise a new CustomBlock and register it's unlocalised name.
 * 
 * @param name Viewable block name (without Mod-ID).
 */
public CustomBlock(Material mat, String unlocalizedName, String... subNames) {
	super(mat);
	superName = unlocalizedName;

	if(subNames != null) {
		this.subNames = subNames;
	}

	setBlockName(unlocalizedName);
	setBlockBounds(0.0f, 0.0f, 0.0f, 1.0f, 1.0f, 1.0f);
	setCreativeTab(CustomTabs.materialsTab);
}

@Override
public boolean isOpaqueCube() {
	return true;
}

@Override
public int damageDropped (int metadata) {
	return metadata;
}

@SideOnly(Side.CLIENT)
@Override
public void registerBlockIcons(IIconRegister iconRegister) {
	if(subNames == null) {
		blockIcons = new IIcon[1];
		blockIcons[0] = iconRegister.registerIcon(Velociraptor.ID + ":" + superName);

	} else {
		blockIcons = new IIcon[subNames.length];
		for(int i = 0; i < subNames.length; i++) {
			blockIcons[i] = iconRegister.registerIcon(Velociraptor.ID + ":" + superName + "." + subNames[i]);
		}
	}
}

@Override
@SideOnly(Side.CLIENT)
    public IIcon getIcon(int side, int meta) {
	return blockIcons[meta];
    }

@Override
public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) {
        return new ArrayList<ItemStack>(Arrays.asList(new ItemStack(this, 1, metadata)));
    }

@SideOnly(Side.CLIENT)
@Override
public void getSubBlocks(Item item, CreativeTabs creativeTabs, List list) {
	for(int i = 0; i < subNames.length; i++) {
		list.add(new ItemStack(this, 1, i));
	}
}

/** This method should call the GameRegistry.registerItem() method to 
 * register the item within MineCraft.
 * 
 * @param The mod-unique name of the item.
 */
public abstract void registerBlock();

/** This method should call the GameRegistry class to register the 
 * appropriate (if any) crafting recipe(s). */
public abstract void registerRecipe();

}
//End of class.

 

And the ItemBlock class if that helps...

import net.minecraft.block.Block;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;

public class ItemBlockMetalPrecious extends ItemBlock {

/** Viewable sub-block names (without Mod-ID) */
private String[] subNames = new String[] {"mithril", "tilkal", "ithildin_unlit", "ithildin_lit"};

public ItemBlockMetalPrecious(Block block) {
	super(block);
	setHasSubtypes(true);
}

@Override
public int getMetadata(int damageValue) {
	return damageValue;
}

@Override
public String getUnlocalizedName(ItemStack itemstack) {
	if(subNames == null) {
		return getUnlocalizedName();
	}
	return getUnlocalizedName() + "." + subNames[itemstack.getItemDamage()];
}


}
//End of class.

Link to comment
Share on other sites

Oi!  Blocks are singleton classes!  This won't work!

 

if(previousState != isNight) <-- the first block will see this as true, then the second block will see it as false!

 

You can't store additional data at the block level, that's what metadata is for.  If metadata isn't sufficient, then you must use a TileEntity.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • KILAT77 : Waspada Situs Scam dengan Withdraw Yang Tidak Dibayar Di era digital saat ini, banyak orang yang mencari keberuntungan melalui situs perjudian online. Namun, dibalik gemerlap janji-janji manis kemenangan, ada bahaya yang mengintai. Salah satu situs yang patut diwaspadai adalah KILAT77. Situs ini mendapat reputasi buruk karena banyak laporan dari pengguna yang mengklaim bahwa mereka tidak bisa menarik dana kemenangan mereka. Dalam artikel ini, kita akan membahas mengapa ROTER88 dianggap sebagai situs scam dan bagaimana Anda bisa melindungi diri dari penipuan serupa. Pengalaman Pengguna: Penarikan Tidak Dibayar Beberapa pengguna telah melaporkan pengalaman buruk mereka dengan KILAT77. Mereka mengaku bahwa setelah memenangkan sejumlah uang dan mencoba menariknya, proses penarikan mereka ditolak tanpa alasan yang jelas. Bahkan, beberapa pengguna melaporkan bahwa akun mereka tiba-tiba diblokir setelah mencoba melakukan penarikan, sehingga mereka kehilangan akses ke dana mereka sama sekali.
    • It is a dupe mod issue Remove Rubidium - you are already using Embeddium which is a fork of Rubidium
    • I made a block entity in forge 1.20.1, I want to prevent hopper from taking input slot item, i tried to override the extractItem method, it prevented hopper from taking input slot item, but the player also unable to take/change the item in input slot unless the slot is empty. public class FluidSeparatorBlockEntity extends BlockEntity implements MenuProvider { private static final int INPUT_SLOT = 0; private final CustomItemHandler itemHandler = new CustomItemHandler(3){ @Override protected void onContentsChanged(int slot) { setChanged(); } @Override public boolean isItemValid(int slot, @NotNull ItemStack stack) { return slot == INPUT_SLOT; } @Override public @NotNull ItemStack extractItem(int slot, int amount, boolean simulate) { if (slot == INPUT_SLOT) { return ItemStack.EMPTY; } return super.extractItem(slot, amount, simulate); } }; private LazyOptional<IItemHandler> lazyItemHandler = LazyOptional.empty(); protected final ContainerData data; private int progress = 0; private int maxProgress = 78; public FluidSeparatorBlockEntity(BlockPos pPos, BlockState pBlockState) { super(ModBlockEntities.FLUID_SEPARATOR_BE.get(), pPos, pBlockState); this.data = new ContainerData() { @Override public int get(int pIndex) { return switch (pIndex) { case 0 -> FluidSeparatorBlockEntity.this.progress; case 1, 2 -> FluidSeparatorBlockEntity.this.maxProgress; default -> 0; }; } @Override public void set(int pIndex, int pValue) { switch (pIndex) { case 0 -> FluidSeparatorBlockEntity.this.progress = pValue; case 1, 2 -> FluidSeparatorBlockEntity.this.maxProgress = pValue; } } @Override public int getCount() { return 3; } }; } @Override public @NotNull <T> LazyOptional<T> getCapability(@NotNull Capability<T> cap, @Nullable Direction side) { if(cap == ForgeCapabilities.ITEM_HANDLER) { return lazyItemHandler.cast(); } return super.getCapability(cap, side); } @Override public void onLoad() { super.onLoad(); lazyItemHandler = LazyOptional.of(() -> itemHandler); } @Override public void invalidateCaps() { super.invalidateCaps(); lazyItemHandler.invalidate(); } public void drops() { SimpleContainer inventory = new SimpleContainer(itemHandler.getSlots()); for(int i = 0; i < itemHandler.getSlots(); i++) { inventory.setItem(i, itemHandler.getStackInSlot(i)); } Containers.dropContents(this.level, this.worldPosition, inventory); } @Override public Component getDisplayName() { return Component.translatable("block.chemmaster.fluid_separator"); } @Nullable @Override public AbstractContainerMenu createMenu(int pContainerId, Inventory pPlayerInventory, Player pPlayer) { return new FluidSeparatorMenu(pContainerId, pPlayerInventory, this, this.data); } @Override protected void saveAdditional(CompoundTag pTag) { pTag.put("inventory", itemHandler.serializeNBT()); pTag.putInt("fluid_separator.progress", progress); super.saveAdditional(pTag); } @Override public void load(CompoundTag pTag) { super.load(pTag); itemHandler.deserializeNBT(pTag.getCompound("inventory")); progress = pTag.getInt("fluid_separator.progress"); } public void tick(Level pLevel, BlockPos pPos, BlockState pState) { ItemStack inputStack = this.itemHandler.getStackInSlot(INPUT_SLOT); if (inputStack.getCount() < 2) { resetProgress(); return; } if(hasRecipe()) { increaseCraftingProgress(); setChanged(pLevel, pPos, pState); if(hasProgressFinished()) { craftItem(); resetProgress(); } } else { resetProgress(); } } private void resetProgress() { progress = 0; } private void craftItem() { Optional<FluidSeparatingRecipe> recipe = getCurrentRecipe(); if (recipe.isPresent()) { List<ItemStack> results = recipe.get().getOutputs(); ItemStack inputStack = this.itemHandler.getStackInSlot(INPUT_SLOT); if (inputStack.getCount() < 2) { // If there are not enough items, do not proceed with crafting return; } // Extract the input item from the input slot this.itemHandler.internalExtractItem(INPUT_SLOT, 2, false); // Loop through each result item and find suitable output slots for (ItemStack result : results) { int outputSlot = findSuitableOutputSlot(result); if (outputSlot != -1) { this.itemHandler.setStackInSlot(outputSlot, new ItemStack(result.getItem(), this.itemHandler.getStackInSlot(outputSlot).getCount() + result.getCount())); } else { // Handle the case where no suitable output slot is found // This can be logging an error, throwing an exception, or any other handling logic System.err.println("No suitable output slot found for item: " + result); } } } } private int findSuitableOutputSlot(ItemStack result) { // Implement logic to find a suitable output slot for the given result // Return the slot index or -1 if no suitable slot is found for (int i = 0; i < this.itemHandler.getSlots(); i++) { // Ensure we do not place the output item in the input slot if (i == INPUT_SLOT) { continue; } ItemStack stackInSlot = this.itemHandler.getStackInSlot(i); if (stackInSlot.isEmpty() || (stackInSlot.getItem() == result.getItem() && stackInSlot.getCount() + result.getCount() <= stackInSlot.getMaxStackSize())) { return i; } } return -1; } private boolean hasRecipe() { Optional<FluidSeparatingRecipe> recipe = getCurrentRecipe(); if (recipe.isEmpty()) { return false; } List<ItemStack> results = recipe.get().getOutputs(); for (ItemStack result : results) { if (!canInsertAmountIntoOutputSlot(result) || !canInsertItemIntoOutputSlot(result.getItem())) { return false; } } return true; } private Optional<FluidSeparatingRecipe> getCurrentRecipe(){ SimpleContainer inventory = new SimpleContainer(this.itemHandler.getSlots()); for (int i = 0; i < itemHandler.getSlots(); i++) { inventory.setItem(i, this.itemHandler.getStackInSlot(i)); } return this.level.getRecipeManager().getRecipeFor(FluidSeparatingRecipe.Type.INSTANCE, inventory, level); } private boolean canInsertAmountIntoOutputSlot(ItemStack result) { for (int i = 1; i < this.itemHandler.getSlots(); i++) { ItemStack stackInSlot = this.itemHandler.getStackInSlot(i); if (stackInSlot.isEmpty() || (stackInSlot.getItem() == result.getItem() && stackInSlot.getCount() + result.getCount() <= stackInSlot.getMaxStackSize())) { return true; } } return false; } private boolean canInsertItemIntoOutputSlot(Item item) { for (int i = 1; i < this.itemHandler.getSlots(); i++) { ItemStack stackInSlot = this.itemHandler.getStackInSlot(i); if (stackInSlot.isEmpty() || stackInSlot.getItem() == item) { return true; } } return false; } private boolean hasProgressFinished() { return progress >= maxProgress; } private void increaseCraftingProgress() { progress++; } }  
    • No dice. Unfortunately this fix didn't work, thank you though.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.