[1.7.10] Check If Birch Is In Hand?

[Bugzoo]

I want to check if Birch wood is in the players hand

 if(hand.getItem() == Blocks.log)

I have this code, but I get an error and thats oak and not birch

[larsgerrits]

1) hand can be null, so check if it's not before calling

hand.getItem()

2) you can't compare Items to Blocks. Use

hand.getItem() == Item.getItemFromBlock(Blocks.log)

.

3) if you can check if

hand.getItemDamage()

is the damage of birch wood.

[Bugzoo]

1) hand can be null, so check if it's not before calling

hand.getItem()

2) you can't compare Items to Blocks. Use

hand.getItem() == Item.getItemFromBlock(Blocks.log)

.

3) if you can check if

hand.getItemDamage()

is the damage of birch wood.

 

Ok, that works for oak wood, but how do I do it for birch using hand.getItemDamage?

[larsgerrits]

hand.getItemDamage() == birch damage

Hard???

[Bugzoo]

hand.getItemDamage() == birch damage

Hard???

 

I've got that, but now I need to consume the birch wood

 player.inventory.consumeInventoryItem(Item.getItemFromBlock(Blocks.log));

[Bugzoo]

Just set the current item slot (player.inventory.currentItem) to null.

 

Tried this and it crashed my game

player.inventory.currentItem = (Integer) null;

[Bugzoo]

*facedesk*

 

Of course that will throw an exception. Learn about autoboxing.

You need to set the Slot to null, not the currentItem field.

 

Lol, well how do I get the slot?

[Bugzoo]

InventoryPlayer implements IInventory so it has setInventorySlotContents.

 

I've got this code

player.inventory.setInventorySlotContents(int, itemstack);

So what arguments do I have to put in?

[Draco18s]

The number of the slot you wish to change....and null.

[Bugzoo]

The number of the slot you wish to change....and null.

 

Thanks, that works, but now going back in time to this.

 

hand.getItemDamage() == birch damage

Hard???

 

I've got this code

if(hand.getItem() == Item.getItemFromBlock(Blocks.log) && hand.getItemDamage() == 1)

 

But this doesn't work

[Draco18s]

Describe how it doesn't work.  What seems to be the issue?

[Bugzoo]

Describe how it doesn't work.  What seems to be the issue?

 

It runs the method if you right click with any type of wood

[larsgerrits]

You mean, it goes inside the if statements, as it shouldn't. But the method you have that if statement in, of course it will run it for every type of wood because you haven't checked for birch specifically.

[Bugzoo]

You mean, it goes inside the if statements, as it shouldn't. But the method you have that if statement in, of course it will run it for every type of wood because you haven't checked for birch specifically.

 

How do I check for birch specifically?

[larsgerrits]

Show the full method with that if-statement. The method is probably run for EVERYTHING, and if you check for birch wood, it should only go inside that if-statement if so.

[Bugzoo]

Show the full method with that if-statement. The method is probably run for EVERYTHING, and if you check for birch wood, it should only go inside that if-statement if so.

 

if(player.getCurrentEquippedItem() != null)
      {
     ItemStack hand = player.getCurrentEquippedItem();
     
     if(hand.getItem() == Item.getItemFromBlock(Blocks.log) && hand.getItemDamage() == 1)
     {
    player.inventory.addItemStackToInventory(new ItemStack(Blocks.log, 1, 1));
    player.inventory.consumeInventoryItem(Item.getItemFromBlock(Blocks.log));
	RenderGranter.isAnimated = true;
	RenderGranter.renderOak = true;
	System.out.println(hand.getItem().getMetadata(1));
	world.spawnEntityInWorld((new EntityLightningBolt(world, x, y+1, z)));
	world.createExplosion((Entity)player, (double)x, (double)y, (double)z, 2F, false);
	}
}
}

[larsgerrits]

Full method, so including the method name and its signatures.

[Bugzoo]

Full method, so including the method name and its signatures.

 

public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int par6, float par7, float par8, float par9){
  if(player.getCurrentEquippedItem() != null)
      {
     ItemStack hand = player.getCurrentEquippedItem();
     
     if(hand.getItem() == Item.getItemFromBlock(Blocks.log) && hand.getItemDamage() == 1)
     {
    player.inventory.addItemStackToInventory(new ItemStack(Blocks.log, 1, 1));
    player.inventory.consumeInventoryItem(Item.getItemFromBlock(Blocks.log));
	RenderGranter.isAnimated = true;
	RenderGranter.renderOak = true;
	System.out.println(hand.getItem().getMetadata(1));
	world.spawnEntityInWorld((new EntityLightningBolt(world, x, y+1, z)));
	world.createExplosion((Entity)player, (double)x, (double)y, (double)z, 2F, false);
	}
}
}

 

 

[larsgerrits]

Ok, that method is called for EVERY time you right click on the block. But it shouldn't go inside the if-statement.

[Bugzoo]

Ok, that method is called for EVERY time you right click on the block. But it shouldn't go inside the if-statement.

 

Ok, the way my code works, is if you right click with a birch log it runs the code within the if statement, so why shouldn't it go in the if statement?

[larsgerrits]

Sorry for that, little unclear. I mean, only if you are holding birch wood, it would go into the if-statement, else it shouldn't.

[Bugzoo]

Sorry for that, little unclear. I mean, only if you are holding birch wood, it would go into the if-statement, else it shouldn't.

 

Yea, thats what i'm trying to do, but that code doesn't work. It runs the method no-matter what log it is

[larsgerrits]

Does it go INSIDE(!) the if-statement if holding, for example, oak log?

[Bugzoo]

Does it go INSIDE(!) the if-statement if holding, for example, oak log?

 

Yea, so this if statement

 

 if(hand.getItem() == Item.getItemFromBlock(Blocks.log))

 

Runs the code no-matter what log it is. I only want it to run if it is birch

[Draco18s]

You need to add the metadata check, duh.