[1.7.10] Check If Birch Is In Hand?

[Bugzoo]

You need to add the metadata check, duh.

 

I know that, but how do I check the metadata?

[Draco18s]

hand.getItemDamage() == 1

 

?

[Bugzoo]

hand.getItemDamage() == 1

 

?

 

That doesn't work.

[Draco18s]

Describe how it doesn't work.  What seems to be the issue?

[Bugzoo]

Describe how it doesn't work.  What seems to be the issue?

 

I just noticed something. That line of code does work. So if I did

 

 if(hand.getItemDamage() == 0)

 

The if statement would run, only if the block is Spruce or Dark Oak. Though if I do this

 

 if(hand.getItem() == Item.getItemFromBlock(Blocks.log) && hand.getItemDamage() == 0)

 

It runs no-matter what log it is.

[Draco18s]

Just above that if statement, put this:

 

System.out.println("Right clicked with: " + hand.getItem() + ":" + hand.getItemDamage());
System.out.println(hand.getItem() == Item.getItemFromBlock(Blocks.log));
System.out.println(hand.getItemDamage() == 0);
System.out.println((hand.getItem() == Item.getItemFromBlock(Blocks.log) && hand.getItemDamage() == 0));

 

Then tell me what it prints out when you use various blocks.

[FLUFFY2]

For the love of god, why not just simply use java correctly?

 

if(entityplayer.getCurrentEquippedItem() != null && (entityplayer.getCurrentEquippedItem().getItem() == Item.getItemFromBlock(Blocks.log) && entityplayer.getCurrentEquippedItem().getItemDamage() == 2))

 

Bugzoo i see you are new to this so i just give you a simple advice. Use the vanilla src!

 

[Bugzoo]

Just above that if statement, put this:

 

System.out.println("Right clicked with: " + hand.getItem() + ":" + hand.getItemDamage());
System.out.println(hand.getItem() == Item.getItemFromBlock(Blocks.log));
System.out.println(hand.getItemDamage() == 0);
System.out.println((hand.getItem() == Item.getItemFromBlock(Blocks.log) && hand.getItemDamage() == 0));

 

Then tell me what it prints out when you use various blocks.

 

When I right click with oak it prints this

 

[com.bugzoo.GranterMod.BlockGranter:onBlockActivated:50]: Right clicked with: net.minecraft.item.ItemMultiTexture@1c29de2:0
true
true
true

 

When I right click with any other type of log it prints out this

 

[com.bugzoo.GranterMod.BlockGranter:onBlockActivated:50]: Right clicked with: net.minecraft.item.ItemMultiTexture@1c29de2:3
true
false
false

 

 

[Draco18s]

Ok, now make your code look like this:

 

System.out.println("Right clicked with: " + hand.getItem() + ":" + hand.getItemDamage());
System.out.println(hand.getItem() == Item.getItemFromBlock(Blocks.log));
System.out.println(hand.getItemDamage() == 0);
System.out.println((hand.getItem() == Item.getItemFromBlock(Blocks.log) && hand.getItemDamage() == 0));
if(hand.getItem() == Item.getItemFromBlock(Blocks.log) && hand.getItemDamage() == 0) {
    System.out.println("Right clicked with the right block!");//this is the only new line

 

And give me the output again.

[Bugzoo]

For the love of god, why not just simply use java correctly?

 

if(entityplayer.getCurrentEquippedItem() != null && (entityplayer.getCurrentEquippedItem().getItem() == Item.getItemFromBlock(Blocks.log) && entityplayer.getCurrentEquippedItem().getItemDamage() == 2))

 

Bugzoo i see you are new to this so i just give you a simple advice. Use the vanilla src!

 

OMFG! I just realized I was running another if statement somewhere in the method which checked if the block was a log, and if it was it ran some code. That was the problem. But, on a sidenote, i'm not new to this. I have been programming in java for 4 years, programming minecraft mods for 2 years. Published 3 mods. So, i'm not really new to this.

[Draco18s]

And now you know why we use trace statements.  They tell you what the program is doing as it does it, and lets you locate the problem area of code rather than BLINDLY GUESSING.

[Bugzoo]

And now you know why we use trace statements.  They tell you what the program is doing as it does it, and lets you locate the problem area of code rather than BLINDLY GUESSING.

 

Yea, so sorry about so much fuss over me being blind https://www.youtube.com/watch?v=YhSXAyybEIM