Jump to content

[SOLVED]Custom building not spawning


NeoSup2130

Recommended Posts

I'm having trouble with my custom building, it doesn't spawn

 

Code:

 

 

 

 

}

private void generateSurface(World world, Random random, int x, int z) {

 

//Generate Assassin Tower

BiomeGenBase biome = world.getWorldChunkManager().getBiomeGenAt(x, z);

 

if((biome == BiomeGenBase.plains)){

}else if((biome == BiomesVZ.biomeLivingLand)){

}else if((biome == BiomesVZ.biomeVampireLand)){

}else if((biome == BiomeGenBase.forest)){

 

for (int a = 0; a < 1; a++ ) {

int i = x + random.nextInt(256);

int k = z + random.nextInt(256);

int j = world.getHeightValue(i, k);

new BAssassinTowerSchematic().generate(world, random, i, k, j);

 

 

 

Or it's just badluck that i'm having

 

VampZ modder

Link to comment
Share on other sites

It seems you don't understand the

else if

statement in Java.

 

What your code does:

 

if(biome == BiomeGenBase.plains)
{
    //Do nothing
}
else if(biome == BiomesVZ.biomeLivingLand)
{
    //Also do nothing
}else if(biome == BiomesVZ.biomeVampireLand)
{
    //Do nothing again
}else if(biome == BiomeGenBase.forest)
{
    ... //Generatino

 

Perhaps what you meant was

if(biome == BiomeGenBase.plains || biome == BiomesVZ.biomeLivingLand || biome == BiomesVZ.biomesVampireLand || biome == BiomeGenBase.forest)
{
    //Generate here.
}

BEFORE ASKING FOR HELP READ THE EAQ!

 

I'll help if I can. Apologies if I do something obviously stupid. :D

 

If you don't know basic Java yet, go and follow these tutorials.

Link to comment
Share on other sites

Ok i change it

 

 

 

private void generateSurface(World world, Random random, int x, int z) {

     

      //Generate Assassin Tower

            BiomeGenBase biome = world.getWorldChunkManager().getBiomeGenAt(x, z);

           

              if((biome == BiomeGenBase.plains)){

             

              for (int a = 0; a < 1; a++ ) {

                  int i = x + random.nextInt(256);

                  int k = z + random.nextInt(256);

                  int j = world.getHeightValue(i, k); 

                  new BAssassinTowerSchematic().generate(world, random, i, k, j);

                 

              }

             

              }else if((biome == BiomesVZ.biomeLivingLand)){

              for (int a = 0; a < 1; a++ ) {

                  int i = x + random.nextInt(256);

                  int k = z + random.nextInt(256);

                  int j = world.getHeightValue(i, k); 

                  new BAssassinTowerSchematic().generate(world, random, i, k, j);

                 

              }

              }else if((biome == BiomesVZ.biomeVampireLand)){

              for (int a = 0; a < 1; a++ ) {

                  int i = x + random.nextInt(256);

                  int k = z + random.nextInt(256);

                  int j = world.getHeightValue(i, k); 

                  new BAssassinTowerSchematic().generate(world, random, i, k, j);

                 

              }

              }else if((biome == BiomeGenBase.forest)){

              for (int a = 0; a < 1; a++ ) {

                  int i = x + random.nextInt(256);

                  int k = z + random.nextInt(256);

                  int j = world.getHeightValue(i, k); 

                  new BAssassinTowerSchematic().generate(world, random, i, k, j);

                 

              }

 

 

But it's still not generating

VampZ modder

Link to comment
Share on other sites

Do this:

 

Perhaps what you meant was

if(biome == BiomeGenBase.plains || biome == BiomesVZ.biomeLivingLand || biome == BiomesVZ.biomesVampireLand || biome == BiomeGenBase.forest)
{
    //Generate here.
}

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

You also don't seem to get the concept of "generate in this chunk."

 

int i = x + random.nextInt(256);

 

The chunk says, "Why yes, I would like to generate this structure.  178 blocks west and 212 north.  Yes, that's 12 chunks ata way.  What do you mean its a different biome?  I don't care.  Enjoy!"

 

And also what that other guy said.  Seriously.  Copy-pasting the same lines into four places in your code is BadTM

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

So, I went 178 blocks west and 212 blocks north. I didn't find it...

 

...nor, apparently, do you understand the concept of random numbers.

 

(And my bad, it would be somewhere South and East, but not 178/212 blocks except by sheer coincidence)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

And you also don't know how big a chunk is, do you?

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

And you also don't know how big a chunk is, do you?

 

Ik weet wel hoe groot een chunk is

 

Het is 16 keer 16 keer 256

 

I know how big a chunk is

 

A chunk is 16 by 16 by 256

Then why do you do

random.netInt([b]256[/b])

?

 

(also, this is an english forum, and lets keep it this way)

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

One of your problems is that it's not generating IN the chunk being processed.  Because your x and z location values are NO WHERE NEAR the chunk.  It's off generating in Never Never Land and you don't know why.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Uh huh.

 

And now its your job to take off the training wheels, look at the code, and figure out what it is that it's doing that you don't want it to do.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

generateInOverworld(...)

generateSurface(...)

 

That naming.  I applaud.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

generateInOverworld(...)

generateSurface(...)

 

 

It wasn't the naming but this

 

 

public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {

 

switch(world.provider.dimensionId) {

case -1:

generateInNether(world, random, chunkX*16, chunkZ*16);

break;

case 0:

                        break;

generateInOverworld(world, random, chunkX*16, chunkZ*16);

        case 1:

generateSurface(world, random, chunkX*16, chunkZ*16);

 

 

1 stands for dimensionID and 1 is the end

VampZ modder

Link to comment
Share on other sites

generateInOverworld(...)

generateSurface(...)

 

 

It wasn't the naming but this

 

1 stands for dimensionID and 1 is the end

 

Uh huh.  But with those function names, you confused "surface" and "overworld" when it should clearly be "end" and "overworld"

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

generateInOverworld(...)

generateSurface(...)

 

 

It wasn't the naming but this

 

1 stands for dimensionID and 1 is the end

 

Uh huh.  But with those function names, you confused "surface" and "overworld" when it should clearly be "end" and "overworld"

 

Yeah you are right

I was learing java today and i got by the case 1; lesson (Yes i'm learning java right now and you just helped a java dummie)

 

A picture :D

 

 

VampZ modder

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.