Player rotation pitch and yaw

[Asweez]

Ok so I know how to get the player's pitch and yaw, but the world can't be remote (!world.isRemote). However, I want to use the players rotation to add velocity, but the player.addVelocity method won't work when the world isn't remote. How would I do this?

[Asweez]

Does anyone know?

[Draco18s]

If you absolutely positively can't do it on the server, then you need packets.  Game set match.

[Asweez]

Packets. Yay

[coolAlias]

You can also change the player's motionX/Y/Z fields directly on the server, but it is usually better to handle player motion on the client.

[Asweez]

Ok so I have my packets set up but where would I put the player.addVelocity? Would it be in the handler? And where would the player's rotation amounts be inserted? Would they be a parameter for the packet or calculated during message handling?

[Draco18s]

  On 12/29/2014 at 4:32 PM, coolAlias said:

You can also change the player's motionX/Y/Z fields directly on the server, but it is usually better to handle player motion on the client.

 

Correction:

You want to do it on both.

 

If you do it client-side-only then the server will go "hey buddy, you're over here" and rubber band you back.

If you do it server-side-only the client will lag-behind and you'll rubber band the other way.

[coolAlias]

  On 12/29/2014 at 5:30 PM, Draco18s said:

  Quote

You can also change the player's motionX/Y/Z fields directly on the server, but it is usually better to handle player motion on the client.

 

Correction:

You want to do it on both.

 

If you do it client-side-only then the server will go "hey buddy, you're over here" and rubber band you back.

If you do it server-side-only the client will lag-behind and you'll rubber band the other way.

The rubber-band effect typically happens if you use setPosition type methods on the client, but changing motion actually works just fine. You can still get an 'illegal stance' warning if player's total motion is too high, though, whether or not you set it on the server, the client, or both.

 

Generally it is better to do things on both sides if possible, but in this case I don't think it really matters that much since the client is sending motion updates to the server anyway (see EntityClientPlayerMP#sendMotionUpdates).

[Asweez]

Ok so what do I do?

[coolAlias]

Can you show us what you have so far?

[Asweez]

Ya:

 

PacketHandler

 

  Reveal hidden contents

package 
;

import com.apmods.accupack.AccuPack;

import cpw.mods.fml.common.network.NetworkRegistry;
import cpw.mods.fml.common.network.simpleimpl.SimpleNetworkWrapper;
import cpw.mods.fml.relauncher.Side;

public class AccuNetwork {
public static SimpleNetworkWrapper network ;
public static void init(){
	network = NetworkRegistry.INSTANCE.newSimpleChannel(AccuPack.MODID);
	registerPackets();
}
public static void registerPackets(){
	network.registerMessage(JetpackFlyPacket.class, JetpackFlyPacket.JetpackFlyMessage.class, 0, Side.SERVER);
	network.registerMessage(JetpackFlyPacket.class, JetpackFlyPacket.JetpackFlyMessage.class, 0, Side.CLIENT);
}
}

 

 

JetpackFlyPacket:

 

 

  Reveal hidden contents

package com.apmods.accupack.network;

import io.netty.buffer.ByteBuf;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.world.World;

import com.apmods.accupack.network.JetpackFlyPacket.JetpackFlyMessage;

import cpw.mods.fml.common.network.simpleimpl.IMessage;
import cpw.mods.fml.common.network.simpleimpl.IMessageHandler;
import cpw.mods.fml.common.network.simpleimpl.MessageContext;
import cpw.mods.fml.relauncher.Side;

public class JetpackFlyPacket implements IMessageHandler<JetpackFlyMessage, IMessage>{

@Override
public IMessage onMessage(JetpackFlyMessage message, MessageContext ctx) {

	return null;
}
public class JetpackFlyMessage implements IMessage{

	public JetpackFlyMessage(){

	}
	@Override
	public void fromBytes(ByteBuf buf) {


	}

	@Override
	public void toBytes(ByteBuf buf) {


	}

}

}

(empty as of now)

 

KeyHandler:

 

 

  Reveal hidden contents

package com.apmods.accupack;

import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayer;

import com.apmods.accupack.network.AccuNetwork;
import com.apmods.accupack.network.JetpackFlyPacket;

import cpw.mods.fml.common.eventhandler.SubscribeEvent;
import cpw.mods.fml.common.gameevent.InputEvent.KeyInputEvent;

public class KeyHandler {
@SubscribeEvent
public void keyInput(KeyInputEvent event){
	Minecraft mc = Minecraft.getMinecraft();
	if(KeyBindings.jetpackFly.isPressed()){
		if(mc.inGameHasFocus){
			AccuNetwork.network.sendToServer(new JetpackFlyPacket.JetpackFlyMessage());
			//Error above "No enclosing instance of type JetpackFlyPacket is accessible. 
			// Cont. Must qualify the allocation with an enclosing instance of type JetpackFlyPacket 
			// Cont. (e.g. x.new A() where x is an instance of JetpackFlyPacket)."
		}
	}
}
}

 

 

KeyBindings:

 

  Reveal hidden contents

package com.apmods.accupack;

import org.lwjgl.input.Keyboard;

import net.minecraft.client.settings.KeyBinding;

public class KeyBindings {
public static final KeyBinding jetpackFly = new KeyBinding("AccuPack Fly Key", Keyboard.KEY_SPACE, "key.categories.accupack");
}

 

 

Init method:

 

  Reveal hidden contents

@EventHandler
    public void preInit(FMLPreInitializationEvent event){
    	proxy.preInit();
    	AccuNetwork.init();
    }
    @EventHandler
    public void init(FMLInitializationEvent event)
    {
    	proxy.init();
    	
    }

(edited for the important parts)

 

Tell me if you need anything else

[coolAlias]

So what exactly is it you are wanting to do, fly? KeyInputEvent fires once when a key is pressed and once when it is released, but not at all in between, so you'll need to set some variable somewhere like 'isBoosting' then add player.motionY += 0.15D or whatever each tick if it's true. You could of course just check if the key is still pressed using the keybinding instance, but that is client side only.

[crackedEgg]

You're welcome to have a look at the code for my parachute mod. I think it does something like what you want to do.

https://github.com/m1k3s/parachute

[Asweez]

  On 12/31/2014 at 12:43 PM, crackedEgg said:

You're welcome to have a look at the code for my parachute mod. I think it does something like what you want to do.

https://github.com/m1k3s/parachute

Ok so I see something is going on in method func_180426_a that might be useful. What does that method do?

[crackedEgg]

func_180426_a used to be setPositionAndRotation2

[Asweez]

Why do they change the names?

[DeadPix]

  On 12/31/2014 at 6:07 PM, Asweez said:

Why do they change the names?

Expand  

Most likely to make development more user friendly. I believe the original names func_xxx are a result of decompilation, and the new names are user friendly aliases for them. 

Edited May 22, 2018 by DeadPix