Search the Forums BEFORE making a new post.

[1.7.10] Prevent Item From Falling in Liquid

Posted February 4, 201510 yr

Hey guys,

How can I prevent an item from falling in a liquid. This is the code I have now but the item just seems to jump around and stuff:

package me.mrkirby153.KCNerfer.playTime;

import net.minecraft.block.Block;
import net.minecraft.block.BlockLiquid;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class IndestructibleItem extends EntityItem {

    private final EntityPlayer owner;

    public IndestructibleItem(EntityPlayer owner, World world, double x, double y, double z, ItemStack itemStack) {
        super(world, x, y, z, itemStack);
        this.isImmuneToFire = true;
        this.owner = owner;
    }

    public boolean canPickup(EntityPlayer player) {
        return player.getCommandSenderName().equalsIgnoreCase(this.owner.getCommandSenderName());
    }

    @Override
    public boolean isEntityInvulnerable() {
        return true;
    }

    @Override
    public boolean canRenderOnFire() {
        return false;
    }

    @Override
    public void onUpdate() {
        super.onUpdate();
        Block currentBlock = worldObj.getBlock((int) Math.floor(posX), (int) Math.floor(posY), (int) Math.floor(posZ));
        if (currentBlock == null)
            return;
        if (currentBlock instanceof BlockLiquid) {
            posY += 1;
//            System.out.println("in liquid");
        }
    }
}

http://i.imgur.com/gWwyMMO.jpg[/img]

Quote

February 4, 201510 yr

Hey guys,

How can I prevent an item from falling in a liquid. This is the code I have now but the item just seems to jump around and stuff:

package me.mrkirby153.KCNerfer.playTime;

import net.minecraft.block.Block;
import net.minecraft.block.BlockLiquid;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class IndestructibleItem extends EntityItem {

    private final EntityPlayer owner;

    public IndestructibleItem(EntityPlayer owner, World world, double x, double y, double z, ItemStack itemStack) {
        super(world, x, y, z, itemStack);
        this.isImmuneToFire = true;
        this.owner = owner;
    }

    public boolean canPickup(EntityPlayer player) {
        return player.getCommandSenderName().equalsIgnoreCase(this.owner.getCommandSenderName());
    }

    @Override
    public boolean isEntityInvulnerable() {
        return true;
    }

    @Override
    public boolean canRenderOnFire() {
        return false;
    }

    @Override
    public void onUpdate() {
        super.onUpdate();
        Block currentBlock = worldObj.getBlock((int) Math.floor(posX), (int) Math.floor(posY), (int) Math.floor(posZ));
        if (currentBlock == null)
            return;
        if (currentBlock instanceof BlockLiquid) {
            posY += 1;
//            System.out.println("in liquid");
        }
    }
}

try setting the velocity to 0.

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Quote

February 5, 201510 yr

Author

Hey guys,

How can I prevent an item from falling in a liquid. This is the code I have now but the item just seems to jump around and stuff:

package me.mrkirby153.KCNerfer.playTime;

import net.minecraft.block.Block;
import net.minecraft.block.BlockLiquid;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class IndestructibleItem extends EntityItem {

    private final EntityPlayer owner;

    public IndestructibleItem(EntityPlayer owner, World world, double x, double y, double z, ItemStack itemStack) {
        super(world, x, y, z, itemStack);
        this.isImmuneToFire = true;
        this.owner = owner;
    }

    public boolean canPickup(EntityPlayer player) {
        return player.getCommandSenderName().equalsIgnoreCase(this.owner.getCommandSenderName());
    }

    @Override
    public boolean isEntityInvulnerable() {
        return true;
    }

    @Override
    public boolean canRenderOnFire() {
        return false;
    }

    @Override
    public void onUpdate() {
        super.onUpdate();
        Block currentBlock = worldObj.getBlock((int) Math.floor(posX), (int) Math.floor(posY), (int) Math.floor(posZ));
        if (currentBlock == null)
            return;
        if (currentBlock instanceof BlockLiquid) {
            posY += 1;
//            System.out.println("in liquid");
        }
    }
}

try setting the velocity to 0.

That didn't work. It still glitches around.

http://i.imgur.com/gWwyMMO.jpg[/img]

Quote

February 5, 201510 yr

Well if you actually go and look at the onUpdate function of EntityItem, you'd see why.

this.motionY -= 0.03999999910593033D;
this.moveEntity(this.motionX, this.motionY, this.motionZ);

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

February 6, 201510 yr

Author

Well if you actually go and look at the onUpdate function of EntityItem, you'd see why.
this.motionY -= 0.03999999910593033D;
this.moveEntity(this.motionX, this.motionY, this.motionZ);

I see that the entity is still having its y axis position lowered. However, this doesn't really explain how to arrest the movement of an item.

http://i.imgur.com/gWwyMMO.jpg[/img]

Quote

February 6, 201510 yr

You know what the code does.

You know that the code runs.

What do you have to do such that when the code does what it does when it runs will it have the effect of stopping the motion?

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

February 6, 201510 yr

Author

You know what the code does.

You know that the code runs.

What do you have to do such that when the code does what it does when it runs will it have the effect of stopping the motion?

Okay. I saw that the entity was being moved down by 0.03999999910593033D so I tried conteracting that by moving it up by 0.03999999910593033D (The same number), but the item still glitches around. Code now:

@Override
    public void onUpdate() {
        super.onUpdate();
        Block currentBlock = worldObj.getBlock((int) Math.floor(posX), (int) Math.floor(posY), (int) Math.floor(posZ));
        /*if (currentBlock == null)
            return;
        if (currentBlock instanceof BlockLiquid) {
            this.motionY += 0.03999999910593033D;
            this.moveEntity(motionX, motionY, motionZ);
        }
        Block blockBelow = worldObj.getBlock((int) Math.floor(posX), (int) Math.floor(posY -1), (int) Math.floor(posZ));
        if(blockBelow instanceof BlockLiquid){
            this.motionY += 0.03999999910593033D;
            this.moveEntity(motionX, motionY, motionZ);
        }*/
        this.motionY += 0.03999999910593033D;
        this.moveEntity(motionX, motionY, motionZ);
    }

http://i.imgur.com/gWwyMMO.jpg[/img]

Quote

February 6, 201510 yr

I included two lines, but you really only need to do one thing. (Note: I haven't done something like this myself)

Try

public void onUpdate() {
    Block blockBelow = worldObj.getBlock((int) Math.floor(posX), (int) Math.floor(posY -1), (int) Math.floor(posZ));
        if(blockBelow instanceof BlockLiquid){
            this.motionY = 0.03999999910593033D;
        }
    super.onUpdate();
}

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

February 7, 201510 yr

Author

I included two lines, but you really only need to do one thing. (Note: I haven't done something like this myself)

Try

public void onUpdate() {
    Block blockBelow = worldObj.getBlock((int) Math.floor(posX), (int) Math.floor(posY -1), (int) Math.floor(posZ));
        if(blockBelow instanceof BlockLiquid){
            this.motionY = 0.03999999910593033D;
        }
    super.onUpdate();
}

Hilariously, that still made the item bounce around. Does this have to deal with client/server syncing?

http://i.imgur.com/gWwyMMO.jpg[/img]

Quote

February 7, 201510 yr

Possible. As I said, I haven't really looked into it, but you might be best off completely overriding onUpdate (copy all of the code from super and then edit as needed).

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

February 7, 201510 yr

You would have to give correct acceleration for that, depend on the height from the liquid block.

giving same acceleration when it is over BlockLiquid would just make it glitch around, since it would not be 'smooth'

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/27295-1710-prevent-item-from-falling-in-liquid/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

New Forum Design/Update: Issues and Suggestions

Hiho,

first of all I want to say that the new forum design looks really good.

However, there are currently two issues:

In the "Unread" section, the "Mark all as Read" feature seems to be missing - or am I just overlooking it somewhere?
Some threads don’t automatically get marked as read when you open them. So the post still shows up in "Unread," even though you’ve already viewed it.
Example Thread: https://forums.minecraftforge.net/topic/159415-cannot-find-client-log-entries/

Then I have a smaller suggestion, referring to the Text Editor:

It is possible to move out the "Inline Code"-Feature from the "More Formatting Options" and add it directly to the Text Editor Tool Bar?
Same for "Quote"-Feature inside the Create Section

These two features are used quite often (at least by me) - as far as I remember, they were also available in the old forum design.

@Paint_Ninja @LexManos

By TileEntity · Posted 49 minutes ago49 min
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

That fixed it! it's still being weird and not actually printing anything to CMD but the logs look fine and eventually the gui generated looking normal. Thanks for your help I've done that on linux before but windows servers have always just worked with one click for some reason for me

By Linksapprentice · 3 hours ago3 hr
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Make sure you are using Java 17 JDK

In the start script, replace the word "java" with the java 17 path (javaw.exe) and put it into quotation marks

By TileEntity · 6 hours ago6 hr
NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

There are client-side-only mods in your server - start with removing justenoughbreeding

By TileEntity · 6 hours ago6 hr
NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

Hey there, I have a big modpack I'm trying to run that I've put together with two other rather large communities- we have a grand opening scheduled for next week so it's really important that this gets solved ASAP.

The game runs fine in singleplayer, but when trying to run as a server using a hosting website, I've run into quite a massive error log. I've whittled it down to this point- I'm currently not sure what to do, as I believe the main error is relating to the datapack message, but I don't know for sure. Removing the datapack folder doesn't change the message either.

https://mclo.gs/2aTdXII

If the fix is something very simple, I apologize. I'm not too experienced with hosting websites and running large modpacks like this on a server.
I'm also not completely sure of which mods are client-only- a large handful of which are already disabled but I could be missing some. I just don't know which ones they would be, if that's causing the issue.

By nyxxiea · Posted 11 hours ago11 hr

TileEntity

Sign In

[1.7.10] Prevent Item From Falling in Liquid

Featured Replies

Join the conversation

Posts

New Forum Design/Update: Issues and Suggestions

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)