[1.7.10][Solved]Getting item that is currently held by player

[Enginecrafter]

I have a block that is called Password Lock.

I am currently adding a wrench, that when used on this block, it dismantles it(sets it to air and drops it).

But I don't know how to get Item, that is currently held by player. I will use it at onBlockActivated when It is held (and the current player is it's owner), don't open the gui, but dismantle.

When I used player.inventory.getCurrentItem().equals(ItemWrench.item) it always returned false.

[Draco18s]

ItemStack will never equal Item.

 

Also, as soon as the player's hand is empty and that code runs, the game will crash with a Null Pointer Exception.

[Failender]

You could also just use the onItemRightClick from the wrench, which might be a better solution

[Enginecrafter]

Sorry, I made a mistake in first post. It was player.inventory.getCurrentItem().equals(new ItemStack(ItemWrench.item)).

But I solved it another way.

I converted them from ItemStack to Item.

 

Item currentItem = player.inventory.getCurrentItem().getItem();
boolean hasWrench = currentItem.equals(ItemWrench.item)

 

And, I have a tile entity for this block. I want to get owner(that is set when is block placed) and compare it with player, who is trying to dismantle the block.

I used:

TileEntityPasswordLock tile = (TileEntityPasswordLock)world.getTileEntity(bX, bY, bZ);

	String playerName = new String(player.getCommandSenderName());
	String owner = tile.owner;
	boolean isOwner = owner == playerName;

And it always returned false.

 

When I used .equal(something) insteaded of == it throws an error.

[Failender]

You could also check if its != null and then check if its equals.. That way you wont get a NPE

[Draco18s]

Called it.

 

the game will crash with a Null Pointer Exception.

[Enginecrafter]

And, how can I set player's air level (small bubbles displayed when player si in water)

[Draco18s]

And, how can I set player's air level (small bubbles displayed when player si in water)

 

You can't.

http://www.minecraftforge.net/forum/index.php/topic,27370.0.html

http://www.minecraftforge.net/forum/index.php?topic=27608.0.html

http://www.minecraftforge.net/forum/index.php?topic=14587.0.html

[Enginecrafter]

Ok. All problems solved.

[Enginecrafter]

And, simple question about forums.

Must I delete my topic when it was solved or I can simply leave it for other users?