[1.7.10] Weird World Time issue

[Thornack]

I have a tile entity that gets the world time. The method description says that this time wraps from 23999 to 0 and the then counts back to 23999. However that is not what I find when I try to use it. When I print it to consol the world time is additive past 23999 it seems forever.Any ideas why the time doesnt wrap?

 

My Tile Entities updateEntity method

 

 

 

@Override
public void updateEntity() {

	long time = this.worldObj.getWorldInfo().getWorldTime();//gets the world time of day
        System.out.println("world time is " + time);
       
	if ((time == 1 || time == 8001 || time == 16001) && !worldObj.isRemote){ //gets specific world time
		//DO STUFF HERE
	}

}

 

 

 

in the //DO STUFF HERE section the stuff I do stops happening cause of the world time issue where the time doesnt wrap.

[Edit] I solved the previous stuff that was posted below this it was a stupid error on my part

 

[Thornack]

I solved the issue by doing

 

if (time >=24000){

  this.worldObj.getWorldInfo().setWorldTime(0);

  }

but it is still weird why it wont wrap on its own like the method description says it should

[Ernio]

You shouldn't be manipulating world values. This value (worldTime) is not actually used much in vanilla, but still someone might be using it in mod.

Simply do: time % 24000L, don't set it.

 

And btw.:

it is still weird why it wont wrap on its own like the method description says it should

What description? (There is nothing that says it should)

[Draco18s]

Yeah, don't screw with that value.

 

I'm actually using it right now and I expect it to go above 23999 in order to provide seasonal shifts.

[Thornack]

The Comment above the getWorldTime() method says

 **
     * Get current world time
     */
    public long getWorldTime()
    {
        return this.worldTime;
    }

"

 

and the comment above the worldTime says

/** The current world time in ticks, ranging from 0 to 23999. */
    private long worldTime;

 

which is why I expected it to wrap from 23999 back to 0

[Draco18s]

That may have been true once, but if you look at

    /**
     * Set current world time
     */
    public void setWorldTime(long p_76068_1_)
    {
        this.worldTime = p_76068_1_;
    }

in the same class, you'd notice that it doesn't enforce the note in the javadoc (which was written by someone contributing to MCP, not Mojang).

 

And if you trace all usages back around to the things that actually make it go up, you'll notice a continuous lack of any %24000 math, except here in WorldServer.java:

 

public void tick() {
        //...
        if (this.areAllPlayersAsleep()) {
            if (this.getGameRules().getGameRuleBooleanValue("doDaylightCycle")) {
                long i = this.worldInfo.getWorldTime() + 24000L;
                this.worldInfo.setWorldTime(i - i % 24000L);
            }
            this.wakeAllPlayers();
        }
        //...
}

 

Which goes out of its way to insure that the value isn't truncated to 23999.