Would that work ?

[FloeyGh]

package com.Floey.Core;

 

import net.minecraft.world.World;

import net.minecraft.world.gen.feature.WorldGenerator;

 

import java.util.Random;

 

public class IWorldGen extends WorldGenerator

{

 

    @Override

    public boolean generate(World p_76484_1_, Random p_76484_2_, int p_76484_3_, int p_76484_4_, int p_76484_5_) {

        for (int l = 0; l < 10; ++l)

        {

            int i1 = p_76484_3_ + p_76484_2_.nextInt[nobbc]([/nobbc] - p_76484_2_.nextInt[nobbc]([/nobbc];

            int j1 = p_76484_4_ + p_76484_2_.nextInt(4) - p_76484_2_.nextInt(4);

            int k1 = p_76484_5_ + p_76484_2_.nextInt[nobbc]([/nobbc] - p_76484_2_.nextInt[nobbc]([/nobbc];

 

            if (p_76484_1_.isAirBlock(i1, j1, k1))

            {

                int l1 = 1 + p_76484_2_.nextInt(p_76484_2_.nextInt(1) + 1);

 

                for (int i2 = 0; i2 < l1; ++i2)

                {

                    if (Registry.blockSharpStone.canBlockStay(p_76484_1_, i1, j1 + i2, k1))

                    {

                        p_76484_1_.setBlock(i1, j1 + i2, k1, Registry.blockSharpStone, 0, 2);

                    }

                }

            }

        }

 

        return true;

    }

}

 

[FloeyGh]

= 8 )

[FloeyGh]

Thanks

 

I would like my block in the world Spawns but I have no idea how to do it

[FloeyGh]

I do not understand 

[Awesome_Spider]

name your variables from p_76484_2 to something more understandable.

[Draco18s]

alt-shift-r does wonders.

[FloeyGh]

package com.Floey.Core;

import net.minecraft.world.World;
import net.minecraft.world.gen.feature.WorldGenerator;

import java.util.Random;

public class IWorldGen extends WorldGenerator
{

    @Override
    public boolean generate(World Chunk, Random Random, int BlockX, int BlockY, int BlockZ) {
        for (int l = 0; l < 10; ++l)
        {
            int i1 = BlockX + Random.nextInt( - Random.nextInt(;
            int j1 = BlockY + Random.nextInt(4) - Random.nextInt(4);
            int k1 = BlockZ + Random.nextInt( - Random.nextInt(;

            if (Chunk.isAirBlock(i1, j1, k1))
            {
                int l1 = 1 + Random.nextInt(Random.nextInt(1) + 1);

                for (int i2 = 0; i2 < l1; ++i2)
                {
                    if (Registry.blockSharpStone.canBlockStay(Chunk, i1, j1 + i2, k1))
                    {
                        Chunk.setBlock(i1, j1 + i2, k1, Registry.blockSharpStone, 0, 2);
                    }
                }
            }
        }

        return true;
    }
}

Better ?

[md678685]

What are i1, j1 and k1?

 

(Tip: you can disable smileys by clicking on "Attachments and other options" before posting.)

[larsgerrits]

You still have those

i1

,

j1

and

k1

variables.

[FloeyGh]

no Idea

[md678685]

You should find a tutorial which explains things thoroughly, and make sure you actually read everything else, not just the code. You clearly didn't write that yourself, or else you would know what those variables are.

[jcranky]

Giving the topic a nicer (more descriptive) name would be helpful as well.

[FloeyGh]

package com.Floey.Core;

 

import net.minecraft.world.World;

import net.minecraft.world.gen.feature.WorldGenerator;

 

import java.util.Random;

 

public class IWorldGen extends WorldGenerator

{

 

    @Override

    public boolean generate(World world, Random Random, int BlockX, int BlockY, int BlockZ) {

        for (int l = 0; l < 10; ++l)

        {

            int x = BlockX + Random.nextInt( - Random.nextInt(;

            int y = BlockY + Random.nextInt(4) - Random.nextInt(4);

            int z = BlockZ + Random.nextInt( - Random.nextInt(;

 

            if (world.isAirBlock(x, y, z))

            {

                int l1 = 1 + Random.nextInt(Random.nextInt(1) + 1);

 

                for (int i2 = 0; i2 < l1; ++i2)

                {

                    if (Registry.blockSharpStone.canBlockStay(world, x, y + i2, z))

                    {

                        world.setBlock(x, y + i2, z, Registry.blockSharpStone, 0, 2);

                    }

                }

            }

        }

 

        return true;

    }

}

 

but now

[Draco18s]

 int l1 = 1 + Random.nextInt(Random.nextInt(1) + 1);

 

l1 (which is a bad variable name) will always be 1.  A random number from 0 (inclusive) to 1 (exclusive) will always be 0.  0 + 1 = 1, rand(1) again will always be 0.  0 + 1 = 1, l1 is 1.

 

And I don't know what the problem is.  You didn't say.  That said,

BlockX, BlockY, and BlockZ

are not block locations, they're chunk locations.  You need to multiply them by 16 before you do anything with them.

[FloeyGh]

Can't they just give me the right code? pls

[Draco18s]

Can't they just give me the right code? pls

 

Nope.

[sham1]

Can't they just give me the right code? pls

 

That's not what modding is about.

 

We can guide you but you do all the stuff by yourself.

[FloeyGh]

Why ? D:

[Draco18s]

Modding requires basic programming knowledge. If you are not willing to spend some time learning at least the basics, you should not make a mod. Nobody will write your mod for you.

 

Well they could.  Bud you'd have to pay them.

I get paid about $25 an hour for my workjob, but freelance I'd charge $250/hr.

[FloeyGh]

public class IWorldGen implements IWorldGenerator {

    @Override

    public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {

        int xMin = chunkX << 4;

        int zMin = chunkZ << 4;

 

        int startX = xMin + random.nextInt(16);

        int startZ = zMin + random.nextInt(16);

 

        int tries = random.nextInt(2);

 

        for (int i = 0; i < tries; i++) {

            int x = startX + random.nextInt( - random.nextInt(;

            int z = startZ + random.nextInt( - random.nextInt(;

            int y = world.getHeightValue(x, z);

 

            if ((world.isAirBlock(x, y, z) || (world.getBlock(x, y, z) == Blocks.snow)) && Registry.blockSharpStone.canBlockStay(world, x, y, z)) {

                if (random.nextInt(50) > 1)

                    continue;

 

                world.setBlock(x, y, z, Registry.blockSharpStone, 0, 0);

            }

        }

    }

}

 

For the code? 0.0

[Draco18s]

Your second set of randoms, inside the for-loop, can cause (almost certainly will cause) the "I am generating in this chunk" to decide "nope, I'm generating in the next chunk."  Drop the +random(16) from the definition of startX and startZ and instead put them in place of the rand(8 ) - rand(8 )

 

Secondly, your maximum number of tries shouldn't be random if you're just going to discard 98% of the valid positions (and a countless number of invalid ones).  To boot, you're trying "at most one time."

[FloeyGh]

public class IWorldGen implements IWorldGenerator {

    @Override

    public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {

        int xMin = chunkX << 4;

        int zMin = chunkZ << 4;

 

        int startX = xMin- random.nextInt(;

        int startZ = zMin - random.nextInt(;

 

        int tries = random.nextInt(2);

 

        for (int i = 0; i < tries; i++) {

            int x = startX + random.nextInt( - random.nextInt(;

            int z = startZ + random.nextInt( - random.nextInt(;

            int y = world.getHeightValue(x, z);

 

            if ((world.isAirBlock(x, y, z) || (world.getBlock(x, y, z) == Blocks.snow)) && Registry.blockSharpStone.canBlockStay(world, x, y, z)) {

                if (random.nextInt(50) > 1)

                    continue;

 

                world.setBlock(x, y, z, Registry.blockSharpStone, 0, 0);

            }

        }

    }

}

 

is it ok ?

[Draco18s]

No

[FloeyGh]

How then ?

[jcranky]

Use the [ code] tags.