[1.7.10] NBT persistent saving issue - adding additional player data

coolAlias · April 18, 2015

What we are trying to get at is 'Why save the entity twice?' Either tie the entity to the ItemStack, or tie it to the player, but not both.

Example A: Tied to ItemStack

- Save the entity into the ItemStack NBT

- When the player uses the item or whatever and you spawn the entity, pass the player as an argument much like setting the 'owner' of the entity, and use whatever fields from player / your player's IEEP that you need within the entity class to determine its abilities.

- Example: each player has a power level that increases as they gain experience; this is stored in the player's IEEP, and the entity uses the player's power level to modify its attack damage.

Example B: Tied to Player

- ItemStack is subtyped by ID, where each ID is mapped to an entity type

- E.g. 1 = Pikachu, 2 = Charzard, etc.

- The actual entity data is stored in the player's IEEP, probably as an NBTTagCompound until you actually summon it, at which point you should convert it into a real entity

- When the player right clicks with whatever egg, it uses the item's damage value (the stack subtype) to fetch the correct entity data from the player, which then creates the entity

There are advantages and disadvantages to each design, but you MUST figure out your design and explain EXACTLY what you are trying to do in plain English (i.e. no code). If you can't explain it in simple terms, you are going to have a very difficult time implementing anything that does what you want.

Draco18s · April 18, 2015

Panel 2

http://imgs.xkcd.com/comics/well_2.png[/img]

Thornack · April 19, 2015

The reason why I need the entity tied to both the itemstack and upon item pick up the entity gets tied to the player and the itemstack NBT is cleaned up is because the eggs can be stolen by other players. if an egg is stolen then this initiates a quest that is unique to the player that originally caught the entity. In order to get my quest to work properly, in the way that I want it to, I have to know how to tie the entity to both the player and the itemstack. The design I want is clear, all I had issues with is getting the entity to save to the player persistently. I mean currently it does "save" as long as the player doesnt log off or die haha but i am trying out a few things to fix this issue, thanks a lot for the suggestions, ill post if and when i get a solution or if i run into more issues.

coolAlias · April 19, 2015

IEEP is by its very nature persistent for each player - it automatically calls your save and load NBT data methods for the correct player each time they log in.

However, if you do not implement those two methods correctly, then you cannot expect your data to be correct - your save NBT code:

for(int i=0; i < NUM_SLOTS; i++){
                System.out.println("test equals " + test);
         if(partyNbt != null){
            properties.setTag("Slot"+i, partyNbt); // <-- isn't partyNbt an array?
         }
      }

Looks like you simply made a mistake there - your 'partyNbt' field is an array, but you try to save the array reference rather than the actual element. Needs to be 'partyNbt'. Might want to double-check everywhere else that you access this field, such as the load method.

Thornack · April 19, 2015

Ya I saw that and fixed it but the NBt data still isnt persistent not sure why. I also tried passing in the player as a parameter

[but doing this presented a problem] when I pass the player as a Parameter I get Null for all slots of my party. Below is my tryToAddMobToParty method with the player passed in as a parameter and my getPartyMember method that is located inside the IEEP class.

I tried to outprint both the Minecraft.getMinecraft.thePlayer and the passed in player and I get the following outprints to consol. What is werid is that if I use Minecraft.getMinecraft.thePlayer the slots are not null when the getPartyMember(); method is called and they contain the NBT data of each unique instance of my entity. if |I used the passed in player the getPartyMember(); outprints null for all slots.

Player is EntityPlayerMP['Player845'/247, l='New World', x=1109.00, y=4.00, z=392.58]

Minecraft.getMinecraft.thePlayer is EntityClientPlayerMP['Player845'/247, l='MpServer', x=1109.00, y=5.62, z=392.58]

public void tryToAddMobToParty(EntityPlayer player){
                System.out.println("Player is " + player);
                System.out.println("Minecraft.getMinecraft.thePlayer is " + Minecraft.getMinecraft.thePlayer);

	PlayerParty pp = PlayerParty.get(player);// instead of PlayerParty pp = PlayerParty.get(Minecraft.getMinecraft.thePlayer);
	System.out.println("free slot? " + pp.hasFreeSlot());
	if(pp.hasFreeSlot() == true){
	pp.setPartyMember(pp.getNextFreeSlot(), this.hitEntity);	
	System.out.println(this.hitEntity + " saved to slot " + pp.getNextFreeSlot());
	}else{
		this.displayChatMessage(EnumChatFormatting.RED + "Your Party Is Currently Full!");
		System.out.println("next free slot " + pp.getNextFreeSlot());//should return -1 at this point because party is full [works]
		pp.getPartyMember(0);
		System.out.println("first in party " + pp.getPartyMember(0));
		pp.getPartyMember(1);
		System.out.println("second in party " + pp.getPartyMember(1));
		pp.getPartyMember(2);
		System.out.println("thirdt in party " + pp.getPartyMember(2));
		pp.getPartyMember(3);
		System.out.println("fourth in party " + pp.getPartyMember(3));
		pp.getPartyMember(4);
		System.out.println("fifth in party " + pp.getPartyMember(4));
		pp.getPartyMember(5);
		System.out.println("sixth in party " + pp.getPartyMember(5));
	}
}

Whats weird is if the party is full and if i pass in the player rather than using Minecraft.getMinecraft.thePlayer then the getPartyMember method doesnt return null and then immediately the next tick it is null again... but what is weird also is that if i try to add another party member the NBT data is still there I know this because the UUID's that get printed dont change...

get member in slot0null

get member in slot1null

get member in slot2null

get member in slot3null

get member in slot4null

get member in slot5null

next free slot -1

first mob in party {DropChances:[...

second mob in party {DropChances:[...

thirdt mob in party {DropChances:[...

fourth mob in party {DropChances:[...

sixth mob in party {DropChances:[...

get member in slot1null

get member in slot2null

get member in slot3null

get member in slot4null

get member in slot5null

public NBTTagCompound getPartyMember(int slot){
System.out.println("get member in slot" + slot + partyNbt[slot]);
	return partyNbt[slot];
}

I get Null for all slots all the time if I pass in the player but if I use Minecraft.getMinecraft then all is fine and dandy

Draco18s · April 19, 2015

Scrap all of your IEEP code right now and go back to saving something simple, like an integer or a string.

Figure out how it works first, doing one simple piece, then expand to encompass all the data you actually want. That way when you go from "well it saved a string" to "but it didn't save an array of strings" you can puzzle out why, rather than going, "fuck this doesn't work."

coolAlias · April 19, 2015

On 4/19/2015 at 9:40 PM, Thornack said:

I also fixed the getting client player on server by passing it as a parameter

... I really don't understand what your obsession is with using the client-side version of the player. That makes absolutely no sense, and is very likely part of your problem.

There is a server-side version of every entity, including each player, and that is the one you want; the client side is purely for rendering and that kind of stuff - it is NOT where you want to manipulate / store data.

Ernio · April 19, 2015

By fixing it, I THINK he ment that he followed my post and actually made it work on server side. Just a thought.

Thornack, hint for you - NBT can be printed using Syso (System.out.println). Put Syso on start and end of write and read NBT. Basically - debug as long as you understand it (Draco's right).

If you won't find it on your own - does your readNBT actually have some NBT (in Syso)?

Thornack · April 19, 2015

I do understand it and I already have an IEEP class that adds a stamina bar already and that is persistent and the NBT saves and I am actually using that as a gude to try and get this working. What I am trying to do is waaaay more complicated than a simple stamina bar and hence why I am debugging rather than going backwards.

I made my player server side like you suggested and I pass the player in. I put the client and server side player in my debug message to see what the differences were and if you read my last post you can see them. I put what the consol outprints when I try the client player and I also put what it outprints when I try the passed in player (This is the server player I believe that is obtained using the getThrower method inside my class that extends EntityThrowable)

I will try the outprints inside the save and load NBT that you suggested and see what I get.

coolAlias · April 20, 2015

Where is this tryToAddMobToParty method located at, and where are you calling it from?

If it is in your IEEP class, then you should already have a reference to the correct player needed as a class field; if it is in your Item class, you need to make sure you are calling the method on the server only (i.e. when the world is NOT remote), otherwise your method gets called both on the client and the server, and any information you print out on the client is likely to be all null.

The point being that we need as much context as you can give us if you want to solve your issue anytime soon.

Thornack · April 20, 2015

Before catching 1 entity all my slots are null which is expected

Reveal hidden contents

After catching 1 entity all slots seem to be given data which is weird Id expect only slot 0 to get data and the rest to be null

Reveal hidden contents

[16:45:10] [server thread/INFO] Before setting tag 0{}

[16:45:10] [server thread/INFO] After setting tag 0{Slot 0:{

[16:45:10] [server thread/INFO] PROP 0{Slot 0:{.....NBT Data......

[16:45:10] [server thread/INFO] Before setting tag 1{Slot 0:{.....NBT Data (same as above)......

[16:45:10] [server thread/INFO] PROP 1{Slot 0:{.....NBT Data (same as above)......

[16:45:10] [server thread/INFO] Before setting tag 2{Slot 0:{.....NBT Data (same as above)......

[16:45:10] [server thread/INFO] PROP 2{Slot 0:{.....NBT Data (same as above)......

[16:45:10] [server thread/INFO] Before setting tag 3{Slot 0:{.....NBT Data (same as above)......

[16:45:10] [server thread/INFO] PROP 3{Slot 0:{.....NBT Data (same as above)......

[16:45:10] [server thread/INFO] Before setting tag 4{Slot 0:{.....NBT Data (same as above)......

[16:45:10] [server thread/INFO] PROP 4{Slot 0:{.....NBT Data (same as above)......

[16:45:10] [server thread/INFO] Before setting tag 5{Slot 0:{.....NBT Data (same as above)......

[16:45:10] [server thread/INFO] PROP 5{Slot 0:{.....NBT Data (same as above)......

[16:45:10] [server thread/INFO] Before setting tag 0{}

[16:45:10] [server thread/INFO] After setting tag 0{Slot 0:{

[16:45:10] [server thread/INFO] PROP 0{Slot 0:{.....NBT Data(same as above)......