[1.7.10] Add to variable on item pickup, then delete the item?

[Ms_Raven]

I want to increase the player's money value when picking up coins, so it's a number on the screen instead of items in the inventory.

 

My first try increased the value on screen, but didn't account for the amount of coins picked up and didn't remove it from the inventory:

@SubscribeEvent
public void pickupItem(EntityItemPickupEvent event)
{
	Item item = event.item.getEntityItem().getItem();
	EntityPlayer player = (EntityPlayer)event.entity;
	ExtendedPlayer props = ExtendedPlayer.get(player);

	if(item == TerraReg.copper_coin)
	{
		props.addMoney(1);
		player.inventory.consumeInventoryItem(TerraReg.copper_coin);
	}
	if(item == TerraReg.silver_coin)
	{
		props.addMoney(10);
		player.inventory.consumeInventoryItem(TerraReg.silver_coin);
	}
	if(item == TerraReg.gold_coin)
	{
		props.addMoney(100);
		player.inventory.consumeInventoryItem(TerraReg.gold_coin);
	}
	if(item == TerraReg.platinum_coin)
	{
		props.addMoney(1000);
		player.inventory.consumeInventoryItem(TerraReg.platinum_coin);
	}
}

 

 

My second try attempted to resolve the amount issue, but instead nothing happens at all now:

@SubscribeEvent
public void pickupItem(EntityItemPickupEvent event)
{
	ItemStack item = event.item.getEntityItem();
	EntityPlayer player = (EntityPlayer)event.entity;
	ExtendedPlayer props = ExtendedPlayer.get(player);

	if(item == new ItemStack(TerraReg.copper_coin))
	{
		props.addMoney(1);
		for(int amount = 0; amount < item.stackSize; amount++)
		{
			player.inventory.consumeInventoryItem(TerraReg.copper_coin);
		}
	}
	if(item == new ItemStack(TerraReg.silver_coin))
	{
		props.addMoney(10);

		for(int amount = 0; amount < item.stackSize; amount++)
		{
			player.inventory.consumeInventoryItem(TerraReg.silver_coin);
		}
	}
	if(item == new ItemStack(TerraReg.gold_coin))
	{
		props.addMoney(100);

		for(int amount = 0; amount < item.stackSize; amount++)
		{
			player.inventory.consumeInventoryItem(TerraReg.gold_coin);
		}
	}
	if(item == new ItemStack(TerraReg.platinum_coin))
	{
		props.addMoney(1000);

		for(int amount = 0; amount < item.stackSize; amount++)
		{
			player.inventory.consumeInventoryItem(TerraReg.platinum_coin);
		}
	}

 

How can I get this to work?

[Draco18s]

First attempt:

You could just cancel the event (prevents the pickup) and kill (

setDead

) the entity.

Second attempt:

That is not how you compare item stacks.

And also what I said about the first attempt.

[Ms_Raven]

Okay, so that works, but then what's the right way to get the stack size?

[HappyKiller1O1]

I've actually tried this and, you can't get the stack size. For some reason, the entityItem doesn't save the stack size so, you just have to set the maxStackSize of the coin to 1 and have it pickup like .5% slower.

[shadowfacts]

For some reason, the entityItem doesn't save the stack size

 

Yes, it does; it saves the ItemStack which contains the stack size. Use EntityItem.getEntityItem(), which returns an ItemStack (it is poorly name) and use ItemStack.stackSize to find the size.

[HappyKiller1O1]

Now see, in theory: that would work. But, when I was debugging it with Erino, the stackSize was ALWAYS 0 when it was picked up.

[Ernio]

You can't retrieve anything from ItemStack that is stored inside picked up EntityItem.

Only thing that is "actually" there is the Item (instance).

 

I tried to learn how and why it is that way. First I though it was something with DataWatchers (which are there), but then, there is this forge code:

public void onCollideWithPlayer(EntityPlayer entityIn)
    {
        if (!this.worldObj.isRemote)
        {
            if (this.delayBeforeCanPickup > 0) return;
            ItemStack itemstack = this.getEntityItem();
            int i = itemstack.stackSize;

            int hook = net.minecraftforge.event.ForgeEventFactory.onItemPickup(this, entityIn, itemstack);

 

Which as you can see directly uses stackSize. It either means that forge/vanilla is actually always getting stackSize=1 (which you get every damn time you'd try to get inside event itself) or that it is handled elsewhere (my guess it is). I wasn't curious enough to look deeper, I don't need it.

 

And yes, I am taunting someone to explain.

 

Link: (the "PROBLEM")

http://www.minecraftforge.net/forum/index.php/topic,29752.msg154028.html#msg154028

 

EDIT

Btw. I know that there are 2 events for picking up, even if one of them actually gives proper ItemStack (which I didn't check, but doubt it does), I still want to know why this one is giving output as it is.