# [1.8] [SOLVED] Ore Generation Questions

## Recommended Posts

Hi,

I have a couple questions about ore generation.

1. Would this code work?

```private void generateSurface(World world, Random random, int chunkX,
int chunkZ) {
for (int i = 0; i < 16; i++) {
int firstBlockXCoord = chunkX + random.nextInt(16);
int firstBlockZCoord = chunkZ + random.nextInt(16);

// Will be found between y = 0 and y = 30
int quisqueY = random.nextInt(35);
BlockPos quisquePos = new BlockPos(firstBlockXCoord, quisqueY,
firstBlockZCoord);
// The 3 is max vein size
(new WorldGenMinable(NuclearCraft.uraniumOre.getDefaultState(), 3))
.generate(world, random, quisquePos);
}
}```

2. If so, about how rare would it be? As rare as diamonds? Iron? Emeralds? Coal?

Thanks for any help.

Sup bruh.

##### Share on other sites

1.No, chunkx/chunkz is the chunk number, not blocks. If you multiplied it by 16 then it would work.

2.It generates every chunk, so it would spawn a vein in every chunk if you didn't use some kind of random statement to limit it.

Also, out of curiosity's sake, why do you have a for loop in that code?

The proud(ish) developer of Ancients

##### Share on other sites

Well, I found this code off of a Reddit post, so it probably has some errors in it (like a for loop).

Also, what would the random statement look like to limit that?

Thanks!

Sup bruh.

##### Share on other sites

Also, here is my new modified code:

```private void generateSurface(World world, Random random, int chunkX,
int chunkZ) {
int firstBlockXCoord = chunkX * 16;
int firstBlockZCoord = chunkZ * 16;

// Will be found between y = 0 and y = 30
int quisqueY = random.nextInt(35);
BlockPos blockPos = new BlockPos(firstBlockXCoord, quisqueY,
firstBlockZCoord);
// The 3 is max vein size
(new WorldGenMinable(NuclearCraft.uraniumOre.getDefaultState(), 3))
.generate(world, random, blockPos);
}```

Sup bruh.

##### Share on other sites

Currently, in my structure generator code I have something like:

```if(RNG.nextInt(100)==50){
//gen code
}
```

In theory, this would generate every 100 chunks, one number out of 100. 50 is just a random number.

Also I used the random that the function provides you with ('RNG').

Also: this is what my x/z code looks like:

```int x = (chunkX*16)+RNG.nextInt(16);
int z = (chunkZ*16)+RNG.nextInt(16);
```

The proud(ish) developer of Ancients

##### Share on other sites

Okay, but how do I set the rarity? If I want it as rare as diamonds, what section of code would be modified?

Sup bruh.

##### Share on other sites

Here is ALL of my code for my block:

```package net.nc.block;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraftforge.fml.common.IWorldGenerator;
import net.nc.NuclearCraft;

public class UraniumOre extends Block implements IWorldGenerator {
public UraniumOre(Material material) {
super(material);
setUnlocalizedName("UraniumOre");
setCreativeTab(CreativeTabs.tabBlock);
}

public void generate(Random random, int chunkX, int chunkZ, World world,
IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
switch (world.provider.getDimensionId()) {
case 0:
generateSurface(world, random, chunkX * 16, chunkZ * 16);
break;
}
}

private void generateSurface(World world, Random random, int chunkX,
int chunkZ) {
if (random.nextInt(2) == 1) {
int x = (chunkX * 16) + random.nextInt(16);
int z = (chunkZ * 16) + random.nextInt(16);

// Will be found between y = 0 and y = 30
int y = random.nextInt(35);
BlockPos blockPos = new BlockPos(x, y, z);
// The 3 is max vein size
(new WorldGenMinable(NuclearCraft.uraniumOre.getDefaultState(), 3))
.generate(world, random, blockPos);
}
}
}```

Sup bruh.

##### Share on other sites

Why does your block class implement IWorldGenerator? You should have one central class that handles the generation of all your ores.

Don't make mods if you don't know Java.

Developer of many mods

##### Share on other sites

Put the if statement around (new WorldGenMinable(NuclearCraft.uraniumOre.getDefaultState(), 3)).generate(world, random, blockPos).

Change the rarity by changing 100 to what ever number you want. The higher, the less chance of it spawning. Just make sure that the second number is less than that number or it won't work.

I don't know the rarity of diamond, so I can't tell you what numbers to put in it specifically.

The proud(ish) developer of Ancients

##### Share on other sites

So I should have 1 class that implements IWorldGenerator, and one only? And where do I call the generate() method?

Sup bruh.

##### Share on other sites

You should have a single class for IWorldGenerator. It has the generate function in it. Make sure you register your generator aswell.

The proud(ish) developer of Ancients

##### Share on other sites

Oh, I forgot to register it!

What should I put for modGenerationWeight when I register it?

Sup bruh.

##### Share on other sites

Here's my OreGenerator class:

```public class OreGenerator implements IWorldGenerator {
@Override
public void generate(Random random, int chunkX, int chunkZ, World world,
IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
generateSurface(world, random, chunkX, chunkZ);
}
private void generateSurface(World world, Random random, int chunkX,
int chunkZ) {
System.out.println();
if (random.nextInt(2) == 1) {
int x = (chunkX * 16) + random.nextInt(16);
int z = (chunkZ * 16) + random.nextInt(16);

// Will be found between y = 0 and y = 30
int y = random.nextInt(35);
BlockPos blockPos = new BlockPos(x, y, z);
// The 3 is max vein size
(new WorldGenMinable(NuclearCraft.uraniumOre.getDefaultState(), 1000))
.generate(world, random, blockPos);
}
}
}```

Registered in the init method:

`GameRegistry.registerWorldGenerator(new OreGenerator(), 0);`

Sup bruh.

##### Share on other sites

For the weight, I generally put 1 but I honestly have no idea what it does (perhaps it's preference over other generators)

The proud(ish) developer of Ancients

##### Share on other sites

For the weight, I generally put 1 but I honestly have no idea what it does (perhaps it's preference over other generators)

```     * @param modGenerationWeight a weight to assign to this generator. Heavy weights tend to sink to the bottom of
* list of world generators (i.e. they run later)
```

So when you have bigger weight value, the generation is called later.

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

## Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

×   Pasted as rich text.   Restore formatting

Only 75 emoji are allowed.

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

• ### Posts

• Thanks, it works! I assumed I couldn't do that because it used mixins on the other mod, but it's fine
• now is working, i never had a issue with modernfix before, thanks
• Could you be more specific please? How are we supposed to use that on .getValue/.containsKey or generally? The item names are suddenly minecraft:minecraft: and it crashes because of that ofc.   Caused by: net.minecraft.ResourceLocationException: Non [a-z0-9/._-] character in path of location: minecraft:minecraft:iron_ingot I politely ask for an explanation for which there is no documentation, not that i found and not that i found one in this topic. Here you would rather be asked to see something complete in front of your face instead of having to experiment stupidly with the API and waste time because some change was made. Thanks in advance. https://docs.minecraftforge.net/en/latest/concepts/resources/#resourcelocation apparently not.. More of <namespace>:minecraft:<path>
• ok i removed it and it works now thanks

• ### Who's Online (See full list)

×

• #### Activity

×
• Create New...