Remove Recipes

[Mikinilsen/MathiasVO053]

hi

 

i'm trying to remove recipes and i can remove vanilla crafting recipes with this:

  public static void RemoveVanillaCraftingRecipes(){

      List<IRecipe> recipes  = CraftingManager.getInstance().getRecipeList();

     

      Iterator<IRecipe> Rem = recipes.iterator();

     

        while(Rem.hasNext()){

            ItemStack stack = Rem.next().getRecipeOutput();

            if(stack != null && stack.getItem() == Items.bread){

              Rem.remove();

            }else if(stack != null && stack.getItem() == Items.mushroom_stew){

              Rem.remove();

            }else if(stack != null && stack.getItem() == Items.pumpkin_pie){

              Rem.remove();                 

            }else if(stack != null && stack.getItem() == Items.golden_carrot){

              Rem.remove();

        }

      } 

  }

but i have no idea about how to remove Smelting recipes... i've tried:

public static void RemoveVanillaFoodFurnaceRecipes(){

      List<IRecipe> recipes  = (List<IRecipe>) FurnaceRecipes.smelting().getSmeltingList();

  Iterator<IRecipe> Rem1 = recipes.iterator();

  while(Rem1.hasNext()){

      ItemStack stack = Rem1.next().getRecipeOutput();

      if(stack != null && stack.getItem() == Items.getItemFromBlock(Blocks.stone)){

        Rem1.remove();

      }

      }

  }

[Mikinilsen/MathiasVO053]

it doesn't? well i'll read the FurnaceRecipes then

[Mikinilsen/MathiasVO053]

ok... i've read it and tried this:

public static void removeFurnaceRecipe() {

Map recipes = FurnaceRecipes.smelting().getSmeltingList();

 

Iterator entries = recipes.entrySet().iterator();

while (entries.hasNext()) {

 

Entry thisEntry = (Entry) entries.next();

  if (thisEntry != null && thisEntry.getKey() == Item.getItemFromBlock(Blocks.stone)) {

entries.remove();

}

}

}

 

but i can't get it to work... what am i doing wrong?

[Mikinilsen/MathiasVO053]

i have no idea how to implement that in my code

[Mikinilsen/MathiasVO053]

ohh... well i've tried with baked potatoes and it still doesn't work...

[Mikinilsen/MathiasVO053]

public static void removeFurnaceRecipe() {

Map recipes = FurnaceRecipes.smelting().getSmeltingList();

 

Iterator entries = recipes.entrySet().iterator();

while (entries.hasNext()) {

 

Entry thisEntry = (Entry) entries.next();

  if (thisEntry != null && thisEntry.getKey() == Items.baked_potato) {

entries.remove();

}

}

}

[Mikinilsen/MathiasVO053]

ohh... but then i'm back to... how do i do this without IRecipe?

[Mikinilsen/MathiasVO053]

yes. i understand this...

but if i try to replace it then it gives errors

[Mikinilsen/MathiasVO053]

public static void removeFurnaceRecipe(ItemStack stack) {

      Map recipes = FurnaceRecipes.smelting().getSmeltingList();

     

      Iterator entries = recipes.entrySet().iterator();

      while (entries.hasNext()) {

       

        Entry thisEntry = (Entry) entries.next();

        if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {

            entries.remove();

        }

      }

  }

[Failender]

look what you wrote, the mistake is really obvious

[SuperJedi224]

For one thing, you are acting as if java 7 doesn't have generics, and I'm reasonably certain that it does.

[Ewe Loon]

I tend not to use Iterator myself (but thats because i didnt grow up with them being there)

to me it looks like you are searching the this of item you put into the furnace , and as far as i know Items.baked_potato comes out, not goes in

 

secondly these 2 things are your friends when dealing with unknowns

 

System.out.println(unknown);

unknown.getClass().getSimpleName();

 

and togeather

System.out.println(unknown.getClass().getSimpleName());

 

 

[Failender]

Plot twist: He is never searching for the item that comes out.

 (stack.getItem() != null && stack.getItem() == Items.baked_potato) 

[KakesRevenge]

Look at TiCon code there is reciperemover class and bunch of usefull stuff in it

[Ewe Loon]

Yes, Failender your right, he isnt testing the recipe at all is he, in or out

 

There are actually 2 major errors

 

both these 2 lines contain the errors

 

 if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();

[SanAndreaP]

Yes, Failender your right, he isnt testing the recipe at all is he, in or out

 

There are actually 2 major errors

 

both these 2 lines contain the errors

 

 if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();

 

Please explain why

entries.remove();

is wrong...

[Ewe Loon]

this is the post he made

public static void removeFurnaceRecipe(ItemStack stack) {
         Map recipes = FurnaceRecipes.smelting().getSmeltingList();
         
         Iterator entries = recipes.entrySet().iterator();
         while (entries.hasNext()) {
            
            Entry thisEntry = (Entry) entries.next();
           if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();
            }
         }
      }

 

problem 1

if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {

this is testing to see what the item passes to the method is not the item from the recipe, in the very first post he actually had this bit correct

 

problem 2

entries.remove();

is removing it from the Iterator not the Recipe HashMap it should be

recipes.remove(thisEntry.getKey());

 

just as a note, removing the items from a hashmap can cause errors while reading through the Map

I would recommend instead of removing immediately create a list of items to remove then remove them after scanning the list

 

like this

public static void removeFurnaceRecipe(ItemStack stack) {
        Map<ItemStack, ItemStack> recipes = FurnaceRecipes.smelting().getSmeltingList();
        LinkedList<ItemStack> remlist=new LinkedList<ItemStack>();
        Iterator<Entry<ItemStack, ItemStack>> entries = recipes.entrySet().iterator();
        while (entries.hasNext()) {
           Entry<ItemStack, ItemStack> thisEntry = (Entry<ItemStack, ItemStack>) entries.next();
           if (ItemStack.areItemStacksEqual(thisEntry.getValue(), stack)) {
        	   remlist.add(thisEntry.getKey());
           }
        }
        for(ItemStack rm:remlist) recipes.remove(rm);
     }

 

 

 

 

 

[SanAndreaP]

this is the post he made

public static void removeFurnaceRecipe(ItemStack stack) {
         Map recipes = FurnaceRecipes.smelting().getSmeltingList();
         
         Iterator entries = recipes.entrySet().iterator();
         while (entries.hasNext()) {
            
            Entry thisEntry = (Entry) entries.next();
           if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {
               entries.remove();
            }
         }
      }

 

problem 1

if (stack.getItem() != null && stack.getItem() == Items.baked_potato) {

this is testing to see what the item passes to the method is not the item from the recipe, in the very first post he actually had this bit correct

 

problem 2

entries.remove();

is removing it from the Iterator not the Recipe HashMap it should be

recipes.remove(thisEntry.getKey());

 

just as a note, removing the items from a hashmap can cause errors while reading through the Map

I would recommend instead of removing immediately create a list of items to remove then remove them after scanning the list

 

like this

public static void removeFurnaceRecipe(ItemStack stack) {
        Map<ItemStack, ItemStack> recipes = FurnaceRecipes.smelting().getSmeltingList();
        LinkedList<ItemStack> remlist=new LinkedList<ItemStack>();
        Iterator<Entry<ItemStack, ItemStack>> entries = recipes.entrySet().iterator();
        while (entries.hasNext()) {
           Entry<ItemStack, ItemStack> thisEntry = (Entry<ItemStack, ItemStack>) entries.next();
           if (ItemStack.areItemStacksEqual(thisEntry.getValue(), stack)) {
        	   remlist.add(thisEntry.getKey());
           }
        }
        for(ItemStack rm:remlist) recipes.remove(rm);
     }

 

You know that updating the iterator (e.g. removing an element) updates the list/map as well!?

 

That's the point of an Iterator... To modify the list/map while iterating through it and not cause a ConcurrentModificationException or needing complicated workaround code.

 

Your code is just overcomplicating the thing the Iterator is there for...

 

This is my code using the iterator to remove elements, it works:

https://github.com/SanAndreasP/ClaySoldiersMod/blob/master/java/de/sanandrew/mods/claysoldiers/entity/EntityClayMan.java#L126-L137

 

 

EDIT: Also what diesieben07 said (I should read the 2nd page before posting <.<)