Jump to content

[1.8] Next recommended release?


jeffryfisher

Recommended Posts

Where should I look in these forums to get a sense of when Forge will reach a recommended release? Where may I see which vanilla build is under each Forge release?

 

I ask because vanilla EntityHanging had a bug in it that was fixed (according to Mojang's bug tracker) in 15w37a, and I am trying to decide whether the fix will come to Forge soon enough that I shouldn't bother with a work-around.

 

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

We don't typically fix bugs in vanilla minecraft that arnt actually real bugs.

And ya.. I should make a RB here soon. Haven't been caring to as we've been working on getting ready for 1.8.9

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

No worries, I didn't expect Forge to fix the vanilla code. I saw that the vanilla code was already fixed in a build that came after the current recommended Forge. When Forge gets around to adopting a Minecraft build at or beyond 15w37a, then the fix will be there.

 

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

Aha... 1.9 is a major mod that probably won't treat existing worlds too kindly, and since Mojang probably won't backport the fix into a 1.8.9 patch, I decided that a work-around for 1.8 was needed. I came up with this simple hangingPosition dodge, which overrides onValidSurface but still calls super:

 

public class classAltPainting extends EntityPainting {
    protected static final boolean MCVERSION_IS_1_8 = Loader.instance ().getMCVersionString ().contains ("1.8");
    static final int[] tilesOff = { -1, 0, 0, 1, 1, 2 }; // Number of rows/cols left or below target
                                                         // (precalculate based on tile width or height, with invalid value at zero)
<snip>

  /**
   * There's a bug in vanilla MC version 1.8. EntityHanging.onValidSurface() scans up and right from hanging position,
   * forgetting that the pos is supposed to be the *center*. Thus the bounding box and checked surface diverge
   * 
   * Fortunately, our bounding box has already been calculated correctly before entering this method. Therefore, we
   * can workaround the bug by temporarily setting hangingPosition to the LL corner (telling a lie), then calling super,
   * and then finally setting hangingPosition back to its canonical value.
   * 
   * Called both by Entity.onUpdate (every 100 ticks) and by classItemAltPainting.onItemUse
   */
  @Override
  public boolean onValidSurface() {        // TODO: Remove in 1.9
    BlockPos pos = this.hangingPosition;   // The real pos
    boolean result;

    if (MCVERSION_IS_1_ {
      this.hangingPosition = pos.offset (this.field_174860_b.rotateY (), tilesOff[canvas.sizeX / 16])  // Tile-cols left of placement
          .offset (EnumFacing.DOWN, tilesOff[canvas.sizeY / 16]);                                      // Tile-rows below placement
    } else {
      System.out.println ("TODO: Delete classAltPainting.onValidSurface method for MC-1.9");
    }
    result = super.onValidSurface ();
    if (MCVERSION_IS_1_ {
      this.hangingPosition = pos;         // Restore correct pos
    }
    return result;
  }

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.