[1.8] Frustrating Missing Textures

[1Poseidon3]

Hey guys. This is more or less directed at Choonster since I used his framework from his test mod as the framework for rendering my models and there are some things I can't figure out and I'm hoping someone can help. Basically, none of the item or block textures are rendering in my inventory or when I hold them in my hand. Though, when I place the block the texture shows up on the block in the world. Why is this happening? It also cannot find the textures for the test liquid I created. I'll post all relevant file code below. Like I said, this looks a lot like Choonsters way of mod creation which I am borrowing to create my own mod. If you don't want me to use your mod framework then I can just start over. If I am allowed to use it, I'll credit you for the framework. Just thought I'd toss that in as a side note.

 

 

TMModelManager.java

 

 

package com.poseidon.testmod.client.model;


import com.poseidon.testmod.init.TMBlocks;
import com.poseidon.testmod.init.TMFluids;
import com.poseidon.testmod.init.TMItems;
import com.poseidon.testmod.util.Constants;
import net.minecraft.block.Block;
import net.minecraft.block.BlockCommandBlock;
import net.minecraft.block.BlockLiquid;
import net.minecraft.block.state.IBlockState;
import net.minecraft.client.renderer.block.statemap.StateMap;
import net.minecraft.client.renderer.block.statemap.StateMapperBase;
import net.minecraft.client.resources.model.ModelBakery;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fluids.FluidStack;
import net.minecraftforge.fluids.IFluidBlock;


import java.util.HashSet;
import java.util.Set;


public class TMModelManager {
public static final TMModelManager INSTANCE = new TMModelManager();


private static final String FLUID_MODEL_PATH = Constants.RESOURCE_PREFIX + "fluid";


private TMModelManager() {}


public void registerAllModels() {
	registerFluidModels();
	//registerBucketModels();


	registerBlockModels();


	registerItemVariants();
	registerItemModels();
}


private void registerFluidModels() {
	TMFluids.fluidBlocks.forEach(this::registerFluidModel);
}


private void registerFluidModel(IFluidBlock fluidBlock) {
	Item item = Item.getItemFromBlock((Block) fluidBlock);


	ModelBakery.addVariantName(item);


	ModelResourceLocation modelResourceLocation = new ModelResourceLocation(FLUID_MODEL_PATH, fluidBlock.getFluid().getName());


	ModelLoader.setCustomMeshDefinition(item, MeshDefinitionFix.create(stack -> modelResourceLocation));


	ModelLoader.setCustomStateMapper((Block) fluidBlock, new StateMapperBase() {
		@Override
		protected ModelResourceLocation getModelResourceLocation(IBlockState p_178132_1_) {
			return modelResourceLocation;
		}
	});
}


private void registerBlockModels() {
	registerBlockItemModel(TMBlocks.test_block, "tm:test_block");


	TMBlocks.blocks.forEach(this::registerBlockItemModel);
}


private void registerBlockItemModel(Block block) {
	registerItemModel(Item.getItemFromBlock(block));
}


private void registerBlockItemModel(Block block, String modelLocation) {
	registerItemModel(Item.getItemFromBlock(block), modelLocation);
}


private void registerItemVariants() {
	for (int stage = 0; stage < 3; stage++) { // Add a variant for each stage's model


	}
}


private Set<Item> itemsRegistered = new HashSet<>();


private void registerItemModels() {
	registerItemModel(TMItems.icon);
	registerItemModel(TMItems.test_item);


	TMItems.items.forEach(this::registerItemModel);
}


private void registerItemModel(Item item) {
	registerItemModel(item, Item.itemRegistry.getNameForObject(item).toString());
}


private void registerItemModel(Item item, String modelLocation) {
	if (!itemsRegistered.contains(item)) {
		itemsRegistered.add(item);


		final ModelResourceLocation fullModelLocation = new ModelResourceLocation(modelLocation, "inventory");
		ModelBakery.addVariantName(item, modelLocation);


		ModelLoader.setCustomMeshDefinition(item, MeshDefinitionFix.create(stack -> fullModelLocation));
	}
}
}

 

 

 

 

TMItems.java

 

 

package com.poseidon.testmod.init;


import net.minecraft.item.*;
import net.minecraftforge.fml.common.registry.GameRegistry;


import java.util.HashSet;
import java.util.Set;


import com.poseidon.testmod.item.Icon;
import com.poseidon.testmod.item.TestItem;


public class TMItems {

public static final Set<Item> items = new HashSet<>();

public static Item icon;
public static Item test_item;

public static void registerItems()
{
	icon = registerItem(new Icon());
	test_item = registerItem(new TestItem());

}

private static <T extends Item> T registerItem(T item) {
	return registerItem(item, item.getUnlocalizedName());
}


private static <T extends Item> T registerItem(T item, String name) {
	GameRegistry.registerItem(item, name);
	items.add(item);
	return item;
}
}

 

 

 

 

TMBlocks.java

 

 

package com.poseidon.testmod.init;


import com.poseidon.testmod.Reference;
import com.poseidon.testmod.block.TestBlock;


import net.minecraft.block.Block;
import net.minecraft.item.ItemBlock;
import net.minecraft.tileentity.TileEntity;
import net.minecraftforge.fml.common.registry.GameRegistry;


import java.util.HashSet;
import java.util.Set;


public class TMBlocks {

public static final Set<Block> blocks = new HashSet<>();

public static Block test_block;

public static void registerBlocks()
{

	test_block = registerBlock(new TestBlock());
}

/**
 * Register a Block with the default ItemBlock class.
 *
 * @param block The Block instance
 * @param <T>   The Block type
 * @return The Block instance
 */
private static <T extends Block> T registerBlock(T block) {
	GameRegistry.registerBlock(block, block.getUnlocalizedName().replaceFirst("tile.", ""));
	blocks.add(block);
	return block;
}


/**
 * Register a Block with a custom ItemBlock class.
 *
 * @param block           The Block instance
 * @param itemClass       The ItemBlock class
 * @param constructorArgs Arguments to pass to the ItemBlock constructor
 * @param <T>             The Block type
 * @return The Block instance
 */
private static <T extends Block> T registerBlock(T block, Class<? extends ItemBlock> itemClass, Object... constructorArgs) {
	GameRegistry.registerBlock(block, itemClass, block.getUnlocalizedName(), constructorArgs);
	blocks.add(block);
	return block;
}


public static void registerTileEntities() {
	//registerTileEntity(HydrogenBlock.class, "hydrogen_block");
	//registerTileEntity(TileEntityFluidTank.class, "fluidTank");
}


private static void registerTileEntity(Class<? extends TileEntity> tileEntityClass, String id) {
	GameRegistry.registerTileEntity(tileEntityClass, Reference.MOD_ID + ":" + id);
}
}

 

 

 

 

TestMod.java

 

 

package com.poseidon.testmod;


import com.poseidon.testmod.init.TMBlocks;
import com.poseidon.testmod.init.TMFluids;
import com.poseidon.testmod.init.TMItems;
import com.poseidon.testmod.proxy.CommonProxy;


import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper;
import net.minecraftforge.fml.common.registry.GameRegistry;


@Mod(modid = Reference.MOD_ID, name = Reference.MOD_NAME, version = Reference.VERSION)
public class TestMod
{

@SidedProxy(clientSide = Reference.CLIENT_PROXY_CLASS, serverSide = Reference.SERVER_PROXY_CLASS)
public static CommonProxy proxy;

public static final TMTab tab = new TMTab("tab");

@Mod.Instance(Reference.MOD_ID)
public static TestMod instance;


public static SimpleNetworkWrapper network;

@EventHandler
public void preInit(FMLPreInitializationEvent event)
{
	TMItems.registerItems();
	TMBlocks.registerBlocks();
	TMFluids.registerFluids();
	proxy.preInit();
} 

@EventHandler
public void init(FMLInitializationEvent event)
{
	proxy.init();
}

@EventHandler
public void postInit(FMLPostInitializationEvent event)
{
	proxy.postInit();
}
}

 

 

 

 

ClientProxy.java

 

 

package com.poseidon.testmod.proxy;


import com.poseidon.testmod.client.model.TMModelManager;
import com.poseidon.testmod.init.TMBlocks;
import com.poseidon.testmod.init.TMItems;


import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraftforge.common.MinecraftForge;


public class ClientProxy extends CommonProxy {

private final Minecraft minecraft = Minecraft.getMinecraft();

@Override
public void preInit() {
	super.preInit();

	TMModelManager.INSTANCE.registerAllModels();
}

@Override
public void doClientRightClick() {
	super.doClientRightClick();

	KeyBinding.onTick(minecraft.gameSettings.keyBindUseItem.getKeyCode());
}

@Override
public EntityPlayer getClientPlayer() {
	return minecraft.thePlayer;
}
}

 

 

 

 

I feel like those are all of the relevant files. I don't think there's anything wrong with the textures or .json files. If anyone could help out that would be awesome. Thanks!

[jeffryfisher]

Have you used log output or the debugger to verify that methods like getNameForObject(item).toString() give output that matches labels used in json files and meshing?

 

And where are your json files? Have you validated them in jsonlint?  Those json files are very fragile and prone to frustrating, hard to see errors. Capitalization, pluralization and even underscores can ruin your day.

 

Finally, I don't see an item model mesher in an init method in your client proxy    IIRC, You can't texture items without item models, and you can't mesh item models before TheMinecraft instance is constructed during the init phase (Your static call to getMinecraft() is probably premature and should return null).

[TrashCaster]

I believe the issue might be registering the items with getUnlocalizedName since that is, by default, going to return whatever name you specified for the item, plus .name

 

Try changing that to a literal string, or use .substring(0,getUnlocalizedName().length()-".name".length()), or something of the sorts.

[Draco18s]

....you mean like length() - 5?

[TrashCaster]

....you mean like length() - 5?

 

Of course. But I wanted to avoid "magic numbers", in case if OP didn't know where the 5 came from.

[Choonster]

Finally, I don't see an item model mesher in an init method in your client proxy    IIRC, You can't texture items without item models, and you can't mesh item models before TheMinecraft instance is constructed during the init phase (Your static call to getMinecraft() is probably premature and should return null).

 

ModelLoader.setCustomModelResourceLocation

and

ModelLoader.setCustomMeshDefinition

can be called during preInit to do the same thing as calling

ItemModelMesher#register

in init.

 

The

Minecraft

instance is created and stored before mod loading starts, though the

ItemModelMesher

instance is only created between preInit and init.

 

1Poseidon3: You're free to use my code within the terms of the MIT License (basically you can do what you want with it as long as you credit me). I don't really mind if you include the credit in every file or just include a line in your license/readme.

[1Poseidon3]

Thanks for all the help guys. I'll try out all of the suggestions now that I have the chance and report back! Also, thanks for the information Choonster. I'll be sure to credit you. 

 

 

EDIT: I forgot to include this in the original post. Here's an error type thing I saw on startup in the console.

 

 

Error

 

 

[19:43:21] [Client thread/ERROR] [FML]: Model definition for location tm:fluid#test_fluid not found
[19:43:21] [Client thread/ERROR] [FML]: Model definition for location tm:item.icon#inventory not found
[19:43:21] [Client thread/ERROR] [FML]: Model definition for location tm:item.test_item#inventory not found
[19:43:21] [Client thread/ERROR] [FML]: Model definition for location tm:test_block#inventory not found