Minecraft 1.7.10 Ore Generation Problems. [Modding]

[jameshyland]

So i have been making a mod for the past week or so and I have stumbled upon problems when generating ores.

 

I have entered the code, but the ores dont show up in game.

 

Here is the code for the ore in question

 

package com.jameshyland.MoneyMod;

 

import java.util.Random;

 

import net.minecraft.block.Block;

import net.minecraft.init.Blocks;

import net.minecraft.world.World;

import net.minecraft.world.chunk.IChunkProvider;

import net.minecraft.world.gen.feature.WorldGenMinable;

import cpw.mods.fml.common.IWorldGenerator;

 

public class OreGeneration implements IWorldGenerator {

 

@Override

public void generate(Random random, int chunkX, int chunkZ, World world,

IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {

switch (world.provider.dimensionId) {

 

case 0:

generateEnd(world, random, chunkX, chunkZ );

break;

case 1:

generateSurface(world, random, chunkX, chunkZ);

break;

case -1:

generateNether(world, random, chunkX, chunkZ);

break;

}

}

 

public void generateEnd(World world, Random rand, int x, int z) {

generateOre(MoneyMod.blockMoneyOre,world, rand, x, z, 5, 20, 65, 20, 250, Blocks.end_stone);

}

 

public void generateSurface(World world, Random rand, int x, int z) {

generateOre(MoneyMod.blockMoneyOre,world, rand, x, z, 5, 20, 65, 20, 250, Blocks.stone);

}

 

public void generateNether(World world, Random rand, int x, int z) {

generateOre(MoneyMod.blockMoneyOre,world, rand, x, z, 5, 20, 65, 20, 250, Blocks.netherrack);

 

}

 

public void generateOre(Block block, World world, Random random,

int chunkX, int chunkZ, int minVeinSize, int maxVeinSize,

int chance, int minY, int maxY, Block generateIn) {

int vienSize = minVeinSize + random.nextInt(maxVeinSize - minVeinSize);

int heightRange = maxY - minY;

WorldGenMinable gen = new WorldGenMinable(block, vienSize, generateIn);

for (int i = 0; i < chance; i++) {

int xRand = chunkX * 16 + random.nextInt(16);

int yRand = random.nextInt(heightRange + minY);

int zRand = chunkZ * 16 + random.nextInt(16);

gen.generate(world, random, xRand, yRand, zRand);

 

}

}

}

 

 

If you could help please do.

 

Thanks.

[Draco18s]

Well, it would help if you generated surface ores in the overworld, end ores in the end, and nether orex in the nether.

 

 

The overworld is dimensipn 0.

 

[jameshyland]

I dont know what the difference is. This is my first mod and i have little to no experience with Java programming so...

Can you please elaborate?

 

[Draco18s]

This code seeds end ores into the overworld.

 

      case 0: // dimension 0 is the overworld
         generateEnd(world, random, chunkX, chunkZ ); // add end ores
         break;

 

Etc.

[jameshyland]

I already have that in the code though.

[Draco18s]

Oh my ducking god.

 

YOUR CODE IS WRONG

[Cerandior]

There is a switch in your world generation class that is checking for the dimension ID. Draco18 spoke very clearly. 0 is the ID number for the overword dimension, however you are using this ID, the id that belongs to the overworld dimension, to generate in the end. At case 0 in the switch you want to execute the generateSurface method not the generateEnd that you are currently using

[jameshyland]

It now looks like this:

 

 

 

case 1:

generateEnd(world, random, chunkX, chunkZ );

break;

case 0:

generateSurface(world, random, chunkX, chunkZ);

break;

case -1:

generateNether(world, random, chunkX, chunkZ);

break;

}

}

 

public void generateEnd(World world, Random rand, int x, int z) {

generateOre(MoneyMod.blockMoneyOre,world, rand, x, z, 2, 10, 5, 0, 100, Blocks.end_stone);

}

 

public void generateSurface(World world, Random rand, int x, int z) {

generateOre(MoneyMod.blockMoneyOre,world, rand, x, z, 2, 10, 5, 0, 100, Blocks.stone);

}

 

public void generateNether(World world, Random rand, int x, int z) {

generateOre(MoneyMod.blockMoneyOre,world, rand, x, z, 2, 10, 5, 0, 100, Blocks.netherrack);

 

}

 

public void generateOre(Block block, World world, Random random,

int chunkX, int chunkZ, int minVeinSize, int maxVeinSize,

int chance, int minY, int maxY, Block generateIn) {

int vienSize = minVeinSize + random.nextInt(maxVeinSize - minVeinSize);

int heightRange = maxY - minY;

WorldGenMinable gen = new WorldGenMinable(block, vienSize, generateIn);

for (int i = 0; i < chance; i++) {

int xRand = chunkX * 16 + random.nextInt(16);

int yRand = random.nextInt(heightRange + minY);

int zRand = chunkZ * 16 + random.nextInt(16);

gen.generate(world, random, xRand, yRand, zRand);

 

 

 

Is that better?

[ovikk]

Yes