Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Block.isAir method - why does it have parameters?

BinaryCrafter

By BinaryCrafter
in Modder Support

 Share

Recommended Posts

BinaryCrafter Tree Puncher

BinaryCrafter

Posted
Posted

Just wondering why the instance method block.isAir (as an example from many methods) takes parameters in the method call, when the instance of the class already has the required properties. I've just looked at the de-obfuscated source code of net.minecraft.block.Block and as I suspected the parameters are unused. There appear to be other examples in this class, and I'm sure I've seen it in other classes too.

 

It would make sense to require the parameters if it were a static method, but myself being an experienced software developer that's fairly new to Minecraft Forge modding, I'm just trying to understand if there's some history or a reason why it's like this?

Choonster Reality Controller

Choonster

Posted
Posted 
Block#isAir

is a method added by Forge. Presumably it takes parameters so mods can base the result on some property of the location (e.g. blockstate/metadata, 

TileEntity

value, per-world or per-level values).

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

jeffryfisher World Shaper

jeffryfisher

Posted
Posted

In other words, isAir is like an abstract method whose parameters are there to be used when child classes override it.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

jabelar Reality Controller

jabelar

Posted
Posted

I think JeffryFisher's answer is the main reason. I also suspect that some parameters are just left-over from some coding change. I'm sure you have experience of coding a method thinking you'll need certain parameters, then later you revise your code and eventually some parameters become unused.

 

Or maybe that is just me...

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

LexManos Reality Controller

LexManos

Posted
Posted

We don't control the code the modders write.

We don't control the code the mojang writes.

Modders wanted more information for this and other methods in block, Forge added that information.

Remember that Blocks only have ONE instance, so no, the world and position are not available to the blocks. Hence the addition.

That's the entire point of Forge.

We have to keep compatibility with vanilla, so we have to keep the old methods and call them as well.

Stop trying to apply a overarching cohesive single design to Minecraft. It's simply not there.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Sandermall
      updateShape functionality deep dive

      By Sandermall · Posted

      Hello all. I'm currently grappling with the updateShape method in a custom class extending Block.  My code currently looks like this: The conditionals in CheckState are there to switch blockstate properties, which is working fine, as it functions correctly every time in getStateForPlacement.  The problem I'm running into is that when I update a state, the blocks seem to call CheckState with the position of the block which was changed updated last.  If I build a wall I can see the same change propagate across. My question thus is this: is updateShape sending its return to the neighbouring block?  Is each block not independently executing the updateShape method, thus inserting its own current position?  The first statement appears to be true, and the second false (each block is not independently executing the method). I have tried to fix this by saving the block's own position to a variable myPos at inception, and then feeding this in as CheckState(myPos) but this causes a worse outcome, where all blocks take the update of the first modified block, rather than just their neighbour.  This raises more questions than it answers, obviously: how is a different instance's variable propagating here?  I also tried changing it so that CheckState did not take a BlockPos, but had myPos built into the body - same problem. I have previously looked at neighbourUpdate and onNeighbourUpdate, but could not find a way to get this to work at all.  One post on here about updatePostPlacement and other methods has proven itself long superceded.  All other sources on the net seem to be out of date. Many thanks in advance for any help you might offer me, it's been several days now of trying to get this work and several weeks of generally trying to get round this roadblock.  - Sandermall
    • djdoyle1556
      crash dump

      By djdoyle1556 · Posted

      sorry, I might be stupid, but how do I open it? because the only options I have are too X out, copy it, which doesn't work and send crash report, which doesn't show it to me, also, sorry for taking so long.
    • Radio_Man
      Maybe wrong place to post but need help installing forge.

      By Radio_Man · Posted

      ah ok  
    • Choonster
      BUG: Cactus Flower Placement is BROKEN

      By Choonster · Posted

      Can you reproduce this with version 55.0.21? A whole lot of plant placement issues were just fixed in this PR.
    • KenshinSpirit
      java.lang.IllegalStateException: Pose stack not empty

      By KenshinSpirit · Posted

      Necro'ing that thread to ask if you found a solution ? I'm encountering the same crash on loading the world. I created the world in Creative to test my MP, went into survival to test combat, died, crashed on respawn and since then crash on loading the world. Deactivating Oculus isn't fixing it either, and I don't have Optifine (Twilight forest is incompatible)

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept