[1.8.9] Basic method @Override not working?

[thebest108]

So I have a class that extends the PlayerControllerMP class, and one of the methods I'm trying to replace is clickBlockCreative(). Am I going crazy or is this a bug!?

 

In the PlayerControllerMP class

public static void clickBlockCreative(Minecraft mcIn, PlayerControllerMP p_178891_1_, BlockPos p_178891_2_, EnumFacing p_178891_3_)
    {
        if (!mcIn.theWorld.extinguishFire(mcIn.thePlayer, p_178891_2_, p_178891_3_))
        {
            p_178891_1_.onPlayerDestroyBlock(p_178891_2_, p_178891_3_);
        }
    }

 

In my class

@Override
    public static void clickBlockCreative(Minecraft mcIn, PlayerControllerMP p_178891_1_, BlockPos p_178891_2_, EnumFacing p_178891_3_){
    	World worldIn = Minecraft.getMinecraft().theWorld;
    	int shipHit = ValkyrianWarfareMod.clientShipManager.getShipHitTick();
    	if(shipHit!=0){
    		worldIn = ((Ship)mcIn.theWorld.getEntityByID(shipHit)).region;
    		p_178891_2_ = ValkyrianWarfareMod.clientShipManager.hitPos;
    	}
    	if (!worldIn.extinguishFire(mcIn.thePlayer, p_178891_2_, p_178891_3_)){
    		p_178891_1_.onPlayerDestroyBlock(p_178891_2_, p_178891_3_);
        }
    }

 

Eclipse spits out an error and it crashes the game. "The method clickBlockCreative(Minecraft, PlayerControllerMP, BlockPos, EnumFacing) of type CustomPlayerController must override or implement a supertype method"

[Draco18s]

You can't override a static method

[thebest108]

[jeffryfisher]

I can sympathize with the modder because the method, although static, takes a parameter that is an instance of the class. That's a red flag in my design book (if the method needs an instance, then why on earth is it static???).

 

Find out what calls this "clickBlockCreative", and then see if you can inject your ship hit and test ahead of the call. Alternatively, let the static method handle its fire first; put your ship code into onPlayerDestroyBlock.